feat(workers): SPEC_REVIEW + TASK_REVIEW manual-enqueue (Phase 3) #43

Merged

janpeter merged 4 commits from feat/codex-spec-task-review-phase3 into main 2026-06-10 18:54:58 +02:00

Conversation 0 Commits 4 Files changed 16 +976 -9

janpeter commented 2026-06-10 18:12:20 +02:00

Owner

Copy link

Phase 3 (codex spec- + task-review) — workers manual-enqueue-keten:

• Kinds: SPEC_REVIEW + TASK_REVIEW in beide MANUAL_JOB_KINDS-arrays (Phase 2-discipline)
• docSlug-keten (SPEC_REVIEW): DOC_SLUG_PATTERN, draft-input + zod, validatieregels, context-patch-guard, editor-mapping + rehydratie, launch-preview-threading
• Templates: spec-review + task-review — defaultRuntime: codex + defaultAdapter: codex_cli (adapter-coherentie), defaultCapability: review, niet-lege promptSections
• Enqueue: docSlug → ProductDoc.id via de compound unique (product_id_folder_slug, folder SPECS) → claude_jobs.doc_id; taskId → task_id voor TASK_REVIEW (existence-guard binnen product+user); TASK_IMPLEMENTATION byte-identiek
• KIND_LABELS: SPEC-RVW/TASK-RVW (caps-badge-conventie, gelijk aan web)
• Kwaliteitsfix: kind-gate op taskId in de launch-preview-context (symmetrie met prUrl/docSlug)

Verify: 532/534 (2 skipped, pre-existing) · lint + tsc clean · shared-bump → e55a44c.
Vereist de Scrum4Me-migratie (PR #70) vóór deploy — claude_jobs.doc_id + enum-waarden.

Spec/plan: scrum4me-mcp feat/codex-spec-task-review-phase3 docs/superpowers (§8, Taken 10-12).

🤖 Generated with Claude Code

Phase 3 (codex spec- + task-review) — workers manual-enqueue-keten: - **Kinds**: `SPEC_REVIEW` + `TASK_REVIEW` in **beide** MANUAL_JOB_KINDS-arrays (Phase 2-discipline) - **docSlug-keten** (SPEC_REVIEW): `DOC_SLUG_PATTERN`, draft-input + zod, validatieregels, context-patch-guard, editor-mapping + rehydratie, launch-preview-threading - **Templates**: `spec-review` + `task-review` — `defaultRuntime: codex` + `defaultAdapter: codex_cli` (adapter-coherentie), `defaultCapability: review`, niet-lege promptSections - **Enqueue**: `docSlug → ProductDoc.id` via de compound unique (`product_id_folder_slug`, folder SPECS) → `claude_jobs.doc_id`; `taskId → task_id` voor TASK_REVIEW (existence-guard binnen product+user); TASK_IMPLEMENTATION byte-identiek - **KIND_LABELS**: `SPEC-RVW`/`TASK-RVW` (caps-badge-conventie, gelijk aan web) - Kwaliteitsfix: kind-gate op `taskId` in de launch-preview-context (symmetrie met prUrl/docSlug) **Verify:** 532/534 (2 skipped, pre-existing) · lint + tsc clean · shared-bump → `e55a44c`. Vereist de Scrum4Me-migratie (PR #70) vóór deploy — `claude_jobs.doc_id` + enum-waarden. Spec/plan: scrum4me-mcp `feat/codex-spec-task-review-phase3` docs/superpowers (§8, Taken 10-12). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

janpeter added 4 commits 2026-06-10 18:12:20 +02:00

feat(workers): SPEC_REVIEW/TASK_REVIEW kinds + docSlug-validatie + context-patch (Phase 3) ... b77f7c617f

- vendor/scrum4me-shared gebumpt naar e55a44c (Phase 3 schema: SPEC_REVIEW, TASK_REVIEW, ReviewVerdict, ReviewLog, doc_id)
- lib/manual-jobs/validation.ts: MANUAL_JOB_KINDS += SPEC_REVIEW/TASK_REVIEW, DOC_SLUG_PATTERN geëxporteerd, docSlug-veld + SPEC_REVIEW/TASK_REVIEW-validatieregels toegevoegd
- lib/manual-job-draft.ts: MANUAL_JOB_KINDS += SPEC_REVIEW/TASK_REVIEW, ManualJobDraftInput.docSlug, zod-schema += docSlug, context.docSlug-threading in buildManualJobLaunchPreview
- lib/manual-jobs/context-patch.ts: SPEC_REVIEW (docSlug) + TASK_REVIEW (taskId) shape-validatie toegevoegd
- components/jobs/job-card.tsx + jobs-column.tsx: KIND_LABELS uitgebreid (exhaustive-map typecheck)
- 13 nieuwe tests (TDD: RED→GREEN), 511 tests totaal

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

feat(workers): spec-review + task-review templates + editor-keten (Phase 3) ... c75b11bafc

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

feat(workers): enqueue-resolutie docSlug→doc_id + taskId→task_id + KIND_LABELS (Phase 3) ... 777ed4ec9d

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

fix(workers): kind-gate op taskId in launch-preview-context + TASK_REVIEW-rehydratietest (kwaliteitsreview) ... c9992c93dd

- Gate taskId context-threading to TASK_IMPLEMENTATION + TASK_REVIEW only, blocking silent carryover in other kinds (PR_REVIEW, SPEC_REVIEW, PLAN_CHAT) for clarity
- Add comprehensive test verifying kind-gate blocks taskId in non-task kinds while permitting it in task kinds
- Add TASK_REVIEW rehydration test (symmetrie met PR_REVIEW/SPEC_REVIEW) proving saved drafts restore task_id from context

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

janpeter merged commit 5c60ecba1b into main 2026-06-10 18:54:58 +02:00

janpeter deleted branch feat/codex-spec-task-review-phase3 2026-06-10 18:54:58 +02:00

janpeter referenced this pull request from a commit 2026-06-10 18:54:59 +02:00

Merge pull request 'feat(workers): SPEC_REVIEW + TASK_REVIEW manual-enqueue (Phase 3)' (#43) from feat/codex-spec-task-review-phase3 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

janpeter/scrum4me-workers!43

No description provided.