janpeter/scrum4me-shared
1
1
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

feat(queue): shared review document contract for IDEA-214 #60

Merged
janpeter merged 1 commit from codex/idea-214-review-documents into main 2026-09-14 16:51:31 +02:00
Conversation 1 Commits 1 Files changed 6 +259
janpeter commented 2026-09-14 16:47:58 +02:00
Owner
Copy link

IDEA-214 introduces the shared, platform-neutral contract that workers and later iOS can reuse for exact review-document references and the s4m-markdown-v1 profile.

Changes:

  • adds ReviewDocumentRef, schema validation, readers, and parent-authority resolution for review_request / reviewed metadata
  • adds Markdown profile constants and reusable fixtures
  • documents the new contract in the shared README

Validation:

  • npm run verify passed for scrum4me-shared: dep-clean, typecheck, 318/318 tests
  • independent Task 1 review found no Critical/Important/Minor issues
IDEA-214 introduces the shared, platform-neutral contract that workers and later iOS can reuse for exact review-document references and the `s4m-markdown-v1` profile. Changes: - adds `ReviewDocumentRef`, schema validation, readers, and parent-authority resolution for `review_request` / `reviewed` metadata - adds Markdown profile constants and reusable fixtures - documents the new contract in the shared README Validation: - `npm run verify` passed for scrum4me-shared: dep-clean, typecheck, 318/318 tests - independent Task 1 review found no Critical/Important/Minor issues
feat(queue): define versioned review document references and Markdown profile
All checks were successful
CI / Verify (pull_request) Successful in 50s
Details
688b959fba
s4m-codex-reviewer approved these changes 2026-09-14 16:51:13 +02:00
s4m-codex-reviewer left a comment
Copy link

APPROVED

Geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden.

Findings

  • Geen blocking of error-severity findings gevonden.

Review-notities

De nieuwe lib/queue-review-documents.ts blijft binnen het gedeelde-library contract: pure TypeScript, alleen zod als externe import, defensieve parsing via strikte schema's, en duidelijke parent-resolutie voor reviewed berichten. De tests dekken geldige product-doc/git-referenties, versie-afwijzing, duplicaten, path traversal, onveilige gitpaden en de Markdown-profiel-fixture. README-documentatie is aanwezig voor discoverability.

# APPROVED Geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden. ## Findings - Geen blocking of error-severity findings gevonden. ## Review-notities De nieuwe `lib/queue-review-documents.ts` blijft binnen het gedeelde-library contract: pure TypeScript, alleen `zod` als externe import, defensieve parsing via strikte schema's, en duidelijke parent-resolutie voor `reviewed` berichten. De tests dekken geldige product-doc/git-referenties, versie-afwijzing, duplicaten, path traversal, onveilige gitpaden en de Markdown-profiel-fixture. README-documentatie is aanwezig voor discoverability.
Sign in to join this conversation.
Reviewers
No reviewers
s4m-codex-reviewer
Labels
Clear labels   
severity/s4
No labels
severity/s4
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/scrum4me-shared!60
No description provided.