janpeter/scrum4me-shared
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(job-config): .js-extensies op type-imports (NodeNext-consumers) #22

Merged
janpeter merged 1 commit from claude/job-config-js-ext into main 2026-06-17 09:31:04 +02:00
Conversation 0 Commits 1 Files changed 1 +2 -2
janpeter commented 2026-06-17 09:27:52 +02:00
Owner
Copy link

Summary

Kleine NodeNext-compat-fix op lib/job-config.ts. Fase 1 (JobKindConfig, PR #21) voegde twee extensionless type-imports toe:

import type { AgentRuntime } from './agent-runtime'
import type { CodexSandboxMode } from './codex-config'

scrum4me-shared zelf (moduleResolution: Bundler) accepteert dat, maar NodeNext-consumers (scrum4me-mcp, dat @shared/job-config importeert en de vendored lib typecheckt) falen met TS2835: Relative import paths need explicit file extensions. Fix: .js-extensies toevoegen, consistent met de bestaande product-doc-*-imports.

Surfaced tijdens fase 3 (scrum4me-mcp) van de JobKindConfig-track.

Test Plan

  • npm run typecheck (shared, Bundler) — exit 0
  • npx vitest run (shared) — 161 tests groen
  • geverifieerd dat scrum4me-mcp (tsc --noEmit, NodeNext) met deze fix 0 errors geeft (was 2× TS2835 op de vendored lib)

🤖 Generated with Claude Code

## Summary Kleine NodeNext-compat-fix op `lib/job-config.ts`. Fase 1 (JobKindConfig, PR #21) voegde twee **extensionless** type-imports toe: ```ts import type { AgentRuntime } from './agent-runtime' import type { CodexSandboxMode } from './codex-config' ``` `scrum4me-shared` zelf (`moduleResolution: Bundler`) accepteert dat, maar **NodeNext-consumers** (scrum4me-mcp, dat `@shared/job-config` importeert en de vendored lib typecheckt) falen met `TS2835: Relative import paths need explicit file extensions`. Fix: `.js`-extensies toevoegen, consistent met de bestaande `product-doc-*`-imports. Surfaced tijdens fase 3 (scrum4me-mcp) van de JobKindConfig-track. ## Test Plan - [x] `npm run typecheck` (shared, Bundler) — exit 0 - [x] `npx vitest run` (shared) — 161 tests groen - [x] geverifieerd dat scrum4me-mcp (`tsc --noEmit`, NodeNext) met deze fix **0 errors** geeft (was 2× TS2835 op de vendored lib) 🤖 Generated with [Claude Code](https://claude.com/claude-code) 
Mijn fase-1 voegde extensionless type-imports toe (./agent-runtime,
./codex-config). Shared (moduleResolution=Bundler) accepteert dat, maar
NodeNext-consumers zoals scrum4me-mcp falen met TS2835. Aligned met de
product-doc-*-conventie (.js).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/scrum4me-shared!22
No description provided.