fix(worktree): init submodules + run prepare:worktree hook per job worktree #27

Merged

janpeter merged 1 commit from fix/worktree-submodule-and-codegen into main

2026-05-28 22:59:53 +02:00

janpeter commented

2026-05-28 22:51:24 +02:00

Owner

Pairs with Scrum4Me PR #53 (adds the prepare:worktree script).

Why

npm run verify runs inside per-job git worktrees. A fresh git worktree add checks out the branch tree but NOT submodules, and verify never triggers prebuild codegen. So Scrum4Me job worktrees failed on 12 @shared/* errors (alias -> vendor/scrum4me-shared submodule, not checked out) + 4 lib/manual.generated.ts errors (gitignored). Toolchain itself works (node_modules symlinked, PR #26).

What

prepareWorktree() after the node_modules symlink (both add-paths): (1) git submodule update --init --recursive guarded on .gitmodules; (2) optional prepare:worktree npm script if the repo declares one. Best-effort.

Verified

Manual worker worktree: submodule init + manual:build -> verify GREEN (140 files / 1235 tests).

Pairs with Scrum4Me PR #53 (adds the prepare:worktree script). ## Why `npm run verify` runs inside per-job git worktrees. A fresh `git worktree add` checks out the branch tree but NOT submodules, and verify never triggers prebuild codegen. So Scrum4Me job worktrees failed on 12 `@shared/*` errors (alias -> vendor/scrum4me-shared submodule, not checked out) + 4 `lib/manual.generated.ts` errors (gitignored). Toolchain itself works (node_modules symlinked, PR #26). ## What `prepareWorktree()` after the node_modules symlink (both add-paths): (1) `git submodule update --init --recursive` guarded on .gitmodules; (2) optional `prepare:worktree` npm script if the repo declares one. Best-effort. ## Verified Manual worker worktree: submodule init + manual:build -> verify GREEN (140 files / 1235 tests).

janpeter added 1 commit

2026-05-28 22:51:24 +02:00

fix(worktree): init submodules + run prepare:worktree hook per job worktree 22d3c868ee

A fresh `git worktree add` checks out the branch tree but not its
submodules, and `npm run verify` never triggers the `prebuild` codegen
that produces gitignored generated files. So job worktrees failed
lint/typecheck/test on every submodule-backed path alias (Scrum4Me's
`@shared/*` -> vendor/scrum4me-shared) and on `*.generated` imports
(lib/manual.generated.ts) — even though the toolchain itself works
(node_modules already symlinked by linkNodeModules).

prepareWorktree() now, after the node_modules symlink:
  - `git submodule update --init --recursive` (guarded on .gitmodules,
    no-op for repos without submodules)
  - runs an optional `prepare:worktree` npm script if the repo declares
    one, so repo-specific codegen stays out of this generic worker code

Both are best-effort (never fail worktree creation); a genuine failure
surfaces in verify rather than blocking the job. Verified manually in a
worker worktree: submodule init + manual:build -> `npm run verify` green
(140 files / 1235 tests).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

janpeter merged commit eb916c2024 into main

2026-05-28 22:59:53 +02:00

janpeter referenced this pull request from a commit

2026-05-28 22:59:53 +02:00

Merge pull request 'fix(worktree): init submodules + run prepare:worktree hook per job worktree' (#27) from fix/worktree-submodule-and-codegen into main

janpeter referenced this pull request from a commit

2026-07-04 16:22:57 +02:00

chore(shared): bump — idea-brainstorm-registry + Skill in IDEA_GRILL defaults (M18)

janpeter referenced this pull request

2026-07-04 16:23:10 +02:00

M18: idea-brainstorm-skill — shared-bump + skill-aanroep in de grill-prompt #63