fix(prompts): queue-reviewers lezen de payload één keer en openen geen __-bronnen (T-178) #218
No reviewers
Labels
No labels
severity/s2
severity/s3
severity/s4
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
janpeter/scrum4me-mcp!218
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "claude/idea-252-review-prompts"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
IDEA-252, PBI-38, story ST-059, task T-178. The sealed queue reviewers now treat the payload as their only input and do not open
__-prefixed sources.Plan:
docs/superpowers/plans/2026-10-12-review-vaste-context-verkleinen.md, story 2 task 1. The plan is on main since #217.review.mdandreview.codex.md: the sentence "if the two ever differ, that file wins" is gone.__dispatch_inputand__repository_baseare now named as infrastructure that the model does not open and that gets nochecksentry. Reading duty andchecksnow cover document keys only. Both runtimes carry the same rules.src/dispatch/sources.ts: only a comment changed. The task file is the hash-bound source the child builds its payload from, not the child's only copy.__tests__/kind-prompts.test.ts: the M41 case is split. Task prompts still point at/sources/__dispatch_input, while review prompts only name the key. A new case pins the review rules for both runtimes.Verification:
npx vitest run: 2685 passed, 84 skipped. The baseline was 2683; the difference is the 2 new cases.npm run typecheckandnpm run typecheck:tests: exit 0.Rollout: the dispatch image bakes these prompts in from main. That rebuild is T-185, which has its own gate. The new smoke check from scrum4me-docker#133 expects exactly these prompts.
🤖 Generated with Claude Code
7a912cece3e89c0961d4APPROVED
Findings:
De wijzigingen ronden T-178 af volgens het plan: beide runtimes gebruiken payload.json als enige taakinput, openen geen infrastructuurkeys en vragen alleen checks voor documentkeys. De bestaande bronvalidatie reserveert het
__-prefix. De aangepaste tests en het broncommentaar sluiten hierbij aan; geen afwijking van de geraadpleegde productstandaarden gevonden.plan gekoppeld via pr_refs; references: T-178, T-185, ST-059, PBI-38. Het meegeleverde plan-document PBI-38 is afgekapt weergegeven; het volledige taakplan T-178 en de acceptatiecriteria van ST-059 zijn beschikbaar en getoetst.
omittedis leeg. Imagebouw, live-smoke en uitrol horen bij T-185 en zijn geen opleverclaim van deze PR.Verificatie op commit
7a912cece3fe1f02cf9213cb4aff86c2e6cbde24:npm test -- kind-prompts(76 geslaagd),npm test(2.685 geslaagd, 84 overgeslagen),npm run typechecken de via pretest uitgevoerdetypecheck:testsgeslaagd.git diff --checkzonder fouten. Geen live dispatch of uitrol uitgevoerd.