fix(prompts): queue-reviewers lezen de payload één keer en openen geen __-bronnen (T-178) #218

Merged
janpeter merged 1 commit from claude/idea-252-review-prompts into main 2026-10-12 23:39:05 +02:00
Owner

IDEA-252, PBI-38, story ST-059, task T-178. The sealed queue reviewers now treat the payload as their only input and do not open __-prefixed sources.

Plan: docs/superpowers/plans/2026-10-12-review-vaste-context-verkleinen.md, story 2 task 1. The plan is on main since #217.

  • review.md and review.codex.md: the sentence "if the two ever differ, that file wins" is gone. __dispatch_input and __repository_base are now named as infrastructure that the model does not open and that gets no checks entry. Reading duty and checks now cover document keys only. Both runtimes carry the same rules.
  • src/dispatch/sources.ts: only a comment changed. The task file is the hash-bound source the child builds its payload from, not the child's only copy.
  • __tests__/kind-prompts.test.ts: the M41 case is split. Task prompts still point at /sources/__dispatch_input, while review prompts only name the key. A new case pins the review rules for both runtimes.
  • Task prompts: unchanged.

Verification:

  • npx vitest run: 2685 passed, 84 skipped. The baseline was 2683; the difference is the 2 new cases.
  • npm run typecheck and npm run typecheck:tests: exit 0.

Rollout: the dispatch image bakes these prompts in from main. That rebuild is T-185, which has its own gate. The new smoke check from scrum4me-docker#133 expects exactly these prompts.

🤖 Generated with Claude Code

IDEA-252, PBI-38, story ST-059, task T-178. The sealed queue reviewers now treat the payload as their only input and do not open `__`-prefixed sources. Plan: `docs/superpowers/plans/2026-10-12-review-vaste-context-verkleinen.md`, story 2 task 1. The plan is on main since #217. - **`review.md` and `review.codex.md`:** the sentence "if the two ever differ, that file wins" is gone. `__dispatch_input` and `__repository_base` are now named as infrastructure that the model does not open and that gets no `checks` entry. Reading duty and `checks` now cover document keys only. Both runtimes carry the same rules. - **`src/dispatch/sources.ts`:** only a comment changed. The task file is the hash-bound source the child builds its payload from, not the child's only copy. - **`__tests__/kind-prompts.test.ts`:** the M41 case is split. Task prompts still point at `/sources/__dispatch_input`, while review prompts only name the key. A new case pins the review rules for both runtimes. - **Task prompts:** unchanged. Verification: - `npx vitest run`: 2685 passed, 84 skipped. The baseline was 2683; the difference is the 2 new cases. - `npm run typecheck` and `npm run typecheck:tests`: exit 0. Rollout: the dispatch image bakes these prompts in from main. That rebuild is T-185, which has its own gate. The new smoke check from scrum4me-docker#133 expects exactly these prompts. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(prompts): queue-reviewers lezen de payload één keer en openen geen __-bronnen
Some checks failed
CI / Final merge attestation and immutable publication (pull_request) Has been skipped
CI / PR candidate (never published) (pull_request) Failing after 57s
7a912cece3
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
janpeter force-pushed claude/idea-252-review-prompts from 7a912cece3
Some checks failed
CI / Final merge attestation and immutable publication (pull_request) Has been skipped
CI / PR candidate (never published) (pull_request) Failing after 57s
to e89c0961d4
All checks were successful
CI / Final merge attestation and immutable publication (pull_request) Has been skipped
CI / PR candidate (never published) (pull_request) Successful in 5m36s
2026-10-12 23:35:23 +02:00
Compare
s4m-codex-reviewer left a comment

APPROVED

Findings:

  • Geen findings in de beoordeelde diff.

De wijzigingen ronden T-178 af volgens het plan: beide runtimes gebruiken payload.json als enige taakinput, openen geen infrastructuurkeys en vragen alleen checks voor documentkeys. De bestaande bronvalidatie reserveert het __-prefix. De aangepaste tests en het broncommentaar sluiten hierbij aan; geen afwijking van de geraadpleegde productstandaarden gevonden.

plan gekoppeld via pr_refs; references: T-178, T-185, ST-059, PBI-38. Het meegeleverde plan-document PBI-38 is afgekapt weergegeven; het volledige taakplan T-178 en de acceptatiecriteria van ST-059 zijn beschikbaar en getoetst. omitted is leeg. Imagebouw, live-smoke en uitrol horen bij T-185 en zijn geen opleverclaim van deze PR.

Verificatie op commit 7a912cece3fe1f02cf9213cb4aff86c2e6cbde24: npm test -- kind-prompts (76 geslaagd), npm test (2.685 geslaagd, 84 overgeslagen), npm run typecheck en de via pretest uitgevoerde typecheck:tests geslaagd. git diff --check zonder fouten. Geen live dispatch of uitrol uitgevoerd.

# APPROVED Findings: - Geen findings in de beoordeelde diff. De wijzigingen ronden T-178 af volgens het plan: beide runtimes gebruiken payload.json als enige taakinput, openen geen infrastructuurkeys en vragen alleen checks voor documentkeys. De bestaande bronvalidatie reserveert het `__`-prefix. De aangepaste tests en het broncommentaar sluiten hierbij aan; geen afwijking van de geraadpleegde productstandaarden gevonden. plan gekoppeld via pr_refs; references: T-178, T-185, ST-059, PBI-38. Het meegeleverde plan-document PBI-38 is afgekapt weergegeven; het volledige taakplan T-178 en de acceptatiecriteria van ST-059 zijn beschikbaar en getoetst. `omitted` is leeg. Imagebouw, live-smoke en uitrol horen bij T-185 en zijn geen opleverclaim van deze PR. Verificatie op commit `7a912cece3fe1f02cf9213cb4aff86c2e6cbde24`: `npm test -- kind-prompts` (76 geslaagd), `npm test` (2.685 geslaagd, 84 overgeslagen), `npm run typecheck` en de via pretest uitgevoerde `typecheck:tests` geslaagd. `git diff --check` zonder fouten. Geen live dispatch of uitrol uitgevoerd.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/scrum4me-mcp!218
No description provided.