fix(prompts): queue reviewers review statically, no package installs (ISS-15) #205

Merged
janpeter merged 1 commit from fix/iss15-review-static-no-registry into main 2026-10-09 09:32:13 +02:00
Owner

Fixes the cause of ISS-15.

Problem: the dispatch review container has no package registry (egress allows only the model gateway). On 2026-10-09, job 89d5f048 ran timeout 240 npm ci. npm got a 403, survived timeout's SIGTERM and spun at 100% CPU for about nine minutes. The review finished 21 s before its 30-minute max_duration_seconds. Reproduced on scrum4me-srv with the exact child flags. timeout -k does stop it.

Change: queue/review.md and queue/review.codex.md each get one Boundaries bullet: no registry, no installs, review statically, and report a requested test or build as a not_run check.

Rollout: the prompts are baked into the model image (scrum4me-docker Dockerfile.dispatch:19-28). After merge this needs a model-image rebuild, a new profile revision per slot and broker.json (same procedure as iss345).

Not included: queue/task*.md has the same theoretical hang risk. Left out of scope on purpose.

🤖 Generated with Claude Code

Fixes the cause of ISS-15. **Problem:** the dispatch review container has no package registry (egress allows only the model gateway). On 2026-10-09, job `89d5f048` ran `timeout 240 npm ci`. npm got a 403, survived timeout's SIGTERM and spun at 100% CPU for about nine minutes. The review finished 21 s before its 30-minute `max_duration_seconds`. Reproduced on scrum4me-srv with the exact child flags. `timeout -k` does stop it. **Change:** `queue/review.md` and `queue/review.codex.md` each get one Boundaries bullet: no registry, no installs, review statically, and report a requested test or build as a `not_run` check. **Rollout:** the prompts are baked into the model image (`scrum4me-docker` `Dockerfile.dispatch:19-28`). After merge this needs a model-image rebuild, a new profile revision per slot and `broker.json` (same procedure as iss345). Not included: `queue/task*.md` has the same theoretical hang risk. Left out of scope on purpose. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(prompts): queue reviewers review statically, no package installs (ISS-15)
All checks were successful
CI / Final merge attestation and immutable publication (pull_request) Has been skipped
CI / PR candidate (never published) (pull_request) Successful in 5m37s
bdb129ca89
The dispatch review container has no package registry. On 2026-10-09 a
reviewer ran `timeout 240 npm ci`, npm got a 403, survived timeout's SIGTERM
and spun at 100% CPU for about nine minutes. The review finished 21 s before
its 30-minute hard stop. The prompts now say there is no registry, forbid
installs, and report a requested test or build as a not_run check.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
s4m-codex-reviewer left a comment

APPROVED

Findings:

  • Geen findings.

Beide queue-reviewprompts bevatten inhoudelijk dezelfde beperking op package-installaties en rapporteren ontbrekende test-/builduitvoering als not_run met expliciete evidence. Dit past binnen de bestaande read-only- en netwerkgrenzen; not_run is al toegestaan in het manifest. Geen strijd met de geraadpleegde productstandaarden gevonden.

Verificatie: live PR-diff identiek aan de payload, head-commit gecontroleerd en beide volledige prompts op de opgegeven commit gelezen. Statische checks op de manifeststatus en evidence geslaagd. Geen build, testsuite of containerproef uitgevoerd; deze PR wijzigt uitsluitend twee Markdownregels. De benodigde image-rebuild en profiel-/brokerrotatie staan beschreven als uitrol na merge.

geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden.

# APPROVED Findings: - Geen findings. Beide queue-reviewprompts bevatten inhoudelijk dezelfde beperking op package-installaties en rapporteren ontbrekende test-/builduitvoering als `not_run` met expliciete evidence. Dit past binnen de bestaande read-only- en netwerkgrenzen; `not_run` is al toegestaan in het manifest. Geen strijd met de geraadpleegde productstandaarden gevonden. Verificatie: live PR-diff identiek aan de payload, head-commit gecontroleerd en beide volledige prompts op de opgegeven commit gelezen. Statische checks op de manifeststatus en evidence geslaagd. Geen build, testsuite of containerproef uitgevoerd; deze PR wijzigt uitsluitend twee Markdownregels. De benodigde image-rebuild en profiel-/brokerrotatie staan beschreven als uitrol na merge. geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/scrum4me-mcp!205
No description provided.