test: align canary test timeout with subprocess deadline #173

Merged

janpeter merged 1 commit from fix/stdio-canary-test-timeout into main

2026-09-30 14:31:58 +02:00

janpeter commented

2026-09-30 14:26:51 +02:00

Owner

The spawned stdio-canary test allowed its child process 60 seconds but inherited Vitest's 5-second test timeout. Final-release CI run 240 therefore failed during a slower startup even though the reviewed merge tree was correct.

Give this test a 65-second budget, derived from the unchanged 60-second child-process deadline plus 5 seconds of runner/assertion overhead. All 15 assertion lines, the process deadline, and the global test configuration remain unchanged.

Validation: reproduced the original 5-second timeout by adding a temporary 6-second delay at each real canary CLI startup (about 12.7 seconds overall). With this change, the identical delayed probe passes 2/2 tests; the normal run also passes 2/2. Both runs include the test TypeScript check, and git diff --check passes. The temporary delay probe is outside the repository and is not part of the patch.

Follow-up to PR #172; ST-051 / T-155. Merge is performed by JP; local activation still waits for his explicit signal and successful final-release CI. Use a merge commit because the release attestation requires two parents.

The spawned stdio-canary test allowed its child process 60 seconds but inherited Vitest's 5-second test timeout. [Final-release CI run 240](https://git.jp-visser.nl/janpeter/scrum4me-mcp/actions/runs/240/jobs/1) therefore failed during a slower startup even though the reviewed merge tree was correct. Give this test a 65-second budget, derived from the unchanged 60-second child-process deadline plus 5 seconds of runner/assertion overhead. All 15 assertion lines, the process deadline, and the global test configuration remain unchanged. Validation: reproduced the original 5-second timeout by adding a temporary 6-second delay at each real canary CLI startup (about 12.7 seconds overall). With this change, the identical delayed probe passes 2/2 tests; the normal run also passes 2/2. Both runs include the test TypeScript check, and git diff --check passes. The temporary delay probe is outside the repository and is not part of the patch. Follow-up to PR #172; ST-051 / T-155. Merge is performed by JP; local activation still waits for his explicit signal and successful final-release CI. Use a merge commit because the release attestation requires two parents.

janpeter added 1 commit

2026-09-30 14:26:51 +02:00

test: align canary test timeout with subprocess deadline

CI / Final merge attestation and immutable publication (pull_request) Has been skipped

Details

CI / PR candidate (never published) (pull_request) Successful in 8m23s

Details

a9373d5734

s4m-codex-reviewer approved these changes

2026-09-30 14:30:50 +02:00

s4m-codex-reviewer left a comment

Verdict: APPROVED

Geen blocking, error- of overige review-findings aangetroffen.

Geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden.

De testtimeout ligt nu 5 seconden boven de begrensde child-process-timeout, zodat trage koude CI-starts niet ten onrechte door Vitest worden afgebroken.

## Verdict: APPROVED Geen blocking, error- of overige review-findings aangetroffen. Geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden. De testtimeout ligt nu 5 seconden boven de begrensde child-process-timeout, zodat trage koude CI-starts niet ten onrechte door Vitest worden afgebroken.

janpeter merged commit 285c98ae3f into main

2026-09-30 14:31:58 +02:00

janpeter referenced this pull request from a commit

2026-09-30 14:31:59 +02:00

Merge pull request 'test: align canary test timeout with subprocess deadline' (#173) from fix/stdio-canary-test-timeout into main