janpeter/scrum4me-docker
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(codex): forward FORGEJO_TOKEN naar de MCP-subprocess (post_pr_review) #36

Merged
janpeter merged 1 commit from fix/codex-forgejo-token into master 2026-06-10 11:24:59 +02:00
Conversation 0 Commits 1 Files changed 1 +4
janpeter commented 2026-06-10 11:08:30 +02:00
Owner
Copy link

Phase 2-canary NO-GO root-cause-fix (1 regel + comment).

De canary bewees de hele PR_REVIEW-keten end-to-end — codex velde een correct REQUEST_CHANGES-verdict met precies de geplante fouten — maar post_pr_review faalde: requireToken() draait IN de MCP-subprocess en codex forwardt alleen wat in de env_vars-allowlist van config.toml staat. FORGEJO_TOKEN ontbrak (Phase 0 was read-only en had geen Forgejo-writes nodig).

Host-side hoort FORGEJO_TOKEN ook in worker-codex.env (secret, buiten de repo; de hosts kopieren lokaal uit worker-idea.env) — dat gaat via de host-tasks.

Na merge: rebuild + recreate agent-codex op 154 + max2, dan re-canary tegen workers#39.

🤖 Generated with Claude Code

Phase 2-canary NO-GO root-cause-fix (1 regel + comment). De canary bewees de hele PR_REVIEW-keten end-to-end — codex velde een correct REQUEST_CHANGES-verdict met precies de geplante fouten — maar post_pr_review faalde: requireToken() draait IN de MCP-subprocess en codex forwardt alleen wat in de env_vars-allowlist van config.toml staat. FORGEJO_TOKEN ontbrak (Phase 0 was read-only en had geen Forgejo-writes nodig). Host-side hoort FORGEJO_TOKEN ook in worker-codex.env (secret, buiten de repo; de hosts kopieren lokaal uit worker-idea.env) — dat gaat via de host-tasks. Na merge: rebuild + recreate agent-codex op 154 + max2, dan re-canary tegen workers#39. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Phase 2-canary NO-GO root-cause: requireToken() draait in de MCP-subprocess en codex forwardt alleen de env_vars-allowlist — zonder FORGEJO_TOKEN faalt elke Forgejo-write (post_pr_review). Host-side hoort FORGEJO_TOKEN ook in worker-codex.env (secret, buiten de repo).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
janpeter merged commit 2b896351a9 into master 2026-06-10 11:24:59 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/scrum4me-docker!36
No description provided.