docs(runbook): packing recipe matches design §4 E (maintenance window, readlink current per removal) #127

Merged
janpeter merged 1 commit from docs/runbook-inpakrecept-4e into master 2026-10-09 09:34:16 +02:00
Owner

Follow-up to #126 (T-136, scrum4me-server ST-037). Doc only.

The s4m-codex-reviewer review of #126 (REQUEST_CHANGES, merged before it was resolved) found that the packing recipe in runbook §9 lacks two conditions of the pinned design 2026-09-28-compose-kopieen-structureel-design.md §4 E (scrum4me-server):

  1. Maintenance window: no deploy and no other writers in the affected directories, confirmed by JP beforehand. The runbook did not mention it. It is now a precondition: no confirmation, no start.
  2. Step 5: right before each removal, read readlink current (When2Watch) again, and stop if the path has meanwhile become a registered config file or a file under current. The runbook only rechecked the sha256 and docker compose ls --all. A release can become current after step 2 without its sha256 or Compose registration changing, so step 5 could have removed an active compose.yaml.

The wording now follows §4 E. Nothing else changes.

🤖 Generated with Claude Code

Follow-up to #126 (T-136, scrum4me-server ST-037). Doc only. The `s4m-codex-reviewer` review of #126 (REQUEST_CHANGES, merged before it was resolved) found that the packing recipe in runbook §9 lacks two conditions of the pinned design `2026-09-28-compose-kopieen-structureel-design.md` §4 E (scrum4me-server): 1. **Maintenance window:** no deploy and no other writers in the affected directories, confirmed by JP beforehand. The runbook did not mention it. It is now a precondition: no confirmation, no start. 2. **Step 5:** right before *each* removal, read `readlink current` (When2Watch) again, and stop if the path has meanwhile become a registered config file or a file under `current`. The runbook only rechecked the sha256 and `docker compose ls --all`. A release can become `current` after step 2 without its sha256 or Compose registration changing, so step 5 could have removed an active `compose.yaml`. The wording now follows §4 E. Nothing else changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
docs(runbook): packing recipe matches design §4 E: maintenance window and readlink current before each removal
All checks were successful
CI / Compose config (pull_request) Successful in 8s
CI / Build-arg coverage (pull_request) Successful in 7s
CI / Scanner gelijk aan bron (pull_request) Successful in 7s
CI / Docker build (pull_request) Successful in 1m58s
874977a8a8
PR #126 review: the recipe in §9 lacked two conditions of the pinned
scrum4me-server design (2026-09-28-compose-kopieen-structureel-design.md
§4 E): a maintenance window JP confirms beforehand, and in step 5 a fresh
readlink current before every removal with a stop when the path has become
registered or lies under current. A When2Watch release can become current
after step 2 without its sha256 or Compose registration changing, so step 5
could remove an active compose file. Follow-up to T-136.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
janpeter merged commit f62e4ef1ba into master 2026-10-09 09:34:16 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/scrum4me-docker!127
No description provided.