fix(dispatch): the child /tmp tmpfs allows exec (ISS-5) #123
No reviewers
Labels
No labels
severity/s2
severity/s3
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
janpeter/scrum4me-docker!123
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/iss5-child-tmp-exec"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes ISS-5: the dispatch reviewer could not run vitest.
buildContainerArgsgave the child--tmpfs /tmp:rw,nosuid,nodev,size=256m. Docker makes a--tmpfsnoexec unlessexecis given, sonpm ciand vitest failed in the child: native bindings ("failed to map segment from shared object") and executable test stubs (EACCES). Every review of #118, #120 and #121 reported the suite as unverified for this reason.Change
/tmpis nowrw,exec,nosuid,nodev,size=256m, with a test and an operator-doc paragraph.noexecwas no boundary:/outputand/workare bind mounts that the child can already write to and execute from.Evidence
I ran
node:22-bookwormwith the child's flags (--read-only --cap-drop ALL --security-opt no-new-privileges --user 10001:10001,HOME=/tmp/home) and this repo copied into/tmp:/tmpoptionsnpm ci/tmpusedrw,nosuid,nodev,size=256m(before)rw,exec,nosuid,nodev,size=256mI did not analyse the 5 failures; they are probably from the probe environment (a copy without
.git, no docker).Verification
npm run typecheck:dispatchis green.npx vitest run: 1305 passed, 8 skipped, 2 failed. The 2 failures are the known macOS-onlytranscript-retentiontests, identical on master.After deploy
The proof is a review that actually runs vitest. Size stays 256 MB (JP's decision); repos larger than this one (scrum4me-mcp, Scrum4Us) still need measuring, because the tmpfs counts against the profile's
memory_mb(2048).🤖 Generated with Claude Code
COMMENT
Geen blokkerende codefinding gevonden in de drie gewijzigde bestanden op commit
37c9d0b7005cee0926638b8bb0c090059ac0c717. De explicieteexec-optie behoudtnosuid,nodev, de 256 MB-grens en de overige containerisolatie. De wijziging past in de bestaande centrale argumentbouwer; de test en operator-documentatie sluiten erop aan. De beschikbare productarchitectuur geeft geen strijdige eis.Findings
/tmpisnoexec, waardoor Vitest zijn native binding niet kan laden. Docker ontbreekt voor een integratietest. Ook de typecheck is niet groen: de clone mistvendor/scrum4me-shareden rapporteert overige typefouten buiten deze diff. Dit zijn verificatiebeperkingen, geen aangetoonde regressies; daarom het veilige verdictCOMMENT.git diff --checkslaagt. De in de docs vermelde praktijktest is niet onafhankelijk herhaald.geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden.