feat(M16 fase 2): jobs-deeplink-banner + hide action buttons #36

Merged
janpeter merged 3 commits from feat/M16-fase2-scrum4me-readonly into main 2026-05-26 22:47:53 +02:00
Owner

M16 platform-split fase 2 — Scrum4Me changes: admin-acties (cancel/restart) verhuizen naar workers-app.

Wat is er veranderd

Task 20 — JobsDeeplinkBanner component

  • components/jobs/jobs-deeplink-banner.tsx (new) — MD3 primary-container banner met externe link naar workers.jp-visser.nl/jobs
  • Toont alleen voor admins (isAdmin={true} prop check)
  • 2 unit tests (admin renders / non-admin renders nothing)

Task 21 — Wire banner in /jobs/page.tsx

  • Banner gerenderd boven <JobsBoard> met isAdmin={session.isAdmin ?? false}
  • session.isAdmin was al beschikbaar op SessionData (geen extra prisma call)

Task 22 — Remove cancel/restart buttons

  • components/jobs/job-detail-pane.tsx: restart button + bijbehorende imports/state verwijderd (useTransition, toast, Button, DemoTooltip, restartClaudeJobAction, RESTARTABLE_API_STATUSES)
  • job-card.tsx had geen cancel/restart buttons in code (alleen click-handler) — untouched
  • __tests__/components/jobs/job-detail-pane.test.tsx: 4 oude tests vervangen door 4 nieuwe tests die assertion van button-presence omkeren naar absence
  • restartClaudeJobAction source in actions/claude-jobs.ts blijft (worker/MCP gebruikt het server-side)

Verificatie

  • npm run verify groen: 132 test files / 1180 tests passing

Companion PR (scrum4me-workers)

feat(M16 fase 2): full jobs-UI port — split-pane, SSE, admin actions — to be merged in tandem

Architectuur

Na merge: scrum4me-web /jobs toont alle eigen jobs read-only + deeplink-banner voor admins. Admin acties (cancel/restart, cross-user view) via workers.jp-visser.nl/jobs.

**M16 platform-split fase 2** — Scrum4Me changes: admin-acties (cancel/restart) verhuizen naar workers-app. ## Wat is er veranderd ### Task 20 — `JobsDeeplinkBanner` component - `components/jobs/jobs-deeplink-banner.tsx` (new) — MD3 primary-container banner met externe link naar workers.jp-visser.nl/jobs - Toont alleen voor admins (`isAdmin={true}` prop check) - 2 unit tests (admin renders / non-admin renders nothing) ### Task 21 — Wire banner in `/jobs/page.tsx` - Banner gerenderd boven `<JobsBoard>` met `isAdmin={session.isAdmin ?? false}` - `session.isAdmin` was al beschikbaar op `SessionData` (geen extra prisma call) ### Task 22 — Remove cancel/restart buttons - `components/jobs/job-detail-pane.tsx`: restart button + bijbehorende imports/state verwijderd (`useTransition`, `toast`, `Button`, `DemoTooltip`, `restartClaudeJobAction`, `RESTARTABLE_API_STATUSES`) - `job-card.tsx` had geen cancel/restart buttons in code (alleen click-handler) — untouched - `__tests__/components/jobs/job-detail-pane.test.tsx`: 4 oude tests vervangen door 4 nieuwe tests die assertion van button-presence omkeren naar absence - `restartClaudeJobAction` source in `actions/claude-jobs.ts` blijft (worker/MCP gebruikt het server-side) ## Verificatie - `npm run verify` groen: 132 test files / **1180 tests** passing ## Companion PR (scrum4me-workers) feat(M16 fase 2): full jobs-UI port — split-pane, SSE, admin actions — to be merged in tandem ## Architectuur Na merge: scrum4me-web `/jobs` toont alle eigen jobs read-only + deeplink-banner voor admins. Admin acties (cancel/restart, cross-user view) via workers.jp-visser.nl/jobs.
feat(jobs): hide cancel/restart buttons in Scrum4Me /jobs (workers takes over)
Some checks failed
CI / Lint, Typecheck, Test & Build (pull_request) Failing after 1m34s
CI / Deploy Manual (workflow_dispatch) (pull_request) Has been skipped
CI / Detect deploy-relevant changes (pull_request) Has been skipped
CI / Deploy Preview (PR) (pull_request) Has been skipped
CI / Deploy Production (main) (pull_request) Has been skipped
d8bd1d2ab4
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/Scrum4Me!36
No description provided.