feat(M16 fase 1): scripts/promote-admin.ts for workers access #34

Merged
janpeter merged 2 commits from feat/M16-fase1-promote-admin into main 2026-05-26 18:36:57 +02:00
Owner

Summary

Kleine PR ter ondersteuning van M16 fase 1 (scrum4me-workers scaffold). Voegt een script toe om een bestaande Scrum4Me-gebruiker te promoveren tot ADMIN via een UserRole-upsert. Geen schema-wijziging — Role-enum + UserRole-join bestaan al.

Changes

  • scripts/promote-admin.ts — idempotent upsert van UserRole(user_id, role=ADMIN). Dotenv-loading + eigen PrismaClient (Pool + PrismaPg adapter), matchend met scripts/create-admin.ts patroon. DI van prisma in promoteAdmin(username, prisma) voor testbaarheid.
  • __tests__/scripts/promote-admin.test.ts — 3 testcases (success, unknown user, idempotent). Geen vi.mock — gebruikt direct injection van fakePrisma.
  • package.json — npm-script promote-admin

Usage

Lokaal (na PR-merge):

npm run promote-admin -- janpeter

Server (na fase 1 task 18):

docker compose exec scrum4me-web npx tsx scripts/promote-admin.ts janpeter

Verify

  • npm run verify — lint 0 errors, typecheck clean, 1178/1178 tests passing
  • Local sanity: npm run promote-admin -- ghostuser → "User not found" + exit 2 (geen DATABASE_URL stacktrace)
  • Idempotent: 2x runnen geen error (via Prisma upsert(update:{}))

Review-flow

Gedispatcht via subagent-driven-development:

  1. Implementer (DONE) → commit f09f1bd
  2. Spec compliance review ✅
  3. Code quality review → flagged dotenv-load ontbrak (lokaal broken)
  4. Fix-implementer → commit 8d8bb44 (dotenv + PrismaClient pattern uit create-admin.ts)
  5. Code quality re-review ✅ approved

Deel van M16 platform-split fase 1 — zie docs/plans/M16-platform-split-fase-1-workers-scaffold.md, task 13.

## Summary Kleine PR ter ondersteuning van M16 fase 1 (scrum4me-workers scaffold). Voegt een script toe om een bestaande Scrum4Me-gebruiker te promoveren tot ADMIN via een `UserRole`-upsert. **Geen schema-wijziging** — `Role`-enum + `UserRole`-join bestaan al. ## Changes - `scripts/promote-admin.ts` — idempotent upsert van `UserRole(user_id, role=ADMIN)`. Dotenv-loading + eigen `PrismaClient` (Pool + PrismaPg adapter), matchend met `scripts/create-admin.ts` patroon. DI van prisma in `promoteAdmin(username, prisma)` voor testbaarheid. - `__tests__/scripts/promote-admin.test.ts` — 3 testcases (success, unknown user, idempotent). Geen vi.mock — gebruikt direct injection van fakePrisma. - `package.json` — npm-script `promote-admin` ## Usage Lokaal (na PR-merge): ```bash npm run promote-admin -- janpeter ``` Server (na fase 1 task 18): ```bash docker compose exec scrum4me-web npx tsx scripts/promote-admin.ts janpeter ``` ## Verify - [x] `npm run verify` — lint 0 errors, typecheck clean, 1178/1178 tests passing - [x] Local sanity: `npm run promote-admin -- ghostuser` → "User not found" + exit 2 (geen DATABASE_URL stacktrace) - [x] Idempotent: 2x runnen geen error (via Prisma `upsert(update:{})`) ## Review-flow Gedispatcht via subagent-driven-development: 1. Implementer (DONE) → commit `f09f1bd` 2. Spec compliance review ✅ 3. Code quality review → flagged dotenv-load ontbrak (lokaal broken) 4. Fix-implementer → commit `8d8bb44` (dotenv + PrismaClient pattern uit create-admin.ts) 5. Code quality re-review ✅ approved Deel van M16 platform-split fase 1 — zie [`docs/plans/M16-platform-split-fase-1-workers-scaffold.md`](https://git.jp-visser.nl/janpeter/Scrum4Me/src/branch/main/docs/plans/M16-platform-split-fase-1-workers-scaffold.md), task 13.
fix(promote-admin): load dotenv + own PrismaClient (match create-admin.ts pattern)
Some checks failed
CI / Lint, Typecheck, Test & Build (pull_request) Failing after 1m29s
CI / Deploy Manual (workflow_dispatch) (pull_request) Has been skipped
CI / Detect deploy-relevant changes (pull_request) Has been skipped
CI / Deploy Preview (PR) (pull_request) Has been skipped
CI / Deploy Production (main) (pull_request) Has been skipped
8d8bb44008
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/Scrum4Me!34
No description provided.