feat(M20): plan-review-loop — web-laag (toggles, materialize-fix, UI) + spec/plan #123

Merged
janpeter merged 17 commits from feat/M20-plan-review-loop into main 2026-07-08 06:18:11 +02:00
Owner

Fase 1 van M20 idea-plan-review-loop (spec+plan codex-GO; docs meegecommit).

  • Prisma-migratie add_plan_loop_flags + submodule-bump: Product.auto_plan_review / auto_materialize_plan (default true).
  • lib/idea-status.ts: transitie REVIEWING_PLAN → PLANNING (revisieronde).
  • Gedeelde lib/ideas/materialize-server.ts (materializeIdeaPlan + MaterializeError) — accepteert PLAN_READY én PLAN_REVIEWED (fixt de latente guard/transitie-mismatch); action wordt dunne wrapper.
  • startIdeaJob: IDEA_REVIEW_PLAN enqueuet met runtime=CODEX + required_capability=review.
  • Dedicated job_kind_config-seed-rij IDEA_REVIEW_PLAN (danger-full-access, REVIEW_TOOLS + get_idea_context) + stale-comment-fix.
  • Settings: PlanLoopToggles + updatePlanLoopAction.
  • Realtime idea-store: reviewing_plan / plan_review_failed events.
  • Plan-tab verdict-badge + editable-fix (PLAN_READY/PLAN_REVIEWED/PLAN_REVIEW_FAILED).
  • lib/idea-prompts/: verwijs-headers + pure-review-kopie.

Submodule vendor/scrum4me-shared → M20-tip (shared PR #32, gemerged). verify groen: 1657 tests, 0 errors.

Spec + plan: docs/specs/2026-07-06-idea-plan-review-loop-design.md, docs/plans/M20-idea-plan-review-loop.md.

🤖 Generated with Claude Code

Fase 1 van M20 idea-plan-review-loop (spec+plan codex-GO; docs meegecommit). - Prisma-migratie `add_plan_loop_flags` + submodule-bump: `Product.auto_plan_review` / `auto_materialize_plan` (default true). - `lib/idea-status.ts`: transitie `REVIEWING_PLAN → PLANNING` (revisieronde). - Gedeelde `lib/ideas/materialize-server.ts` (`materializeIdeaPlan` + `MaterializeError`) — accepteert PLAN_READY én PLAN_REVIEWED (fixt de latente guard/transitie-mismatch); action wordt dunne wrapper. - `startIdeaJob`: IDEA_REVIEW_PLAN enqueuet met `runtime=CODEX` + `required_capability=review`. - Dedicated `job_kind_config`-seed-rij IDEA_REVIEW_PLAN (danger-full-access, REVIEW_TOOLS + get_idea_context) + stale-comment-fix. - Settings: `PlanLoopToggles` + `updatePlanLoopAction`. - Realtime `idea-store`: reviewing_plan / plan_review_failed events. - Plan-tab verdict-badge + editable-fix (PLAN_READY/PLAN_REVIEWED/PLAN_REVIEW_FAILED). - `lib/idea-prompts/`: verwijs-headers + pure-review-kopie. Submodule vendor/scrum4me-shared → M20-tip (shared PR #32, gemerged). verify groen: 1657 tests, 0 errors. Spec + plan: docs/specs/2026-07-06-idea-plan-review-loop-design.md, docs/plans/M20-idea-plan-review-loop.md. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Brainstorm-output 2026-07-06: automatische plan-review-keten op de
ClaudeJob-queue (codex-container als reviewer, runtime=CODEX), onbegrensde
revisierondes tot APPROVED/REJECTED, auto-materialisatie + hardstop,
twee product-toggles default aan.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
F1 gedeelde materialize-helper (fix PLAN_REVIEWED-guard-mismatch),
F2 runtime=CODEX als enqueue-contract + job_kind_config-seed (geen shared),
F3 revisie-context claim-time via created_by_job_id (geen payload-veld),
F4 row-lock + kind-gescopete guard + orchestration_key-idempotentie,
F5 pure-review-semantiek + dual-write plan_review_log/ReviewLog,
F6 expliciet geen migration-time backfill.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sandbox-hardstop: codex_sandbox_mode danger-full-access (fase-4 gate),
read-intentie via REVIEW_TOOLS-allowlist; required_capability='review'
conform phase-4 auto-dispatch-patroon.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4 fases (shared-kolommen, web-laag, mcp-keten, rollout+E2E), TDD per taak,
ronde-semantiek + loop-lib, 2 spec-delta's uit verkenning gedocumenteerd.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Taakvolgorde 2.4↔2.5 (materialize vóór verdict-keten), notify-signatuur,
toggle-uit = geen auto-revisie, idempotente side-effects bij dubbele
submit_review, CODEX-prompt-call-site, DONE-fallback in dual-write;
pushback op idea_id-kolom (bestaat niet op ReviewLog).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
opts.kind-fix, job-select-contract (runtime/orchestration_key), atomaire
verdict-transactie met in-tx idempotentie-guard + retry-test, idea_id in
beide ReviewLog-writes (r2-pushback teruggedraaid: web-schema heeft de
kolom, mcp-checkout was stale), summary-loze update_job_status in prompt;
pushback gehandhaafd op finding 6 (geen dubbele property).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bump vendor/scrum4me-shared naar M20-tip (db335da): Product-kolommen
auto_plan_review + auto_materialize_plan (default true). Migration
add_plan_loop_flags; géén backfill (spec v3).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Extraheer materialisatie-logica uit actions/ideas.ts naar
lib/ideas/materialize-server.ts (materializeIdeaPlan + MaterializeError).
Accepteert PLAN_READY én PLAN_REVIEWED via canTransition — fixt de latente
guard/transitie-tabel-mismatch. Action wordt dunne wrapper (auth/demo/
rate-limit + error-mapping + revalidate). Bewust gedupliceerd naar mcp (2.4).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Verdict-pill (laatste review + rondeteller) boven de ReviewLogViewer;
plan-tab editable in PLAN_READY/PLAN_REVIEWED/PLAN_REVIEW_FAILED via
isPlanMdEditableApi; mobile materialize-gate accepteert ook PLAN_REVIEWED.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
docs(idea-prompts): verwijs-headers + pure-review-kopie (M20)
All checks were successful
CI / Lint, Typecheck, Test & Build (pull_request) Successful in 4m18s
CI / Deploy Manual (workflow_dispatch) (pull_request) Has been skipped
CI / Detect deploy-relevant changes (pull_request) Has been skipped
CI / Deploy Preview (PR) (pull_request) Has been skipped
CI / Deploy Production (main) (pull_request) Has been skipped
b40431d43d
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
s4m-codex-reviewer left a comment

Verdict: APPROVED

Geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden.

Findings

  • Geen blokkerende of noemenswaardige findings.

Review-notities

  • De wijzigingen volgen de M20 plan-review-loop spec voor de weblaag: product-toggles met default-aan migratie, IDEA_REVIEW_PLAN enqueue met runtime=CODEX + required_capability=review, pure-review job-kind config, REVIEWING_PLAN → PLANNING, en materialisatie vanuit PLAN_READY | PLAN_REVIEWED.
  • De nieuwe updatePlanLoopAction volgt hetzelfde owner-only patroon als de bestaande automation settings-actions en behoudt de demo-user guard.
  • Tests zijn toegevoegd voor de nieuwe action, toggles, statusovergang, seed-config, store-statusmapping en materialisatie vanuit PLAN_REVIEWED.
# Verdict: APPROVED Geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden. ## Findings - Geen blokkerende of noemenswaardige findings. ## Review-notities - De wijzigingen volgen de M20 plan-review-loop spec voor de weblaag: product-toggles met default-aan migratie, `IDEA_REVIEW_PLAN` enqueue met `runtime=CODEX` + `required_capability=review`, pure-review job-kind config, `REVIEWING_PLAN → PLANNING`, en materialisatie vanuit `PLAN_READY | PLAN_REVIEWED`. - De nieuwe `updatePlanLoopAction` volgt hetzelfde owner-only patroon als de bestaande automation settings-actions en behoudt de demo-user guard. - Tests zijn toegevoegd voor de nieuwe action, toggles, statusovergang, seed-config, store-statusmapping en materialisatie vanuit `PLAN_REVIEWED`.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/Scrum4Me!123
No description provided.