janpeter/Ops-dashboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(ops-agent): redeploy_all fetches scrum4me-mcp instead of pulling it #91

Merged
janpeter merged 1 commit from fix/redeploy-all-mcp-fetch into main 2026-07-04 11:07:03 +02:00
Conversation 0 Commits 1 Files changed 2 +28 -4
janpeter commented 2026-07-04 11:02:25 +02:00
Owner
Copy link

Waarom

redeploy_all crashte op step 14/31 met precondition 'git_status_clean' failed: working tree is not clean.

Die stap deed git_pull op de lokale scrum4me-mcp-clone. Die clone draagt permanent een benigne M vendor/scrum4me-shared submodule-drift (host-MCP build-state). git_pull's git_status_clean-precondition draait vóór on_failure: continue, dus de hele flow aborteerde — ondanks on_failure: continue.

Fix

Stap → git_fetch (raakt de working tree niet → geen abort). Dit is exact het patroon dat update_mcp_worker.yml en update_codex_worker.yml al bewust gebruiken (met dezelfde documentatie). De worker-image cloont scrum4me-mcp sowieso vers via MCP_CACHE_BUST, dus de lokale pull voegde niets toe.

Toegepast op beide baseline-kopieën (deploy/ops-agent/flows + deploy/ops-agent/baseline/flows).

Deploy-status

  • Live /etc/ops-agent/flows/redeploy_all.yml — al gesynct (out-of-band).
  • Drift-runtime baseline (/srv/scrum4me/ops-agent-drift/baseline) — al gesynct; check-ops-agent-drift.sh = no drift (exit 0).
  • ops-agent herstart, actief.

Deze PR brengt de version-controlled baseline gelijk zodat een re-install de bug niet herintroduceert.

🤖 Generated with Claude Code

## Waarom `redeploy_all` crashte op **step 14/31** met `precondition 'git_status_clean' failed: working tree is not clean`. Die stap deed `git_pull` op de lokale `scrum4me-mcp`-clone. Die clone draagt **permanent** een benigne ` M vendor/scrum4me-shared` submodule-drift (host-MCP build-state). `git_pull`'s `git_status_clean`-precondition draait **vóór** `on_failure: continue`, dus de hele flow aborteerde — ondanks `on_failure: continue`. ## Fix Stap → `git_fetch` (raakt de working tree niet → geen abort). Dit is exact het patroon dat `update_mcp_worker.yml` en `update_codex_worker.yml` al bewust gebruiken (met dezelfde documentatie). De worker-image cloont `scrum4me-mcp` sowieso vers via `MCP_CACHE_BUST`, dus de lokale pull voegde niets toe. Toegepast op beide baseline-kopieën (`deploy/ops-agent/flows` + `deploy/ops-agent/baseline/flows`). ## Deploy-status - Live `/etc/ops-agent/flows/redeploy_all.yml` — al gesynct (out-of-band). - Drift-runtime baseline (`/srv/scrum4me/ops-agent-drift/baseline`) — al gesynct; `check-ops-agent-drift.sh` = **no drift** (exit 0). - ops-agent herstart, actief. Deze PR brengt de version-controlled baseline gelijk zodat een re-install de bug niet herintroduceert. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Step 14 of redeploy_all git_pull'd the /srv/scrum4me/repos/scrum4me-mcp
clone. That clone permanently carries a benign ` M vendor/scrum4me-shared`
submodule drift (host-MCP build-state), and git_pull's git_status_clean
precondition runs *before* on_failure: continue is evaluated, so the whole
flow aborted with "working tree is not clean".

Switch that step to git_fetch, matching the already-correct
update_mcp_worker.yml and update_codex_worker.yml: the worker image clones
scrum4me-mcp fresh via MCP_CACHE_BUST during the build, so the local pull
added nothing anyway. fetch touches no working tree -> no abort.

Applied to both baseline copies (deploy/ops-agent/flows + baseline/flows).
Live /etc/ops-agent + the drift-runtime baseline were synced out-of-band;
drift check is green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/Ops-dashboard!91
No description provided.