feat(mac-option-c): deploy-gate accepteert een identieke, groene PR-head #268

Merged

janpeter merged 1 commit from feat/deploy-gate-pr-head into main 2026-09-28 19:04:09 +02:00

Conversation 1 Commits 1 Files changed 3 +111 -14

janpeter commented 2026-09-28 18:16:54 +02:00

Owner

Copy link

Lever 1 from the CI investigation (JP, 2026-09-28): merge → deployable goes from ~30 min to ~5 min (only build).

The deploy gate (build) required green Required checks on the merge commit itself, and that means waiting for its main run: 10–18 min on two runners. It now also accepts a merge commit when all of the following hold:

• the main run has no verdict yet (pending or none);
• the merge commit's tree is byte-identical to its PR head (second parent);
• that PR head has all Required checks green.

That is exactly the content CI tested. A red main run is never overruled. If main moved in between, the trees differ and the gate waits as before.

Checked against the real #267 merge: 3ee73cf1 has a tree identical to PR head 57fd725f, which has CI / Required checks (pull_request): success.

Tests: identical tree + green head (no status and pending), red main, a non-green head, and diverged trees. 20/20 deploy tests pass.

🤖 Generated with Claude Code

Lever 1 from the CI investigation (JP, 2026-09-28): merge → deployable goes from ~30 min to ~5 min (only `build`). The deploy gate (`build`) required green Required checks on the merge commit itself, and that means waiting for its main run: 10–18 min on two runners. It now also accepts a merge commit when all of the following hold: - the main run has no verdict yet (pending or none); - the merge commit's tree is byte-identical to its PR head (second parent); - that PR head has all Required checks green. That is exactly the content CI tested. A red main run is never overruled. If main moved in between, the trees differ and the gate waits as before. Checked against the real #267 merge: `3ee73cf1` has a tree identical to PR head `57fd725f`, which has `CI / Required checks (pull_request): success`. Tests: identical tree + green head (no status and pending), red main, a non-green head, and diverged trees. 20/20 deploy tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

janpeter added 1 commit 2026-09-28 18:16:54 +02:00

feat(mac-option-c): deploy-gate accepteert een identieke, groene PR-head zolang main CI nog loopt ... 4664d0b809

Een merge-commit wacht niet meer 10-18 min op zijn eigen main run als zijn
tree byte-gelijk is aan de PR-head en die groene Required checks heeft. Een
rode main run wordt nooit overruled; verschillen de trees, dan blijft
wachten de regel. Tests voor gelijk/afwijkend, rood en niet-groen.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

s4m-codex-reviewer approved these changes 2026-09-28 18:21:43 +02:00

s4m-codex-reviewer left a comment

Copy link

Verdict: APPROVED

Geen blokkerende bevindingen.

• INFO — deploy/mac-production/deploy-ops-release.sh:96: de gate behandelt de eigen main-status expliciet (groen, rood, pending/geen status) en accepteert de PR-head-route alleen voor een echte tweeouder-merge met een identieke tree en een groene Required-check.
• INFO — test/mac-option-c-deploy.test.ts:283: de contracttests dekken de toegestane identieke merge en de relevante weigeringen af: rode main-run, niet-groene PR-head en afwijkende tree wanneer main voortbewoog.
• INFO — deploy/mac-production/README.md:95: de gewijzigde operationele semantiek is gedocumenteerd.

Geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden.

Verificatie: bash -n deploy/mac-production/deploy-ops-release.sh en git diff --check zijn geslaagd. De gerichte Vitest-run kon lokaal niet opstarten doordat de native rolldown-binding in deze runtime niet gemapt mag worden.

# Verdict: APPROVED Geen blokkerende bevindingen. - INFO — `deploy/mac-production/deploy-ops-release.sh:96`: de gate behandelt de eigen main-status expliciet (groen, rood, pending/geen status) en accepteert de PR-head-route alleen voor een echte tweeouder-merge met een identieke tree en een groene Required-check. - INFO — `test/mac-option-c-deploy.test.ts:283`: de contracttests dekken de toegestane identieke merge en de relevante weigeringen af: rode main-run, niet-groene PR-head en afwijkende tree wanneer main voortbewoog. - INFO — `deploy/mac-production/README.md:95`: de gewijzigde operationele semantiek is gedocumenteerd. Geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden. Verificatie: `bash -n deploy/mac-production/deploy-ops-release.sh` en `git diff --check` zijn geslaagd. De gerichte Vitest-run kon lokaal niet opstarten doordat de native rolldown-binding in deze runtime niet gemapt mag worden.

janpeter merged commit bfc34635aa into main 2026-09-28 19:04:09 +02:00

janpeter referenced this pull request from a commit 2026-09-28 19:04:09 +02:00

Merge pull request 'feat(mac-option-c): deploy-gate accepteert een identieke, groene PR-head' (#268) from feat/deploy-gate-pr-head into main

janpeter referenced this pull request from a commit 2026-09-29 07:43:49 +02:00

docs(audit): deploy-gate accepteert identieke groene PR-head (PR #268)

Sign in to join this conversation.

Reviewers

No reviewers

s4m-codex-reviewer

Labels

Clear labels   

severity/s2

  

severity/s3

No labels

severity/s2

severity/s3

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

janpeter/Ops-dashboard!268

No description provided.