janpeter/Ops-dashboard
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

fix(mac-option-c): install maakt de config-map aan op een schone Mac #265

Merged
janpeter merged 1 commit from fix/deploy-config-dir into main 2026-09-28 16:19:28 +02:00
Conversation 1 Commits 1 Files changed 1 +2
janpeter commented 2026-09-28 15:59:04 +02:00
Owner
Copy link

Follow-up to codex review 828 on #264. install_config now creates /opt/jpvisser/config (root:_jpops 0750) before it places the whitelist, so a first install on a clean Mac does not stop before the switch. On mac-prod that directory already exists.

🤖 Generated with Claude Code

Follow-up to codex review 828 on #264. `install_config` now creates `/opt/jpvisser/config` (root:_jpops 0750) before it places the whitelist, so a first install on a clean Mac does not stop before the switch. On mac-prod that directory already exists. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(mac-option-c): install maakt de config-map aan op een schone Mac (review 828)
All checks were successful
CI / Select checks (pull_request) Successful in 13s
Details
CI / Ops-agent checks (pull_request) Successful in 40s
Details
CI / DB access operator (pull_request) Successful in 1m23s
Details
CI / Deploy artifact checks (pull_request) Successful in 41s
Details
CI / Docker image build (pull_request) Successful in 1m22s
Details
CI / Mac foundation hermetic checks (pull_request) Successful in 2m12s
Details
CI / Root app checks (pull_request) Successful in 7m56s
Details
CI / Mac foundation reproducible build (pull_request) Successful in 4m21s
Details
CI / Publish post-merge release evidence (pull_request) Has been skipped
Details
CI / Required checks (pull_request) Successful in 38s
Details
e972b42325 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
s4m-codex-reviewer approved these changes 2026-09-28 16:01:39 +02:00
s4m-codex-reviewer left a comment
Copy link

Verdict: APPROVED

Findings

  • Geen blocking findings.

Geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden.

De wijziging creëert op een schone Mac vóór de eerste configuratie-installatie de ontbrekende configuratiemap met het bestaande eigenaar-, groep- en permissiecontract (root:_jpops, 0750).

## Verdict: APPROVED ### Findings - Geen blocking findings. Geen gekoppeld plan gevonden — beoordeeld op codekwaliteit + product-standaarden. De wijziging creëert op een schone Mac vóór de eerste configuratie-installatie de ontbrekende configuratiemap met het bestaande eigenaar-, groep- en permissiecontract (`root:_jpops`, `0750`).
Sign in to join this conversation.
Reviewers
No reviewers
s4m-codex-reviewer
Labels
Clear labels   
severity/s2

   
severity/s3
No labels
severity/s2
severity/s3
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/Ops-dashboard!265
No description provided.