[codex] fix library link buttons #58

Merged

janpeter merged 1 commit from codex/library-button-native-button-fix into main

2026-07-06 17:20:22 +02:00

janpeter commented

2026-07-06 17:09:39 +02:00

Owner

Summary

Fix the shared Button wrapper so link-rendered buttons opt out of native button semantics.
Add a regression test covering a Button rendered as a link, matching the Library slideshow controls.

Root Cause

Base UI Button defaults nativeButton to true. The Library Imports slideshow control renders the shared Button as a link, so Base UI logged a runtime error when visiting /library/library-imports.

Validation

npm test -> 294 tests passed
npm run build -> blocked locally because vendor/scrum4me-copilot is an uninitialized submodule and this environment cannot clone it: the configured Git credential helper osxkeychain is unavailable. Without that submodule, Next cannot resolve @s4m-kit/index from existing main-branch S4M files.

## Summary - Fix the shared Button wrapper so link-rendered buttons opt out of native button semantics. - Add a regression test covering a Button rendered as a link, matching the Library slideshow controls. ## Root Cause Base UI Button defaults `nativeButton` to `true`. The Library Imports slideshow control renders the shared `Button` as a link, so Base UI logged a runtime error when visiting `/library/library-imports`. ## Validation - `npm test` -> 294 tests passed - `npm run build` -> blocked locally because `vendor/scrum4me-copilot` is an uninitialized submodule and this environment cannot clone it: the configured Git credential helper `osxkeychain` is unavailable. Without that submodule, Next cannot resolve `@s4m-kit/index` from existing main-branch S4M files.

janpeter added 1 commit

2026-07-06 17:09:39 +02:00