chore(tests): remove orphaned scanner-era test suite #42

Merged

janpeter merged 1 commit from chore/remove-stale-scanner-tests into main 2026-06-06 01:52:16 +02:00

Conversation 0 Commits 1 Files changed 41 +11 -7819

janpeter commented 2026-06-06 01:28:49 +02:00

Owner

Copy link

Follow-up to the library rebuild + Immich reapply. The rebuild replaced the scanner app (root lib//app/ layout, Vitest + Playwright + Testing Library) with the current library app (src/ layout, node:test) but left the whole tests/ tree behind.

Every tests/** file imports deleted root-level modules (lib/domain/scan-safety, lib/config, app/manifest, …) or uses Vitest APIs the app no longer runs (vi.queueMock), so all 27 loadable files fail with ERR_MODULE_NOT_FOUND; the tests/ui/*.tsx + tests/e2e specs aren't even executed by tsx --test.

Removed: the tests/ dir (37 files), the orphaned vitest.config.ts + playwright.config.ts, and the now-unused devDeps @playwright/test, @testing-library/jest-dom, @testing-library/react, vitest. Verified nothing in src/ imports them — all 38 current tests use node:test.

Result: npm test goes from 112/36 (or 129/35 with the prisma client generated) to 129 pass / 8 fail with zero module-not-found noise. The remaining 8 failures are pre-existing integration tests (library-import / slideshow / storage-paste) that need a live DATABASE_URL — untouched by this PR; they pass against the media-organizer Postgres. Lint unchanged; CI docker build unchanged (still green).

Heads-up (separate, optional): CI (.forgejo/workflows/ci.yml) only runs docker build — it does not run npm test, which is why the earlier RSC bug (#41) and these stale tests slipped through. If you want, a follow-up can add a test job with a Postgres service container so npm test (incl. the 8 integration tests) gates PRs.

Follow-up to the library rebuild + Immich reapply. The rebuild replaced the **scanner app** (root `lib/`/`app/` layout, Vitest + Playwright + Testing Library) with the current **library app** (`src/` layout, `node:test`) but left the whole `tests/` tree behind. Every `tests/**` file imports deleted root-level modules (`lib/domain/scan-safety`, `lib/config`, `app/manifest`, …) or uses Vitest APIs the app no longer runs (`vi.queueMock`), so all 27 loadable files fail with `ERR_MODULE_NOT_FOUND`; the `tests/ui/*.tsx` + `tests/e2e` specs aren't even executed by `tsx --test`. **Removed:** the `tests/` dir (37 files), the orphaned `vitest.config.ts` + `playwright.config.ts`, and the now-unused devDeps `@playwright/test`, `@testing-library/jest-dom`, `@testing-library/react`, `vitest`. Verified nothing in `src/` imports them — all 38 current tests use `node:test`. **Result:** `npm test` goes from 112/36 (or 129/35 with the prisma client generated) to **129 pass / 8 fail** with **zero** module-not-found noise. The remaining 8 failures are pre-existing **integration** tests (library-import / slideshow / storage-paste) that need a live `DATABASE_URL` — untouched by this PR; they pass against the media-organizer Postgres. Lint unchanged; CI `docker build` unchanged (still green). **Heads-up (separate, optional):** CI (`.forgejo/workflows/ci.yml`) only runs `docker build` — it does **not** run `npm test`, which is why the earlier RSC bug (#41) and these stale tests slipped through. If you want, a follow-up can add a test job with a Postgres service container so `npm test` (incl. the 8 integration tests) gates PRs.

janpeter added 1 commit 2026-06-06 01:28:49 +02:00

chore(tests): remove orphaned scanner-era test suite ... 697f10d335

The library rebuild replaced the scanner app (root lib//app/ layout, Vitest +
Playwright + Testing Library) with the current library app (src/ layout,
node:test) but left the entire tests/ tree behind. Every tests/** file imports
deleted root-level modules (e.g. lib/domain/scan-safety, lib/config,
app/manifest) or uses Vitest APIs the app no longer runs, so they all fail to
load; the tests/ui/*.tsx + tests/e2e specs aren't even executed.

Remove tests/, the orphaned vitest.config.ts + playwright.config.ts, and the
now-unused devDeps (@playwright/test, @testing-library/jest-dom,
@testing-library/react, vitest). Nothing in src/ references them; all 38
current tests use node:test.

npm test now: 129 pass / 8 fail, where the 8 are pre-existing library-import &
slideshow integration tests that need a live DATABASE_URL (untouched here) —
no more module-not-found noise. CI docker-build and lint unchanged.

janpeter merged commit a3b6d15d98 into main 2026-06-06 01:52:16 +02:00

janpeter referenced this pull request from a commit 2026-06-06 01:52:17 +02:00

Merge pull request 'chore(tests): remove orphaned scanner-era test suite' (#42) from chore/remove-stale-scanner-tests into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

janpeter/Media-Organizer!42

No description provided.