feat(usage): dispatch-reviews per idee en fase, jobtabel in de idee-focus (IDEA-251, T-254) #163
No reviewers
Labels
No labels
severity/s2
severity/s3
severity/s4
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
janpeter/scrum4me-workers!163
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "claude/idea-251-usage-jobs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
IDEA-251, task T-254 (sprint S-2026-10-12-4, story ST-078). Plan:
docs/superpowers/plans/2026-10-12-idea-251-dispatch-idea-work-item.md(branchclaude/idea-251-spec), section T4.What changes
usageFactsCtejob branch:LEFT JOIN dispatch_idea_links dil ON dil.request_id = cj.dispatch_request_id.dil.idea_id,dil.idea_phase).cj.idea_idandkindstay as they are.job_id,job_kind,job_status; the session branch selects NULL for them.PHASE_RULES: job rulesGRILL/SPEC/PLAN/CEREMONY.phaseCaseSqlitself is unchanged.fetchIdeaJobs: one row per job, newest first, max 200.totalcomes fromcount(*) OVER (), so it counts before the LIMIT. It uses the same attribution and phase as pie 2.IdeaJobsTable: columns date/time (Amsterdam), phase, kind, model with runtime dot, status, tokens, USD ("—" when there is no price). Shows "200 van N getoond" whentotalexceeds 200. Vis tokens only.scrum4me-shared→f1e78df(S1).Deviation from the plan, with reason
queue_dispatch_requests,queue_dispatch_candidatesandqueue_dispatch_profilescarryqueue_dispatch_guard_immutable, which raisesDISPATCH_IMMUTABLEon every DELETE, for every user. The job guard also refuses an admin delete of a bound job (DISPATCH_MANAGED_ROW).SET LOCAL session_replication_role = replica. Afterwards it asserts that no prefixed or orphaned dispatch rows remain, because replica mode also skips the FK checks.scrum4me_dispatchviaSET LOCAL ROLE.seg-e(sprint overhead) violated the realusage_segments_scope_check: a sprint requires ananchor_task_id. The earlier Prisma-derived schema had no such CHECK. It now gets an anchor, andtask_idstays NULL, so it still counts as overhead.Verification
npm run verify: green. 211 files passed and 4 skipped; 2733 tests passed and 56 skipped. One lint warning, already present, incomponents/jobs/job-card.tsx.USAGE_TEST_DATABASE_URL=… npx vitest run __tests__/lib/usage/scrum/queries-realdb.test.tsgives 13/13 green, twice in a row (it can be re-run). It ran against a disposable Postgres 17.9s4m_dispatch_test, provisioned from the T2 web branch (test-db.mjs provision --stage chain, which includesdispatch_idea_links). Covered:plan, B/SPEC on an idea with a build sprint →spec(Review Focus 4), unlinked IDEA_GRILL →grill;rgonidea-jobs-table.tsx: exit 1 (nothing found).Deploy conditions (not part of this PR)
usageFactsCte, so every Scrum Usage query fails without the table.claude_jobs(scrum4me_web_runtime,scrum4me_app,ops_readonly) also have SELECT ondispatch_idea_links. Before deploy, check which role production workers uses forDATABASE_URL, and confirm that role hashas_table_privilege(…, 'dispatch_idea_links', 'SELECT').🤖 Generated with Claude Code
APPROVED
Beoordeeld op commit
6335609eb544dca2d58934b6e2df02c73212bd57.Findings
Plan en productafspraken
plan gekoppeld via pr_refs; references:
T-254,ST-078. Geen onderdelen omitted.De diff rondt het Workers-deel T-254 af conform het plan en IDEA-251-specificatie §6: idee en fase komen samen uit de dispatch-koppeling, de PK-join behoudt één feit per job, de jobtabel gebruikt dezelfde toerekening en prijsberekening als de taart, en toont maximaal 200 rijen met het volledige aantal. Bestaande read-only snapshots, tabelprimitive en Vis-tokens worden hergebruikt. MANUAL
page-usage-scrumis bijgewerkt.De afwijkende testopruiming met
SET LOCAL session_replication_role = replicais verklaard door de immutable dispatch-guards en wordt gevolgd door controles op achtergebleven rijen. De shared-bump bevat uitsluitend de bedoelde schema-uitbreiding; de overige wijzigingen betreffen de bestaande ST-074-prijshelperopruiming. Geen conflicten met de gebruikte helpers gevonden.Andere onderdelen van ST-078, de productieproef en de browsercontrole op 375px vallen buiten deze PR en blijven bij T-256. De beschreven voorwaarde voor deploy — migratie en db-access apply/check plus SELECT voor de Workers-databaserol — volgt de productspecificatie.
Verificatie
npm run verify, exit 0; 211 testbestanden en 2733 tests geslaagd, 4 bestanden en 56 tests overgeslagen. Eén bestaande lintwaarschuwing incomponents/jobs/job-card.tsx.queries-realdb.test.ts, 13/13 geslaagd op een exclusieve lokale PostgreSQL 17.11-wegwerpcluster, geprovisiond vanuit de web-migratieketen inclusief additieve contracten en echte dispatch-guards. Dit bewijst onder meer fase-toerekening en Σ jobtabel = Σ job-only-taart voor tokens en USD.