scrum4me-mcp/__tests__
Madhura68 0a18f565d2 fix(update_job_status): gebruik DB-branch ipv legacy feat/job-<8> fallback
Symptoom: TASK_IMPLEMENTATION job T-806 in een SPRINT-strategy sprint
faalde met:

  push failed (unknown): error: src refspec feat/job-us3aqoup does not
  match any
  error: failed to push some refs to 'https://github.com/.../Scrum4Me.git'

Maar de PR was wel succesvol aangemaakt door Claude (PR #174 op
feat/sprint-fvy30lvv) — Claude commit'te in de juiste worktree-branch,
maar update_job_status's prepareDoneUpdate probeerde te pushen op een
niet-bestaande branch.

Root cause: prepareDoneUpdate(jobId, branch) accepteert een branch-arg
(meestal undefined want Claude geeft 'm niet mee) en valt terug op
`feat/job-${jobId.slice(-8)}`. Dat is het legacy pre-PBI-50 pad — voor
sprint-jobs is de werkelijke branch `feat/sprint-<id>` (PR_strategy=SPRINT)
of `feat/story-<id>` (STORY), opgeslagen in ClaudeJob.branch door
attachWorktreeToJob.

Fix:
- prepareDoneUpdate leest nu eerst ClaudeJob.branch uit de DB als de
  expliciete branch-arg ontbreekt.
- Pas daarna fallback op `feat/job-<8>` (zou niet moeten voorkomen na PBI-50).

Tests: vi.mock('../src/prisma.js') toegevoegd voor de findUnique-stub.
Bestaande test "derives branchName from jobId when branch is undefined"
hernoemd naar "reads branchName from DB" met DB-mock returnt
'feat/sprint-fvy30lvv'. Plus extra test voor de legacy fallback wanneer
DB.branch ook null is.

341 tests in 38 files passed (was 340, +1).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-09 13:53:43 +02:00
..
flow PBI-9 + PBI-47: worktree foundation, product-worktrees, P0 fixes, PAUSED flow 2026-05-06 21:09:48 +02:00
git PBI-49: review-fixes — primary_worktree order, idea-claim rollback, sprint mark-ready fallback 2026-05-07 11:02:23 +02:00
scripts feat: per-job token-usage capture via PostToolUse hook 2026-05-06 07:53:36 +02:00
verify PBI-9 + PBI-47: worktree foundation, product-worktrees, P0 fixes, PAUSED flow 2026-05-06 21:09:48 +02:00
cancel-pbi-cascade.test.ts PBI-57: 'skipped' no-op exit + cascade preserves original error 2026-05-07 17:10:02 +02:00
check-queue-empty.test.ts feat: add check_queue_empty tool (v0.3.0) 2026-05-03 17:57:17 +02:00
cleanup-my-worktrees.test.ts PBI-9 + PBI-47: worktree foundation, product-worktrees, P0 fixes, PAUSED flow 2026-05-06 21:09:48 +02:00
get-claude-context-filter.test.ts PBI-8: Sprint-flow MCP-orkestratie + verifier-fix 2026-05-06 16:59:58 +02:00
job-config.test.ts fix(KIND_DEFAULTS): permission_mode acceptEdits voor idea-kinds + PLAN_CHAT 2026-05-09 11:28:31 +02:00
job-heartbeat.test.ts PBI-50 F5: tests voor SPRINT_IMPLEMENTATION-tools 2026-05-07 12:53:04 +02:00
kind-prompts.test.ts fix(prompts): idea-prompts gebruiken $PAYLOAD_PATH ipv onvervangen placeholders 2026-05-09 11:55:27 +02:00
mark-pbi-pr-merged.test.ts feat(mcp): set_pbi_pr + mark_pbi_pr_merged tools voor PBI-PR-gating (#18) 2026-05-03 16:25:53 +02:00
set-pbi-pr.test.ts feat(mcp): set_pbi_pr + mark_pbi_pr_merged tools voor PBI-PR-gating (#18) 2026-05-03 16:25:53 +02:00
tasks-status-update.test.ts PBI-8: Sprint-flow MCP-orkestratie + verifier-fix 2026-05-06 16:59:58 +02:00
update-job-status-auto-pr.test.ts PBI-8 (vervolg): Sprint-aware branch + SPRINT-mode draft-PR 2026-05-06 17:15:04 +02:00
update-job-status-gate.test.ts feat(gate): verify_required levels — ALIGNED/ALIGNED_OR_PARTIAL/ANY (#16) 2026-05-02 17:55:06 +02:00
update-job-status-next-action.test.ts feat: worker presence layer + batch-loop docs (#7) 2026-05-01 16:39:26 +02:00
update-job-status-push.test.ts fix(update_job_status): gebruik DB-branch ipv legacy feat/job-<8> fallback 2026-05-09 13:53:43 +02:00
update-job-status-skipped.test.ts PBI-57: 'skipped' no-op exit + cascade preserves original error 2026-05-07 17:10:02 +02:00
update-job-status-sprint-gate.test.ts PBI-50 F5: tests voor SPRINT_IMPLEMENTATION-tools 2026-05-07 12:53:04 +02:00
update-job-status-worktree.test.ts feat: branch-per-story + worktree-defer + verify EMPTY edge-cases (#12) 2026-05-01 17:04:54 +02:00
update-task-execution.test.ts PBI-50 F5: tests voor SPRINT_IMPLEMENTATION-tools 2026-05-07 12:53:04 +02:00
verify-plan.test.ts test+docs: verify-plan tests and README for verify_task_against_plan 2026-04-30 19:36:43 +02:00
verify-sprint-task.test.ts PBI-50 F5: tests voor SPRINT_IMPLEMENTATION-tools 2026-05-07 12:53:04 +02:00
verify-task-against-plan.test.ts feat: verify_task_against_plan calls classifyDiffAgainstPlan + saves verify_result to DB 2026-05-01 12:59:17 +02:00
wait-for-job-branch-resolution.test.ts PBI-8 (vervolg): Sprint-aware branch + SPRINT-mode draft-PR 2026-05-06 17:15:04 +02:00
wait-for-job-snapshot.test.ts feat(M13): retry-tracking — stale CLAIMED jobs → QUEUED (retry_count++) or FAILED (≥2 retries) 2026-05-01 13:18:59 +02:00
wait-for-job-worktree.test.ts PBI-8 (vervolg): Sprint-aware branch + SPRINT-mode draft-PR 2026-05-06 17:15:04 +02:00