[ISS-16] AGENT_CHAT-claim negeert de productbeperking van het token; de chat faalt pas vaag bij de eerste tool #213
Closed
opened 2026-10-11 10:22:26 +02:00 by janpeter
·
0 comments
No Branch/Tag specified
main
docs-audit/cmvetfb0f02jeow7rqkkrbpdb
fix/iss-7-plan-paths
fix/iss-6-harness-worktree-cleanup
docs-audit/cmvbyjfqk02ousy7rh1d5swaf
claude/idee-attach-modus
fix/dispatch-submit-404-hint
docs-audit/cmv93nqxf00slem7rg9hp5u0f
claude/iss-17-idea-link
docs-audit/cmv7o7wa000pam97reoqhcmdj
feat/idea-249-record-issue-scope
feat/idea-249-issue-phase
docs-audit/cmv68rygv00hqin7rpw9niqmt
claude/idea-251-idea-link
claude/st074-estimate-history-list-price
fix/iss-16-agent-chat-token-scope
docs-audit/cmv3dwg1k004hz07rqzwdlley
feat/m50-1a-agent-chat
feat/iss-9-close-task-stops
fix/iss-2-claim-bound-stop
plan/iss-2-cancel-unstarted
feat/idea-243-job-notify
feat/m45-3-local-llm-opruimen
fix/iss58-drop-mcp-drain-stamp
fix/iss15-review-static-no-registry
docs-audit/cmv0j0o6t0069oc7rfn6op51p
fix/iss1-verify-default-branch
docs-audit/cmuz3ktfm019yo07rwodthg4m
feat/m45-2b-harness
codex/ppe-task-status
docs-audit/cmuw8ozn900l5z87rlpf2mx7b
fix/iss12-signed-off-unstarted
docs-audit/cmuut96fv011yhb7rskn61ft0
fix/iss-11-bootstrap-nullable-rebind
test/t1972-recovery-http
feat/t1972-recovery-usage
feat/t1972-dispatch-usage
docs-audit/cmurydk3j00a9747r68iqqa1h
feat/m41-reply-addresses-list
feat/m41-reviewer-kind
feat/m41-review-contract
fix/stdio-canary-test-timeout
docs/agent-guide-startflow
feat/notes-tools-pbi30
docs-audit/cmukt69k3003zk47roinpfpfw
feat/m3-local-llm-task-jobs
fix/packaged-release-test-timeout
fix/api-token-expiry
fix/wait-for-job-listener-leak
docs-audit/cmuhyah5f003wmt7rg70umy5b
feat/m2-local-llm-claim
fix/listen-client-error-handler
fix/iss-1-repair-script-scope
fix/ci-refuse-stale-pr-head
fix/ci-postgres-port-conflict
fix/story-rollup-excluded
fix/mcp-dispatch-list-timeout
feat/idea-213-dispatch
fix/compare-diff-authenticated
feat/m39-mcp-db-aware-snapshot
feat/m39-mcp-shared-shim
fix/iss-3-default-branch
feat/werkbackup-m38
claude/blissful-heisenberg-70a6d6
codex/idea-169-forgejo-ci-host-mcp
codex/idea-169-runtime-rebaseline-mcp
codex/fix-verify-diff-maxbuffer
codex/idea-187-companion-secret-hotfix
feat/sprint-06zbas3p
feat/queue-work-item-ids
feat/agent-guide-issues
feat/issue-tracker
fix/db-label-instance-fallback
fix/db-application-name
feat/m32-archivering
feat/m30-p0.4-pin-bump
feat/product-doc-cap-250k
claude/jolly-jemison-74bdd1
docs/rules-file-revisie3
feat/queue-vocab-parity
feat/queue-kimi-enums
docs/rules-codex-bestemming
docs/rules-file-actief
docs/testing-typecheck-scope
fix/integration-tests-serieel
claude/awesome-rosalind-7b450b
fix/typecheck-shared-submodule-bump
feat/queue-fase3-hardening
feat/queue-tools-push
fix/commit-id-guard
feat/queue-tools-fase2b
fix/review-verdict-comment
feat/queue-tools-fase2
claude/s4m-queue-chat-search-244a7c
chore/gen-schema-drop-url-strip
fix/mcp-stdio-orphan-leak
codex/codex-model-catalog
fix/task-review-poison-loop
codex/worker-usage-mcp-capture
feat/spec-plan-loop-max-rondes
fix/m20-plan-verdict-same-race
fix/m23-spec-maker-done-and-verdict-race
feat/m23-idea-spec-pipeline
fix/noodrem-cancel-guard
feat/m20-plan-review-loop
feat/on-demand-repo-clone-spec
feat/M19-allowlist-agent-docs
codex/forgejo-ci-20260707
feat/M19-docs-audit-job
feat/M22-auto-merge-reliability
feat/M21-sprint-batch-auto-deploy
fix/deploy-prompt-fail-loud-pin
fix/story-done-level-trigger
fix/auto-pr-reuse-only-open
feat/idea-chat-channel-tools
fix/tier-defer-claimability
chore/host-mcp-update-script
fix/deploy-prompt-ops-agent-contract
feat/idea-brainstorm-skill
feat/M17-deploy-job
feat/idea-chat-followup-mcp
feat/idea-chat-mcp
claude/job-kind-config-phase3
claude/mcp-review-done-gate
claude/mcp-unified-reviewlog
claude/question-channel-mcp
codex/opus-48-job-defaults
claude/idea-mcp-tools
feat/copilot-content-policy-mcp
feat/copilot-mcp-foundation
claude/nifty-shaw-90609d
refactor/wait-for-job-sprint-scope-types
fix/dockerfile-bash
fix/review-done-preserve-summary-trace
feat/http-graceful-shutdown
feat/codex-pr-review-phase2
fix/idea-review-plan-done-gate
feat/codex-plan-review-phase1
fix/tier-preference-enum-ordinal
chore/package-repo-only-metadata
docs/audit-2026-06-06
fix/idea-kinds-allow-agent-guide
feat/mcp-manual-idea-context
fix/product-worktree-default-branch
feat/worker-capability-scheduler
feat/sprint-353x8t4e
feat/mcp-doc-index
fix/defer-worktree-cleanup-usage-hook
chore/scrum4me-methodiek-binding
fix/worktree-submodule-and-codegen
codex/manual-job-editor-phase3-mcp
codex/fix-cross-repo-rollback-cleanup
fix/rollback-cleans-worktree-and-executions
fix/host-mcp-instance-id-fallback
chore/M16-fase3-shared-bump
cleanup/stale-scrum4me-vendor-refs
feat/M16-platform-split-shared-bootstrap
claude/naughty-brown-2be56e
feat/http-mcp-server
feat/doc-tool-discipline
claude/peaceful-dirac-979dd8
feat/pbi-102-pbi-doc-linking
fix/heartbeat-token-user-id-refresh
feat/PBI-13-forgejo-pr-urls
feat/story-pxzrkdbk
fix/idea-plan-reviewed-no-silent-approve
fix/cross-repo-worktree-and-pr
feat/sprint-gk6h5cu0
feat/PBI-12-sprint-tools
fix/classify-pseudo-paths
fix/attach-worktree-writes-branch
fix/prepare-done-uses-db-branch
chore/sync-schema
fix/idea-prompts-payload-path
fix/idea-kinds-permission-mode
feat/queue-loop-extraction
feat/pbi-67-job-config
feat/sprint-aolrn6ui
feat/skipped-exit-route
feat/sprint-worker
feat/sprint-flow
feat/pbi-fail-cascade
chore/sync-idea-prompts
chore/heartbeat-10s
claude/hardcore-shtern-3d6db0
feat/worker-quota-tools
feat/create-task-repo-url
feat/auto-merge-after-pr
fix/idea-job-done-skip-verify
fix/idea-job-claim-leftjoin
feat/m12-idea-jobs
feat/story-mhj9f2la
feat/cross-repo-task-routing
fix/verify-gate-required-level
docs/branch-per-story-flow
fix/heartbeat-self-heal-on-missing-record
fix/presence-bootstrap-before-connect
feat/plan-snapshot-verify-tool
feat/story-promotion-filter
feat/mcp-authoring-tools
feat/M11-question-tools
deploy/main-3ab3c3efa24d
deploy/main-511912a85dc0
deploy/main-276989eb231b
deploy/main-b9a028adb87e
deploy/main-de1afd25e428
deploy/main-d2251f7b11e8
deploy/main-cd556f2b5f92
deploy/main-bceba2e321e3
deploy/main-bd7be682635e
deploy/main-1fc33f8c1b6e
deploy/main-85be5eb02b97
deploy/main-4eb0cd1796cd
deploy/main-6b31906c1b90
deploy/main-b4c61987254f
deploy/main-e017bab0bfff
deploy/main-a843a79fce0b
deploy/main-5af973636c3f
deploy/main-8bbc0fd22141
deploy/main-285c98ae3fc6
deploy/main-390c391ce455
deploy/main-c20688e8b3e5
deploy/main-bef26bfc4948
deploy/main-99ff2618825a
deploy/main-201f7eb5877e
deploy/main-84ab210f9a29
deploy/iss5-1c81b7af
deploy/iss3-db519dc9
deploy/m38-033a2074
deploy/idea-169-f222f692
No labels
severity/s2
severity/s3
severity/s4
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
janpeter/scrum4me-mcp#213
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Status: closed (fixed) · Severity: s4_minor · Gemeld door: mac:claude · Occurrences: 1 (laatst: 2026-10-11T08:13:57.547Z) · Aangemaakt: 2026-10-11T08:13:57.547Z
Registratie
Wat er gebeurt
Een HARNESS-worker claimt een AGENT_CHAT-job, ook als het product van die chat buiten de
scoped_productsvan zijn token valt. Bij het claimen bouwtwait_for_jobgewoon de payload (src/tools/wait-for-job.ts, takjob.kind === 'AGENT_CHAT', rond regel 1329 op1fc33f8;buildAgentChatPayload). Pas de eerste doc-tool loopt vast opuserCanAccessProduct(src/access.ts:7), met "Product '' not found or not accessible".Waargenomen (2026-10-11, Scrum4Me /chat)
cmp43iaoi000h6o7rxklqivl5). Het harness-tokenagent-harness-local-llm-max2(api_tokenscmujtqny3000001tg51l7muim) had toenscoped_products {cmuhjw9e80003mt7rq4w3sauu, cmohrysyj0000rd17clnjy4tc}.cmv3ilxpz00dxz07rai97i0fz: FAILED metTOO_MANY_TOOL_ERRORS, "3 tool errors exceed maxToolErrors=2".cmv3ix66400e1z07ryxpgovtr: DONE, maar het model meldde dat het niets kon nakijken ("Product … not found or not accessible").Huidige situatie
JP heeft de beperking van het harness-token weggehaald (
scoped_products = '{}'), dus nu treedt het niet op. Zet iemand later weer een beperking op een token dat chatjobs claimt, dan komt het probleem terug.Mogelijke oplossing
userCanAccessProduct(job.product_id, worker-user)met de token-scope controleren. Mag het niet, dan meteen afsluiten met een duidelijke code, bijvoorbeeldPRODUCT_OUTSIDE_TOKEN_SCOPE, net zoalsAGENT_CHAT_REQUIRES_HARNESSen de skip-route, en zonder modelaanroep.Onderzoek
2026-10-11T10:33:29.754Z — mac:claude
Plan, door JP goedgekeurd op 2026-10-11, zonder ceremonie:
getFullJobContext, in de AGENT_CHAT-tak (src/tools/wait-for-job.ts), vóórbuildAgentChatPayload.getTokenScopedProducts(). Heeft het token een productbeperking zonder het product van de chat, dan volgt eenHarnessJobConfigErrormet de codeAGENT_CHAT_PRODUCT_OUT_OF_SCOPE. De job wordt viamarkJobTerminallyFailedFAILED, zonder payload en zonder modelaanroep.fix/iss-16-agent-chat-token-scopevanafbceba2e. Na de merge volgt de uitrol volgens het MCP-recept, alleen op JP's go.Oplossing
2026-10-18T10:55:38.395Z — mac:claude
Opgelost in janpeter/scrum4me-mcp#215, merge-commit
cd556f2(2026-10-11). Valt het product van een AGENT_CHAT buiten descoped_productsvan het token, dan wordt de job ingetFullJobContextmeteen FAILED metAGENT_CHAT_PRODUCT_OUT_OF_SCOPE, zonder payload en zonder modelaanroep. Een lege scope werkt zoals eerst.Live, gecontroleerd op 2026-10-18:
scrum4me-mcp-stable) stond bij de start van de huidige harness-MCP (2026-10-15 01:55) op3e5f7a0, en die bevatcd556f2;deploy/main-cd556f2b5f92.Bewezen met unittests (rood eerst). Een praktijkproef met een token mét beperking is niet gedaan, want het harness-token heeft sinds 2026-10-11 geen beperking.