fix(dispatch): a claim-bound stop closes a managed Task too (ISS-9) #210
No reviewers
Labels
No labels
severity/s2
severity/s3
severity/s4
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
janpeter/scrum4me-mcp!210
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/iss-9-close-task-stops"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
ISS-9 / IDEA-245 — PR 2 (scrum4me-mcp), T7. Follows Scrum4Me PR janpeter/Scrum4Me#346 (merged
b50ab6fc), whose closed-schema link 0001 is live on prod (T6, 2026-10-09: migrate + policy-apply green, activation preflight OK, live guard fingerprint = 0001afterSchemaHash).What
src/dispatch/stop-evidence.ts:closesAtStopremoved. A claim-bound stop (claim_bound_unscoped) on atask_implementationnow closes in the same transaction like every other action (FAILED, or cancellation forCANCEL_REQUESTED), so the Task binding and reservation are released. Accepted states areCLAIMED/UNCERTAIN/CANCEL_REQUESTEDfor every action.scripts/dispatch-test-db.mjs: pinned overlay of link 0001 (commitb50ab6fc, pathprisma/migrations/20261009140000_closed_schema_0001_task_guard_unscoped_stops/migration.sql, sha256e6c32f39…5767of the raw bytes), read withgit show, applied as the schema owner after the harness overlay; also checked bycheck.host-task): the pre-ISS-2 test is replaced by (1) a claim-bound stop closes a host Task FAILED, bindingNULL, reservation released, TaskFAILED; a stop replay returns the same receipt and adds no result/projection; (2) the ISS-12 orphan sweep closes a host Task whose supervisor was replaced before start (this path already closed task_implementation and would have rolled back on the old guard).T0 evidence
main=48555ea6= the T0 pin (GRILLS/idea-245-t0-mcp-evidencerev 2); no drift instop-evidence.ts,attempts.ts,artifacts.ts,lifecycle.ts,dispatch-test-db.mjs.Verification (local)
npm run typecheckgreen;npm test268 files / 2634 tests green.run-dispatch-ci.mjs, pgvector/pg17, schema root6dc581d): 30 files / 371 tests green.After merge
JP redeploys the dispatch service. Sign-off (ISS-9): the next real
task_implementationwith a pre-scope refusal or an orphan close ends terminal, with a result, released reservation andtasks.dispatch_request_idcleared; then ISS-9 and ISS-2 close.🤖 Generated with Claude Code
APPROVED
Findings:
De wijziging sluit managed Tasks via de bestaande transactionele afsluitpaden, behoudt de authenticatie en pre-scope-controles, en voorkomt een tweede afsluiting bij replay. De database-overlay volgt het bestaande patroon met een geverifieerde commit-, pad- en SHA-256-pin. De integratietests dekken terminale afsluiting, vrijgave van binding/reservering, replay en orphan-afsluiting. Geen strijdigheid met de geraadpleegde productstandaarden; de codecommentaren en PR-beschrijving beschrijven de afhankelijkheid en vervolguitrol voldoende.
Plan gekoppeld via commits (product Scrum4Me). References: ST-1651 (Scrum4Me). Geen omitted onderdelen. Deze PR levert het MCP-deel van T7; de eerdere schema-/uitroltaken vallen buiten deze diff. Scrum4Me-PR #346 is gemerged op de gepinde commit. De echte productie-aftekening na herdeploy blijft expliciet vervolgwerk volgens de PR en is geen claim van volledige story-oplevering.
Onafhankelijke verificatie op head
718cf3d40db5bd605b4031d5ff668d973e7ead10: beide typechecks groen; gewone suite 2634 tests geslaagd (81 standaard overgeslagen); disposable PostgreSQL 17-dispatch-gate 371/371 tests groen; diff-check en SQL-pin groen. De eerste dispatch-run had twee tijdzonegevoelige failures; na correctie van de lokale testcluster naar UTC is de volledige gate op een verse database geslaagd. Geen productie-mutaties uitgevoerd.