Compare commits
1 commit
main
...
fix/classi
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
20c6e388e3 |
23 changed files with 103 additions and 1605 deletions
3
.gitignore
vendored
3
.gitignore
vendored
|
|
@ -12,6 +12,3 @@ prisma/generated
|
|||
# Editor
|
||||
.vscode
|
||||
.idea
|
||||
|
||||
# Claude Code worktrees (per-session, never tracked)
|
||||
.claude/worktrees/
|
||||
|
|
|
|||
|
|
@ -1,165 +0,0 @@
|
|||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
import { Prisma } from '@prisma/client'
|
||||
|
||||
vi.mock('../src/prisma.js', () => ({
|
||||
prisma: {
|
||||
sprint: {
|
||||
findMany: vi.fn(),
|
||||
create: vi.fn(),
|
||||
},
|
||||
},
|
||||
}))
|
||||
|
||||
vi.mock('../src/auth.js', () => ({
|
||||
requireWriteAccess: vi.fn(),
|
||||
PermissionDeniedError: class PermissionDeniedError extends Error {
|
||||
constructor(message = 'Demo accounts cannot perform write operations') {
|
||||
super(message)
|
||||
this.name = 'PermissionDeniedError'
|
||||
}
|
||||
},
|
||||
}))
|
||||
|
||||
vi.mock('../src/access.js', () => ({
|
||||
userCanAccessProduct: vi.fn(),
|
||||
}))
|
||||
|
||||
import { prisma } from '../src/prisma.js'
|
||||
import { requireWriteAccess } from '../src/auth.js'
|
||||
import { userCanAccessProduct } from '../src/access.js'
|
||||
import { handleCreateSprint } from '../src/tools/create-sprint.js'
|
||||
|
||||
const mockPrisma = prisma as unknown as {
|
||||
sprint: {
|
||||
findMany: ReturnType<typeof vi.fn>
|
||||
create: ReturnType<typeof vi.fn>
|
||||
}
|
||||
}
|
||||
const mockRequireWriteAccess = requireWriteAccess as ReturnType<typeof vi.fn>
|
||||
const mockUserCanAccessProduct = userCanAccessProduct as ReturnType<typeof vi.fn>
|
||||
|
||||
const PRODUCT_ID = 'prod-1'
|
||||
const USER_ID = 'user-1'
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
mockRequireWriteAccess.mockResolvedValue({ userId: USER_ID, tokenId: 'tok-1', username: 'alice', isDemo: false })
|
||||
mockUserCanAccessProduct.mockResolvedValue(true)
|
||||
mockPrisma.sprint.findMany.mockResolvedValue([])
|
||||
})
|
||||
|
||||
function parseResult(result: Awaited<ReturnType<typeof handleCreateSprint>>) {
|
||||
const text = result.content?.[0]?.type === 'text' ? result.content[0].text : ''
|
||||
try { return JSON.parse(text) } catch { return text }
|
||||
}
|
||||
|
||||
describe('handleCreateSprint', () => {
|
||||
it('happy path: creates sprint with auto-generated code', async () => {
|
||||
mockPrisma.sprint.create.mockResolvedValue({
|
||||
id: 'spr-1',
|
||||
code: 'S-2026-05-11-1',
|
||||
sprint_goal: 'My goal',
|
||||
status: 'OPEN',
|
||||
start_date: new Date('2026-05-11'),
|
||||
created_at: new Date('2026-05-11T10:00:00Z'),
|
||||
})
|
||||
|
||||
const result = await handleCreateSprint({
|
||||
product_id: PRODUCT_ID,
|
||||
sprint_goal: 'My goal',
|
||||
})
|
||||
|
||||
expect(mockPrisma.sprint.create).toHaveBeenCalledTimes(1)
|
||||
const callArgs = mockPrisma.sprint.create.mock.calls[0][0]
|
||||
expect(callArgs.data.product_id).toBe(PRODUCT_ID)
|
||||
expect(callArgs.data.status).toBe('OPEN')
|
||||
expect(callArgs.data.sprint_goal).toBe('My goal')
|
||||
expect(callArgs.data.code).toMatch(/^S-\d{4}-\d{2}-\d{2}-1$/)
|
||||
expect(callArgs.data.start_date).toBeInstanceOf(Date)
|
||||
|
||||
const parsed = parseResult(result)
|
||||
expect(parsed.id).toBe('spr-1')
|
||||
expect(parsed.status).toBe('OPEN')
|
||||
})
|
||||
|
||||
it('uses user-provided code when given', async () => {
|
||||
mockPrisma.sprint.create.mockResolvedValue({
|
||||
id: 'spr-2',
|
||||
code: 'CUSTOM-CODE',
|
||||
sprint_goal: 'g',
|
||||
status: 'OPEN',
|
||||
start_date: new Date(),
|
||||
created_at: new Date(),
|
||||
})
|
||||
|
||||
await handleCreateSprint({
|
||||
product_id: PRODUCT_ID,
|
||||
code: 'CUSTOM-CODE',
|
||||
sprint_goal: 'g',
|
||||
})
|
||||
|
||||
expect(mockPrisma.sprint.create).toHaveBeenCalledTimes(1)
|
||||
expect(mockPrisma.sprint.findMany).not.toHaveBeenCalled()
|
||||
expect(mockPrisma.sprint.create.mock.calls[0][0].data.code).toBe('CUSTOM-CODE')
|
||||
})
|
||||
|
||||
it('auto-code increments past existing same-day sprints', async () => {
|
||||
// Codes moeten relatief aan "vandaag" zijn: generateNextSprintCode telt
|
||||
// alleen same-day sprints. Hardcoded datums maakten deze test datum-flaky.
|
||||
const today = new Date().toISOString().slice(0, 10)
|
||||
mockPrisma.sprint.findMany.mockResolvedValue([
|
||||
{ code: `S-${today}-1` },
|
||||
{ code: `S-${today}-3` },
|
||||
{ code: 'S-2020-01-01-7' },
|
||||
])
|
||||
mockPrisma.sprint.create.mockResolvedValue({
|
||||
id: 'spr-3', code: 'X', sprint_goal: 'g', status: 'OPEN', start_date: new Date(), created_at: new Date(),
|
||||
})
|
||||
|
||||
await handleCreateSprint({ product_id: PRODUCT_ID, sprint_goal: 'g' })
|
||||
|
||||
expect(mockPrisma.sprint.create.mock.calls[0][0].data.code).toBe(`S-${today}-4`)
|
||||
})
|
||||
|
||||
it('retries on P2002 unique conflict', async () => {
|
||||
const conflict = new Prisma.PrismaClientKnownRequestError('unique', {
|
||||
code: 'P2002', clientVersion: 'x', meta: { target: ['product_id', 'code'] },
|
||||
})
|
||||
mockPrisma.sprint.create
|
||||
.mockRejectedValueOnce(conflict)
|
||||
.mockResolvedValueOnce({
|
||||
id: 'spr-r', code: 'S-2026-05-11-2', sprint_goal: 'g', status: 'OPEN',
|
||||
start_date: new Date(), created_at: new Date(),
|
||||
})
|
||||
|
||||
const result = await handleCreateSprint({ product_id: PRODUCT_ID, sprint_goal: 'g' })
|
||||
|
||||
expect(mockPrisma.sprint.create).toHaveBeenCalledTimes(2)
|
||||
expect(parseResult(result).id).toBe('spr-r')
|
||||
})
|
||||
|
||||
it('returns error when user cannot access product', async () => {
|
||||
mockUserCanAccessProduct.mockResolvedValue(false)
|
||||
const result = await handleCreateSprint({ product_id: PRODUCT_ID, sprint_goal: 'g' })
|
||||
|
||||
expect(mockPrisma.sprint.create).not.toHaveBeenCalled()
|
||||
const text = result.content?.[0]?.type === 'text' ? result.content[0].text : ''
|
||||
expect(text).toMatch(/not found or not accessible/)
|
||||
})
|
||||
|
||||
it('uses provided start_date when given', async () => {
|
||||
mockPrisma.sprint.create.mockResolvedValue({
|
||||
id: 'spr-d', code: 'X', sprint_goal: 'g', status: 'OPEN',
|
||||
start_date: new Date('2026-01-01'), created_at: new Date(),
|
||||
})
|
||||
|
||||
await handleCreateSprint({
|
||||
product_id: PRODUCT_ID,
|
||||
sprint_goal: 'g',
|
||||
start_date: '2026-01-01',
|
||||
})
|
||||
|
||||
const callArgs = mockPrisma.sprint.create.mock.calls[0][0]
|
||||
expect(callArgs.data.start_date.toISOString().slice(0, 10)).toBe('2026-01-01')
|
||||
})
|
||||
})
|
||||
|
|
@ -1,141 +0,0 @@
|
|||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
|
||||
vi.mock('../src/prisma.js', () => ({
|
||||
prisma: {
|
||||
pbi: { findUnique: vi.fn() },
|
||||
sprint: { findUnique: vi.fn() },
|
||||
story: {
|
||||
findFirst: vi.fn(),
|
||||
findMany: vi.fn(),
|
||||
create: vi.fn(),
|
||||
},
|
||||
},
|
||||
}))
|
||||
|
||||
vi.mock('../src/auth.js', () => ({
|
||||
requireWriteAccess: vi.fn(),
|
||||
PermissionDeniedError: class PermissionDeniedError extends Error {
|
||||
constructor(message = 'Demo accounts cannot perform write operations') {
|
||||
super(message)
|
||||
this.name = 'PermissionDeniedError'
|
||||
}
|
||||
},
|
||||
}))
|
||||
|
||||
vi.mock('../src/access.js', () => ({
|
||||
userCanAccessProduct: vi.fn(),
|
||||
}))
|
||||
|
||||
import { prisma } from '../src/prisma.js'
|
||||
import { requireWriteAccess } from '../src/auth.js'
|
||||
import { userCanAccessProduct } from '../src/access.js'
|
||||
import { handleCreateStory } from '../src/tools/create-story.js'
|
||||
|
||||
const mockPrisma = prisma as unknown as {
|
||||
pbi: { findUnique: ReturnType<typeof vi.fn> }
|
||||
sprint: { findUnique: ReturnType<typeof vi.fn> }
|
||||
story: {
|
||||
findFirst: ReturnType<typeof vi.fn>
|
||||
findMany: ReturnType<typeof vi.fn>
|
||||
create: ReturnType<typeof vi.fn>
|
||||
}
|
||||
}
|
||||
const mockRequireWriteAccess = requireWriteAccess as ReturnType<typeof vi.fn>
|
||||
const mockUserCanAccessProduct = userCanAccessProduct as ReturnType<typeof vi.fn>
|
||||
|
||||
const PRODUCT_ID = 'prod-1'
|
||||
const PBI_ID = 'pbi-1'
|
||||
const SPRINT_ID = 'spr-1'
|
||||
const USER_ID = 'user-1'
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
mockRequireWriteAccess.mockResolvedValue({ userId: USER_ID, tokenId: 'tok-1', username: 'alice', isDemo: false })
|
||||
mockUserCanAccessProduct.mockResolvedValue(true)
|
||||
mockPrisma.pbi.findUnique.mockResolvedValue({ product_id: PRODUCT_ID })
|
||||
mockPrisma.story.findMany.mockResolvedValue([])
|
||||
mockPrisma.story.findFirst.mockResolvedValue(null)
|
||||
mockPrisma.story.create.mockImplementation((args: { data: Record<string, unknown> }) =>
|
||||
Promise.resolve({ id: 'story-1', created_at: new Date('2026-05-14T10:00:00Z'), ...args.data }),
|
||||
)
|
||||
})
|
||||
|
||||
function parseResult(result: Awaited<ReturnType<typeof handleCreateStory>>) {
|
||||
const text = result.content?.[0]?.type === 'text' ? result.content[0].text : ''
|
||||
try { return JSON.parse(text) } catch { return text }
|
||||
}
|
||||
|
||||
function errorText(result: Awaited<ReturnType<typeof handleCreateStory>>): string {
|
||||
return result.content?.[0]?.type === 'text' ? result.content[0].text : ''
|
||||
}
|
||||
|
||||
describe('handleCreateStory', () => {
|
||||
it('without sprint_id: creates story with status OPEN and no sprint', async () => {
|
||||
const result = await handleCreateStory({ pbi_id: PBI_ID, title: 'A story', priority: 2 })
|
||||
|
||||
expect(mockPrisma.sprint.findUnique).not.toHaveBeenCalled()
|
||||
const data = mockPrisma.story.create.mock.calls[0][0].data
|
||||
expect(data.status).toBe('OPEN')
|
||||
expect(data.sprint_id).toBeNull()
|
||||
expect(data.product_id).toBe(PRODUCT_ID)
|
||||
expect(parseResult(result).status).toBe('OPEN')
|
||||
})
|
||||
|
||||
it('with valid sprint_id: links story to sprint with status IN_SPRINT', async () => {
|
||||
mockPrisma.sprint.findUnique.mockResolvedValue({ product_id: PRODUCT_ID })
|
||||
|
||||
const result = await handleCreateStory({
|
||||
pbi_id: PBI_ID,
|
||||
title: 'A story',
|
||||
priority: 2,
|
||||
sprint_id: SPRINT_ID,
|
||||
})
|
||||
|
||||
expect(mockPrisma.sprint.findUnique).toHaveBeenCalledWith({
|
||||
where: { id: SPRINT_ID },
|
||||
select: { product_id: true },
|
||||
})
|
||||
const data = mockPrisma.story.create.mock.calls[0][0].data
|
||||
expect(data.status).toBe('IN_SPRINT')
|
||||
expect(data.sprint_id).toBe(SPRINT_ID)
|
||||
expect(parseResult(result).sprint_id).toBe(SPRINT_ID)
|
||||
})
|
||||
|
||||
it('rejects a non-existent sprint_id', async () => {
|
||||
mockPrisma.sprint.findUnique.mockResolvedValue(null)
|
||||
|
||||
const result = await handleCreateStory({
|
||||
pbi_id: PBI_ID,
|
||||
title: 'A story',
|
||||
priority: 2,
|
||||
sprint_id: 'missing',
|
||||
})
|
||||
|
||||
expect(mockPrisma.story.create).not.toHaveBeenCalled()
|
||||
expect(errorText(result)).toMatch(/Sprint missing not found/)
|
||||
})
|
||||
|
||||
it('rejects a sprint from a different product', async () => {
|
||||
mockPrisma.sprint.findUnique.mockResolvedValue({ product_id: 'other-product' })
|
||||
|
||||
const result = await handleCreateStory({
|
||||
pbi_id: PBI_ID,
|
||||
title: 'A story',
|
||||
priority: 2,
|
||||
sprint_id: SPRINT_ID,
|
||||
})
|
||||
|
||||
expect(mockPrisma.story.create).not.toHaveBeenCalled()
|
||||
expect(errorText(result)).toMatch(/different product/)
|
||||
})
|
||||
|
||||
it('returns error when PBI not found', async () => {
|
||||
mockPrisma.pbi.findUnique.mockResolvedValue(null)
|
||||
|
||||
const result = await handleCreateStory({ pbi_id: 'missing', title: 'A story', priority: 2 })
|
||||
|
||||
expect(mockPrisma.sprint.findUnique).not.toHaveBeenCalled()
|
||||
expect(mockPrisma.story.create).not.toHaveBeenCalled()
|
||||
expect(errorText(result)).toMatch(/PBI missing not found/)
|
||||
})
|
||||
})
|
||||
|
|
@ -113,71 +113,6 @@ describe('createWorktreeForJob', () => {
|
|||
}),
|
||||
).rejects.toThrow('Worktree path already exists')
|
||||
})
|
||||
|
||||
it('reuseBranch: reuses an existing local branch', async () => {
|
||||
const { repoDir, originDir } = await setupRepo()
|
||||
tmpDirs.push(repoDir, originDir)
|
||||
await makeWorktreeParent()
|
||||
|
||||
// Sibling already created the branch locally.
|
||||
await git(['branch', 'feat/sprint-abc', 'origin/main'], repoDir)
|
||||
|
||||
const result = await createWorktreeForJob({
|
||||
repoRoot: repoDir,
|
||||
jobId: 'job-reuse-local',
|
||||
branchName: 'feat/sprint-abc',
|
||||
baseRef: 'origin/main',
|
||||
reuseBranch: true,
|
||||
})
|
||||
|
||||
const { stdout } = await git(['rev-parse', '--abbrev-ref', 'HEAD'], result.worktreePath)
|
||||
expect(stdout.trim()).toBe('feat/sprint-abc')
|
||||
expect(result.branchName).toBe('feat/sprint-abc')
|
||||
})
|
||||
|
||||
it('reuseBranch: recreates a local branch from origin when only the remote has it', async () => {
|
||||
const { repoDir, originDir } = await setupRepo()
|
||||
tmpDirs.push(repoDir, originDir)
|
||||
await makeWorktreeParent()
|
||||
|
||||
// Branch exists on origin (a sibling pushed it, or the container was
|
||||
// recreated and the local clone is fresh) but not as a local branch.
|
||||
await git(['branch', 'feat/sprint-xyz', 'origin/main'], repoDir)
|
||||
await git(['push', 'origin', 'feat/sprint-xyz'], repoDir)
|
||||
await git(['branch', '-D', 'feat/sprint-xyz'], repoDir)
|
||||
|
||||
const result = await createWorktreeForJob({
|
||||
repoRoot: repoDir,
|
||||
jobId: 'job-reuse-origin',
|
||||
branchName: 'feat/sprint-xyz',
|
||||
baseRef: 'origin/main',
|
||||
reuseBranch: true,
|
||||
})
|
||||
|
||||
const { stdout } = await git(['rev-parse', '--abbrev-ref', 'HEAD'], result.worktreePath)
|
||||
expect(stdout.trim()).toBe('feat/sprint-xyz')
|
||||
})
|
||||
|
||||
it('reuseBranch: falls back to a fresh branch when it exists nowhere (cross-repo sprint)', async () => {
|
||||
const { repoDir, originDir } = await setupRepo()
|
||||
tmpDirs.push(repoDir, originDir)
|
||||
await makeWorktreeParent()
|
||||
|
||||
// reuseBranch is decided sprint-wide; for the first job targeting THIS
|
||||
// repo the branch exists neither locally nor on origin. Must not throw
|
||||
// "invalid reference" — should create it fresh from baseRef.
|
||||
const result = await createWorktreeForJob({
|
||||
repoRoot: repoDir,
|
||||
jobId: 'job-reuse-fresh',
|
||||
branchName: 'feat/sprint-newrepo',
|
||||
baseRef: 'origin/main',
|
||||
reuseBranch: true,
|
||||
})
|
||||
|
||||
const { stdout } = await git(['rev-parse', '--abbrev-ref', 'HEAD'], result.worktreePath)
|
||||
expect(stdout.trim()).toBe('feat/sprint-newrepo')
|
||||
expect(result.branchName).toBe('feat/sprint-newrepo')
|
||||
})
|
||||
})
|
||||
|
||||
describe('removeWorktreeForJob', () => {
|
||||
|
|
|
|||
|
|
@ -1,140 +0,0 @@
|
|||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
|
||||
vi.mock('../src/prisma.js', () => ({
|
||||
prisma: {
|
||||
idea: { update: vi.fn() },
|
||||
ideaLog: { create: vi.fn() },
|
||||
$transaction: vi.fn(),
|
||||
},
|
||||
}))
|
||||
|
||||
vi.mock('../src/auth.js', () => ({
|
||||
requireWriteAccess: vi.fn(),
|
||||
PermissionDeniedError: class PermissionDeniedError extends Error {
|
||||
constructor(message = 'Demo accounts cannot perform write operations') {
|
||||
super(message)
|
||||
this.name = 'PermissionDeniedError'
|
||||
}
|
||||
},
|
||||
}))
|
||||
|
||||
vi.mock('../src/access.js', () => ({
|
||||
userOwnsIdea: vi.fn(),
|
||||
}))
|
||||
|
||||
import { prisma } from '../src/prisma.js'
|
||||
import { requireWriteAccess } from '../src/auth.js'
|
||||
import { userOwnsIdea } from '../src/access.js'
|
||||
import { handleUpdateIdeaPlanReviewed } from '../src/tools/update-idea-plan-reviewed.js'
|
||||
|
||||
const mockPrisma = prisma as unknown as {
|
||||
idea: { update: ReturnType<typeof vi.fn> }
|
||||
ideaLog: { create: ReturnType<typeof vi.fn> }
|
||||
$transaction: ReturnType<typeof vi.fn>
|
||||
}
|
||||
const mockRequireWriteAccess = requireWriteAccess as ReturnType<typeof vi.fn>
|
||||
const mockUserOwnsIdea = userOwnsIdea as ReturnType<typeof vi.fn>
|
||||
|
||||
const IDEA_ID = 'idea-1'
|
||||
const USER_ID = 'user-1'
|
||||
const REVIEW_LOG = {
|
||||
rounds: [{ score: 88 }],
|
||||
convergence: { stable_at_round: 2 },
|
||||
approval: { status: 'approved' },
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
mockRequireWriteAccess.mockResolvedValue({
|
||||
userId: USER_ID,
|
||||
tokenId: 'tok-1',
|
||||
username: 'alice',
|
||||
isDemo: false,
|
||||
})
|
||||
mockUserOwnsIdea.mockResolvedValue(true)
|
||||
// $transaction returns the array of its two operations' results; the handler
|
||||
// only reads result[0] (the idea.update result).
|
||||
mockPrisma.$transaction.mockImplementation(async () => [
|
||||
{ id: IDEA_ID, status: 'PLACEHOLDER', code: 'IDEA-1' },
|
||||
{},
|
||||
])
|
||||
})
|
||||
|
||||
function parseResult(result: Awaited<ReturnType<typeof handleUpdateIdeaPlanReviewed>>) {
|
||||
const text = result.content?.[0]?.type === 'text' ? result.content[0].text : ''
|
||||
try {
|
||||
return JSON.parse(text)
|
||||
} catch {
|
||||
return text
|
||||
}
|
||||
}
|
||||
|
||||
// The handler builds `data.status` inside the idea.update call passed to
|
||||
// $transaction. We capture it by inspecting the prisma.idea.update mock args.
|
||||
function statusPassedToUpdate(): string | undefined {
|
||||
const call = mockPrisma.idea.update.mock.calls[0]
|
||||
return call?.[0]?.data?.status
|
||||
}
|
||||
|
||||
describe('handleUpdateIdeaPlanReviewed — status transition', () => {
|
||||
it('approval_status="approved" → PLAN_REVIEWED', async () => {
|
||||
await handleUpdateIdeaPlanReviewed({
|
||||
idea_id: IDEA_ID,
|
||||
review_log: REVIEW_LOG,
|
||||
approval_status: 'approved',
|
||||
})
|
||||
expect(statusPassedToUpdate()).toBe('PLAN_REVIEWED')
|
||||
})
|
||||
|
||||
it('approval_status="rejected" → PLAN_REVIEW_FAILED', async () => {
|
||||
await handleUpdateIdeaPlanReviewed({
|
||||
idea_id: IDEA_ID,
|
||||
review_log: REVIEW_LOG,
|
||||
approval_status: 'rejected',
|
||||
})
|
||||
expect(statusPassedToUpdate()).toBe('PLAN_REVIEW_FAILED')
|
||||
})
|
||||
|
||||
it('approval_status="pending" → PLAN_REVIEW_FAILED (needs manual approval, never silently approved)', async () => {
|
||||
await handleUpdateIdeaPlanReviewed({
|
||||
idea_id: IDEA_ID,
|
||||
review_log: REVIEW_LOG,
|
||||
approval_status: 'pending',
|
||||
})
|
||||
expect(statusPassedToUpdate()).toBe('PLAN_REVIEW_FAILED')
|
||||
})
|
||||
|
||||
it('omitted approval_status → PLAN_REVIEW_FAILED (safe default, not PLAN_REVIEWED)', async () => {
|
||||
await handleUpdateIdeaPlanReviewed({
|
||||
idea_id: IDEA_ID,
|
||||
review_log: REVIEW_LOG,
|
||||
})
|
||||
expect(statusPassedToUpdate()).toBe('PLAN_REVIEW_FAILED')
|
||||
})
|
||||
|
||||
it('returns "Idea not found" when the user does not own the idea', async () => {
|
||||
mockUserOwnsIdea.mockResolvedValue(false)
|
||||
const result = await handleUpdateIdeaPlanReviewed({
|
||||
idea_id: IDEA_ID,
|
||||
review_log: REVIEW_LOG,
|
||||
approval_status: 'approved',
|
||||
})
|
||||
expect(parseResult(result)).toContain('Idea not found')
|
||||
expect(mockPrisma.idea.update).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('persists review_log + reviewed_at and logs a PLAN_REVIEW_RESULT entry', async () => {
|
||||
await handleUpdateIdeaPlanReviewed({
|
||||
idea_id: IDEA_ID,
|
||||
review_log: REVIEW_LOG,
|
||||
approval_status: 'approved',
|
||||
})
|
||||
const updateArg = mockPrisma.idea.update.mock.calls[0]?.[0]
|
||||
expect(updateArg?.data?.plan_review_log).toEqual(REVIEW_LOG)
|
||||
expect(updateArg?.data?.reviewed_at).toBeInstanceOf(Date)
|
||||
|
||||
const logArg = mockPrisma.ideaLog.create.mock.calls[0]?.[0]
|
||||
expect(logArg?.data?.type).toBe('PLAN_REVIEW_RESULT')
|
||||
expect(logArg?.data?.idea_id).toBe(IDEA_ID)
|
||||
})
|
||||
})
|
||||
|
|
@ -4,7 +4,7 @@ vi.mock('../src/prisma.js', () => ({
|
|||
prisma: {
|
||||
product: { findUnique: vi.fn() },
|
||||
task: { findUnique: vi.fn() },
|
||||
claudeJob: { findFirst: vi.fn(), findMany: vi.fn(), findUnique: vi.fn() },
|
||||
claudeJob: { findFirst: vi.fn(), findUnique: vi.fn() },
|
||||
},
|
||||
}))
|
||||
|
||||
|
|
@ -22,7 +22,6 @@ const mockPrisma = prisma as unknown as {
|
|||
task: { findUnique: ReturnType<typeof vi.fn> }
|
||||
claudeJob: {
|
||||
findFirst: ReturnType<typeof vi.fn>
|
||||
findMany: ReturnType<typeof vi.fn>
|
||||
findUnique: ReturnType<typeof vi.fn>
|
||||
}
|
||||
}
|
||||
|
|
@ -42,10 +41,9 @@ beforeEach(() => {
|
|||
mockPrisma.product.findUnique.mockResolvedValue({ auto_pr: true })
|
||||
mockPrisma.task.findUnique.mockResolvedValue({
|
||||
title: 'Add feature',
|
||||
repo_url: null,
|
||||
story: { id: 'story-1', code: 'SCRUM-42', title: 'Story title' },
|
||||
})
|
||||
mockPrisma.claudeJob.findMany.mockResolvedValue([]) // no sibling PRs by default
|
||||
mockPrisma.claudeJob.findFirst.mockResolvedValue(null) // no sibling PR by default
|
||||
// Default: legacy job zonder sprint_run (STORY-mode pad).
|
||||
mockPrisma.claudeJob.findUnique.mockResolvedValue({ sprint_run_id: null, sprint_run: null })
|
||||
mockCreatePr.mockResolvedValue({ url: 'https://github.com/org/repo/pull/99' })
|
||||
|
|
@ -64,27 +62,12 @@ describe('maybeCreateAutoPr', () => {
|
|||
})
|
||||
|
||||
it('reuses sibling pr_url when another job in same story already opened a PR', async () => {
|
||||
mockPrisma.claudeJob.findMany.mockResolvedValue([
|
||||
{ pr_url: 'https://github.com/org/repo/pull/77', task: { repo_url: null } },
|
||||
])
|
||||
mockPrisma.claudeJob.findFirst.mockResolvedValue({ pr_url: 'https://github.com/org/repo/pull/77' })
|
||||
const url = await maybeCreateAutoPr(BASE_OPTS)
|
||||
expect(url).toBe('https://github.com/org/repo/pull/77')
|
||||
expect(mockCreatePr).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('does NOT reuse a sibling PR from a different repo (cross-repo story)', async () => {
|
||||
// Sibling targeted another repo via task.repo_url — its PR must not leak in.
|
||||
mockPrisma.claudeJob.findMany.mockResolvedValue([
|
||||
{
|
||||
pr_url: 'https://github.com/org/other-repo/pull/12',
|
||||
task: { repo_url: 'https://github.com/org/other-repo' },
|
||||
},
|
||||
])
|
||||
const url = await maybeCreateAutoPr(BASE_OPTS)
|
||||
expect(url).toBe('https://github.com/org/repo/pull/99') // fresh PR, not the sibling's
|
||||
expect(mockCreatePr).toHaveBeenCalledOnce()
|
||||
})
|
||||
|
||||
it('returns null when auto_pr=false', async () => {
|
||||
mockPrisma.product.findUnique.mockResolvedValue({ auto_pr: false })
|
||||
const url = await maybeCreateAutoPr(BASE_OPTS)
|
||||
|
|
@ -95,7 +78,6 @@ describe('maybeCreateAutoPr', () => {
|
|||
it('uses story title without code prefix when story has no code', async () => {
|
||||
mockPrisma.task.findUnique.mockResolvedValue({
|
||||
title: 'Add feature',
|
||||
repo_url: null,
|
||||
story: { id: 'story-1', code: null, title: 'Story title' },
|
||||
})
|
||||
await maybeCreateAutoPr(BASE_OPTS)
|
||||
|
|
@ -131,9 +113,7 @@ describe('maybeCreateAutoPr', () => {
|
|||
sprint_run_id: 'run-1',
|
||||
sprint_run: { id: 'run-1', pr_strategy: 'SPRINT', sprint: { sprint_goal: 'Goal' } },
|
||||
})
|
||||
mockPrisma.claudeJob.findMany.mockResolvedValue([
|
||||
{ pr_url: 'https://github.com/org/repo/pull/55', task: { repo_url: null } },
|
||||
])
|
||||
mockPrisma.claudeJob.findFirst.mockResolvedValue({ pr_url: 'https://github.com/org/repo/pull/55' })
|
||||
|
||||
const url = await maybeCreateAutoPr(BASE_OPTS)
|
||||
|
||||
|
|
@ -141,29 +121,6 @@ describe('maybeCreateAutoPr', () => {
|
|||
expect(mockCreatePr).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('SPRINT-mode: cross-repo — sibling-PR van ander repo wordt niet hergebruikt', async () => {
|
||||
mockPrisma.claudeJob.findUnique.mockResolvedValue({
|
||||
sprint_run_id: 'run-1',
|
||||
sprint_run: { id: 'run-1', pr_strategy: 'SPRINT', sprint: { sprint_goal: 'Goal' } },
|
||||
})
|
||||
// Deze job target een ander repo via task.repo_url.
|
||||
mockPrisma.task.findUnique.mockResolvedValue({
|
||||
title: 'MCP-taak',
|
||||
repo_url: 'https://github.com/org/scrum4me-mcp',
|
||||
story: { id: 'story-1', code: 'SCRUM-9', title: 'Story title' },
|
||||
})
|
||||
// Sibling met pr_url hoort bij het product-repo (repo_url null) → andere bucket.
|
||||
mockPrisma.claudeJob.findMany.mockResolvedValue([
|
||||
{ pr_url: 'https://github.com/org/repo/pull/201', task: { repo_url: null } },
|
||||
])
|
||||
|
||||
const url = await maybeCreateAutoPr(BASE_OPTS)
|
||||
|
||||
// Geen hergebruik van de product-repo PR → eigen draft-PR voor het mcp-repo.
|
||||
expect(url).toBe('https://github.com/org/repo/pull/99')
|
||||
expect(mockCreatePr).toHaveBeenCalledOnce()
|
||||
})
|
||||
|
||||
it('returns null and does not throw when gh fails', async () => {
|
||||
mockCreatePr.mockResolvedValue({ error: 'gh CLI not found' })
|
||||
const url = await maybeCreateAutoPr(BASE_OPTS)
|
||||
|
|
|
|||
|
|
@ -1,74 +0,0 @@
|
|||
// Unit-tests voor resolveJobTimestamps — de status-gedreven timestamp-helper
|
||||
// van update_job_status. Pure functie, geen mocks (zoals update-job-status-gate).
|
||||
|
||||
import { describe, it, expect } from 'vitest'
|
||||
import { resolveJobTimestamps } from '../src/tools/update-job-status.js'
|
||||
|
||||
const NOW = new Date('2026-05-14T12:00:00.000Z')
|
||||
const EARLIER = new Date('2026-05-14T11:00:00.000Z')
|
||||
|
||||
describe('resolveJobTimestamps', () => {
|
||||
describe('running', () => {
|
||||
it('sets started_at when not yet set, no finished_at', () => {
|
||||
const r = resolveJobTimestamps('running', { claimed_at: EARLIER, started_at: null }, NOW)
|
||||
expect(r.started_at).toBe(NOW)
|
||||
expect(r.finished_at).toBeUndefined()
|
||||
expect(r.claimed_at).toBeUndefined()
|
||||
})
|
||||
|
||||
it('is set-once: does not re-stamp started_at when already set', () => {
|
||||
const r = resolveJobTimestamps('running', { claimed_at: EARLIER, started_at: EARLIER }, NOW)
|
||||
expect(r.started_at).toBeUndefined()
|
||||
expect(r.finished_at).toBeUndefined()
|
||||
expect(r.claimed_at).toBeUndefined()
|
||||
})
|
||||
})
|
||||
|
||||
describe('terminal transitions (done/failed/skipped)', () => {
|
||||
it.each(['done', 'failed', 'skipped'] as const)(
|
||||
'backfills started_at and sets finished_at for %s when started_at is null',
|
||||
(status) => {
|
||||
const r = resolveJobTimestamps(status, { claimed_at: EARLIER, started_at: null }, NOW)
|
||||
expect(r.started_at).toBe(NOW)
|
||||
expect(r.finished_at).toBe(NOW)
|
||||
expect(r.claimed_at).toBeUndefined()
|
||||
},
|
||||
)
|
||||
|
||||
it('only sets finished_at when started_at is already set', () => {
|
||||
const r = resolveJobTimestamps('done', { claimed_at: EARLIER, started_at: EARLIER }, NOW)
|
||||
expect(r.started_at).toBeUndefined()
|
||||
expect(r.finished_at).toBe(NOW)
|
||||
expect(r.claimed_at).toBeUndefined()
|
||||
})
|
||||
})
|
||||
|
||||
describe('claimed_at backfill', () => {
|
||||
it.each(['running', 'done', 'failed', 'skipped'] as const)(
|
||||
'backfills claimed_at for %s when it is null',
|
||||
(status) => {
|
||||
const r = resolveJobTimestamps(status, { claimed_at: null, started_at: null }, NOW)
|
||||
expect(r.claimed_at).toBe(NOW)
|
||||
},
|
||||
)
|
||||
|
||||
it('never returns claimed_at when it is already set', () => {
|
||||
const r = resolveJobTimestamps('done', { claimed_at: EARLIER, started_at: EARLIER }, NOW)
|
||||
expect(r.claimed_at).toBeUndefined()
|
||||
})
|
||||
})
|
||||
|
||||
it('returns only finished_at when all timestamps are already set and status is terminal', () => {
|
||||
const r = resolveJobTimestamps('failed', { claimed_at: EARLIER, started_at: EARLIER }, NOW)
|
||||
expect(r).toEqual({ finished_at: NOW })
|
||||
})
|
||||
|
||||
it('defaults now to a fresh Date when omitted', () => {
|
||||
const before = Date.now()
|
||||
const r = resolveJobTimestamps('running', { claimed_at: EARLIER, started_at: null })
|
||||
const after = Date.now()
|
||||
expect(r.started_at).toBeInstanceOf(Date)
|
||||
expect(r.started_at!.getTime()).toBeGreaterThanOrEqual(before)
|
||||
expect(r.started_at!.getTime()).toBeLessThanOrEqual(after)
|
||||
})
|
||||
})
|
||||
|
|
@ -1,174 +0,0 @@
|
|||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
|
||||
vi.mock('../src/prisma.js', () => ({
|
||||
prisma: {
|
||||
sprint: {
|
||||
findUnique: vi.fn(),
|
||||
update: vi.fn(),
|
||||
},
|
||||
},
|
||||
}))
|
||||
|
||||
vi.mock('../src/auth.js', () => ({
|
||||
requireWriteAccess: vi.fn(),
|
||||
PermissionDeniedError: class PermissionDeniedError extends Error {
|
||||
constructor(message = 'Demo accounts cannot perform write operations') {
|
||||
super(message)
|
||||
this.name = 'PermissionDeniedError'
|
||||
}
|
||||
},
|
||||
}))
|
||||
|
||||
vi.mock('../src/access.js', () => ({
|
||||
userCanAccessProduct: vi.fn(),
|
||||
}))
|
||||
|
||||
import { prisma } from '../src/prisma.js'
|
||||
import { requireWriteAccess } from '../src/auth.js'
|
||||
import { userCanAccessProduct } from '../src/access.js'
|
||||
import { handleUpdateSprint } from '../src/tools/update-sprint.js'
|
||||
|
||||
const mockPrisma = prisma as unknown as {
|
||||
sprint: {
|
||||
findUnique: ReturnType<typeof vi.fn>
|
||||
update: ReturnType<typeof vi.fn>
|
||||
}
|
||||
}
|
||||
const mockRequireWriteAccess = requireWriteAccess as ReturnType<typeof vi.fn>
|
||||
const mockUserCanAccessProduct = userCanAccessProduct as ReturnType<typeof vi.fn>
|
||||
|
||||
const SPRINT_ID = 'spr-1'
|
||||
const PRODUCT_ID = 'prod-1'
|
||||
const USER_ID = 'user-1'
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
mockRequireWriteAccess.mockResolvedValue({ userId: USER_ID, tokenId: 'tok-1', username: 'alice', isDemo: false })
|
||||
mockUserCanAccessProduct.mockResolvedValue(true)
|
||||
mockPrisma.sprint.findUnique.mockResolvedValue({ id: SPRINT_ID, product_id: PRODUCT_ID })
|
||||
mockPrisma.sprint.update.mockResolvedValue({
|
||||
id: SPRINT_ID,
|
||||
code: 'S-2026-05-11-1',
|
||||
sprint_goal: 'g',
|
||||
status: 'OPEN',
|
||||
start_date: new Date('2026-05-11'),
|
||||
end_date: null,
|
||||
completed_at: null,
|
||||
})
|
||||
})
|
||||
|
||||
function getText(result: Awaited<ReturnType<typeof handleUpdateSprint>>) {
|
||||
return result.content?.[0]?.type === 'text' ? result.content[0].text : ''
|
||||
}
|
||||
|
||||
describe('handleUpdateSprint', () => {
|
||||
it('returns error when no fields provided', async () => {
|
||||
const result = await handleUpdateSprint({ sprint_id: SPRINT_ID })
|
||||
|
||||
expect(mockPrisma.sprint.update).not.toHaveBeenCalled()
|
||||
expect(getText(result)).toMatch(/Minstens één veld vereist/)
|
||||
})
|
||||
|
||||
it('updates status only', async () => {
|
||||
await handleUpdateSprint({ sprint_id: SPRINT_ID, status: 'OPEN' })
|
||||
|
||||
expect(mockPrisma.sprint.update).toHaveBeenCalledTimes(1)
|
||||
const args = mockPrisma.sprint.update.mock.calls[0][0]
|
||||
expect(args.where).toEqual({ id: SPRINT_ID })
|
||||
expect(args.data).toEqual({ status: 'OPEN' })
|
||||
})
|
||||
|
||||
it('auto-sets end_date AND completed_at when status → CLOSED without explicit end_date', async () => {
|
||||
const before = Date.now()
|
||||
await handleUpdateSprint({ sprint_id: SPRINT_ID, status: 'CLOSED' })
|
||||
const after = Date.now()
|
||||
|
||||
const args = mockPrisma.sprint.update.mock.calls[0][0]
|
||||
expect(args.data.status).toBe('CLOSED')
|
||||
expect(args.data.end_date).toBeInstanceOf(Date)
|
||||
expect(args.data.end_date.getTime()).toBeGreaterThanOrEqual(before)
|
||||
expect(args.data.end_date.getTime()).toBeLessThanOrEqual(after)
|
||||
expect(args.data.completed_at).toBeInstanceOf(Date)
|
||||
expect(args.data.completed_at.getTime()).toBeGreaterThanOrEqual(before)
|
||||
expect(args.data.completed_at.getTime()).toBeLessThanOrEqual(after)
|
||||
})
|
||||
|
||||
it('auto-sets end_date when status → FAILED, but does NOT set completed_at', async () => {
|
||||
await handleUpdateSprint({ sprint_id: SPRINT_ID, status: 'FAILED' })
|
||||
|
||||
const args = mockPrisma.sprint.update.mock.calls[0][0]
|
||||
expect(args.data.end_date).toBeInstanceOf(Date)
|
||||
expect(args.data.completed_at).toBeUndefined()
|
||||
})
|
||||
|
||||
it('auto-sets end_date when status → ARCHIVED, but does NOT set completed_at', async () => {
|
||||
await handleUpdateSprint({ sprint_id: SPRINT_ID, status: 'ARCHIVED' })
|
||||
|
||||
const args = mockPrisma.sprint.update.mock.calls[0][0]
|
||||
expect(args.data.end_date).toBeInstanceOf(Date)
|
||||
expect(args.data.completed_at).toBeUndefined()
|
||||
})
|
||||
|
||||
it('still sets completed_at when status → CLOSED even with explicit end_date', async () => {
|
||||
await handleUpdateSprint({
|
||||
sprint_id: SPRINT_ID,
|
||||
status: 'CLOSED',
|
||||
end_date: '2025-12-31',
|
||||
})
|
||||
|
||||
const args = mockPrisma.sprint.update.mock.calls[0][0]
|
||||
expect(args.data.end_date.toISOString().slice(0, 10)).toBe('2025-12-31')
|
||||
expect(args.data.completed_at).toBeInstanceOf(Date)
|
||||
})
|
||||
|
||||
it('does NOT auto-set end_date or completed_at when status → OPEN', async () => {
|
||||
await handleUpdateSprint({ sprint_id: SPRINT_ID, status: 'OPEN' })
|
||||
|
||||
const args = mockPrisma.sprint.update.mock.calls[0][0]
|
||||
expect(args.data.end_date).toBeUndefined()
|
||||
expect(args.data.completed_at).toBeUndefined()
|
||||
})
|
||||
|
||||
it('updates multiple fields at once', async () => {
|
||||
await handleUpdateSprint({
|
||||
sprint_id: SPRINT_ID,
|
||||
sprint_goal: 'New goal',
|
||||
start_date: '2026-05-15',
|
||||
})
|
||||
|
||||
const args = mockPrisma.sprint.update.mock.calls[0][0]
|
||||
expect(args.data.sprint_goal).toBe('New goal')
|
||||
expect(args.data.start_date.toISOString().slice(0, 10)).toBe('2026-05-15')
|
||||
expect(args.data.status).toBeUndefined()
|
||||
expect(args.data.end_date).toBeUndefined()
|
||||
})
|
||||
|
||||
it('returns error when sprint not found', async () => {
|
||||
mockPrisma.sprint.findUnique.mockResolvedValue(null)
|
||||
|
||||
const result = await handleUpdateSprint({ sprint_id: SPRINT_ID, status: 'CLOSED' })
|
||||
|
||||
expect(mockPrisma.sprint.update).not.toHaveBeenCalled()
|
||||
expect(getText(result)).toMatch(/not found/)
|
||||
})
|
||||
|
||||
it('returns error when user cannot access sprint product', async () => {
|
||||
mockUserCanAccessProduct.mockResolvedValue(false)
|
||||
|
||||
const result = await handleUpdateSprint({ sprint_id: SPRINT_ID, status: 'CLOSED' })
|
||||
|
||||
expect(mockPrisma.sprint.update).not.toHaveBeenCalled()
|
||||
expect(getText(result)).toMatch(/not accessible/)
|
||||
})
|
||||
|
||||
it('allows any status transition (no state-machine)', async () => {
|
||||
await handleUpdateSprint({ sprint_id: SPRINT_ID, status: 'OPEN' })
|
||||
expect(mockPrisma.sprint.update).toHaveBeenCalledTimes(1)
|
||||
|
||||
await handleUpdateSprint({ sprint_id: SPRINT_ID, status: 'CLOSED' })
|
||||
expect(mockPrisma.sprint.update).toHaveBeenCalledTimes(2)
|
||||
|
||||
await handleUpdateSprint({ sprint_id: SPRINT_ID, status: 'OPEN' })
|
||||
expect(mockPrisma.sprint.update).toHaveBeenCalledTimes(3)
|
||||
})
|
||||
})
|
||||
4
package-lock.json
generated
4
package-lock.json
generated
|
|
@ -1,12 +1,12 @@
|
|||
{
|
||||
"name": "scrum4me-mcp",
|
||||
"version": "0.8.0",
|
||||
"version": "0.7.0",
|
||||
"lockfileVersion": 3,
|
||||
"requires": true,
|
||||
"packages": {
|
||||
"": {
|
||||
"name": "scrum4me-mcp",
|
||||
"version": "0.8.0",
|
||||
"version": "0.7.0",
|
||||
"hasInstallScript": true,
|
||||
"license": "MIT",
|
||||
"dependencies": {
|
||||
|
|
|
|||
|
|
@ -1,6 +1,6 @@
|
|||
{
|
||||
"name": "scrum4me-mcp",
|
||||
"version": "0.8.0",
|
||||
"version": "0.7.0",
|
||||
"description": "MCP server for Scrum4Me — exposes dev-flow tools and prompts via the Model Context Protocol",
|
||||
"type": "module",
|
||||
"bin": {
|
||||
|
|
|
|||
|
|
@ -100,9 +100,6 @@ enum IdeaStatus {
|
|||
PLANNING
|
||||
PLAN_FAILED
|
||||
PLAN_READY
|
||||
REVIEWING_PLAN
|
||||
PLAN_REVIEW_FAILED
|
||||
PLAN_REVIEWED
|
||||
PLANNED
|
||||
}
|
||||
|
||||
|
|
@ -110,7 +107,6 @@ enum ClaudeJobKind {
|
|||
TASK_IMPLEMENTATION
|
||||
IDEA_GRILL
|
||||
IDEA_MAKE_PLAN
|
||||
IDEA_REVIEW_PLAN
|
||||
PLAN_CHAT
|
||||
SPRINT_IMPLEMENTATION
|
||||
}
|
||||
|
|
@ -128,7 +124,6 @@ enum IdeaLogType {
|
|||
NOTE
|
||||
GRILL_RESULT
|
||||
PLAN_RESULT
|
||||
PLAN_REVIEW_RESULT
|
||||
STATUS_CHANGE
|
||||
JOB_EVENT
|
||||
}
|
||||
|
|
@ -152,7 +147,6 @@ model User {
|
|||
active_product Product? @relation("UserActiveProduct", fields: [active_product_id], references: [id], onDelete: SetNull)
|
||||
idea_code_counter Int @default(0)
|
||||
min_quota_pct Int @default(20)
|
||||
settings Json @default("{}")
|
||||
created_at DateTime @default(now())
|
||||
updated_at DateTime @updatedAt
|
||||
roles UserRole[]
|
||||
|
|
@ -526,8 +520,6 @@ model Idea {
|
|||
description String? @db.VarChar(4000)
|
||||
grill_md String? @db.Text
|
||||
plan_md String? @db.Text
|
||||
plan_review_log Json? // ReviewLog from orchestrator (all rounds, convergence metrics, approval status)
|
||||
reviewed_at DateTime? // When last reviewed
|
||||
pbi Pbi? @relation(fields: [pbi_id], references: [id], onDelete: SetNull)
|
||||
pbi_id String? @unique
|
||||
status IdeaStatus @default(DRAFT)
|
||||
|
|
|
|||
|
|
@ -15,19 +15,6 @@ async function branchExists(repoRoot: string, name: string): Promise<boolean> {
|
|||
}
|
||||
}
|
||||
|
||||
async function remoteBranchExists(repoRoot: string, name: string): Promise<boolean> {
|
||||
try {
|
||||
await exec(
|
||||
'git',
|
||||
['show-ref', '--verify', '--quiet', `refs/remotes/origin/${name}`],
|
||||
{ cwd: repoRoot },
|
||||
)
|
||||
return true
|
||||
} catch {
|
||||
return false
|
||||
}
|
||||
}
|
||||
|
||||
async function findWorktreeForBranch(
|
||||
repoRoot: string,
|
||||
branchName: string,
|
||||
|
|
@ -88,27 +75,7 @@ export async function createWorktreeForJob(opts: {
|
|||
if (occupant) {
|
||||
await exec('git', ['worktree', 'remove', '--force', occupant], { cwd: repoRoot })
|
||||
}
|
||||
// reuseBranch is decided sprint-wide, but git branches are per-repo. For a
|
||||
// cross-repo sprint the first job targeting THIS repo gets reuseBranch=true
|
||||
// even though the branch was never created here; a container recreate also
|
||||
// wipes the local clone. Fall back gracefully instead of failing with
|
||||
// "invalid reference":
|
||||
// - local branch exists → reuse it
|
||||
// - exists on origin only → recreate the local branch tracking origin
|
||||
// - nowhere → create it fresh from baseRef
|
||||
if (await branchExists(repoRoot, branchName)) {
|
||||
await exec('git', ['worktree', 'add', worktreePath, branchName], { cwd: repoRoot })
|
||||
} else if (await remoteBranchExists(repoRoot, branchName)) {
|
||||
await exec(
|
||||
'git',
|
||||
['worktree', 'add', '-b', branchName, worktreePath, `origin/${branchName}`],
|
||||
{ cwd: repoRoot },
|
||||
)
|
||||
} else {
|
||||
await exec('git', ['worktree', 'add', '-b', branchName, worktreePath, baseRef], {
|
||||
cwd: repoRoot,
|
||||
})
|
||||
}
|
||||
return { worktreePath, branchName }
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -12,8 +12,6 @@ import { registerLogCommitTool } from './tools/log-commit.js'
|
|||
import { registerCreatePbiTool } from './tools/create-pbi.js'
|
||||
import { registerCreateStoryTool } from './tools/create-story.js'
|
||||
import { registerCreateTaskTool } from './tools/create-task.js'
|
||||
import { registerCreateSprintTool } from './tools/create-sprint.js'
|
||||
import { registerUpdateSprintTool } from './tools/update-sprint.js'
|
||||
import { registerAskUserQuestionTool } from './tools/ask-user-question.js'
|
||||
import { registerGetQuestionAnswerTool } from './tools/get-question-answer.js'
|
||||
import { registerListOpenQuestionsTool } from './tools/list-open-questions.js'
|
||||
|
|
@ -28,7 +26,6 @@ import { registerMarkPbiPrMergedTool } from './tools/mark-pbi-pr-merged.js'
|
|||
import { registerGetIdeaContextTool } from './tools/get-idea-context.js'
|
||||
import { registerUpdateIdeaGrillMdTool } from './tools/update-idea-grill-md.js'
|
||||
import { registerUpdateIdeaPlanMdTool } from './tools/update-idea-plan-md.js'
|
||||
import { registerUpdateIdeaPlanReviewedTool } from './tools/update-idea-plan-reviewed.js'
|
||||
import { registerLogIdeaDecisionTool } from './tools/log-idea-decision.js'
|
||||
import { registerGetWorkerSettingsTool } from './tools/get-worker-settings.js'
|
||||
import { registerWorkerHeartbeatTool } from './tools/worker-heartbeat.js'
|
||||
|
|
@ -80,9 +77,6 @@ async function main() {
|
|||
registerCreatePbiTool(server)
|
||||
registerCreateStoryTool(server)
|
||||
registerCreateTaskTool(server)
|
||||
// PBI-12: sprint lifecycle tools
|
||||
registerCreateSprintTool(server)
|
||||
registerUpdateSprintTool(server)
|
||||
registerAskUserQuestionTool(server)
|
||||
registerGetQuestionAnswerTool(server)
|
||||
registerListOpenQuestionsTool(server)
|
||||
|
|
@ -98,7 +92,6 @@ async function main() {
|
|||
registerGetIdeaContextTool(server)
|
||||
registerUpdateIdeaGrillMdTool(server)
|
||||
registerUpdateIdeaPlanMdTool(server)
|
||||
registerUpdateIdeaPlanReviewedTool(server)
|
||||
registerLogIdeaDecisionTool(server)
|
||||
// M13: worker quota-gate tools
|
||||
registerGetWorkerSettingsTool(server)
|
||||
|
|
|
|||
|
|
@ -101,19 +101,6 @@ const KIND_DEFAULTS: Record<string, JobConfig> = {
|
|||
'mcp__scrum4me__update_job_status',
|
||||
],
|
||||
},
|
||||
IDEA_REVIEW_PLAN: {
|
||||
model: 'claude-opus-4-7',
|
||||
thinking_budget: 6000,
|
||||
permission_mode: 'acceptEdits',
|
||||
max_turns: 1,
|
||||
allowed_tools: [
|
||||
'Read', 'Write', 'Grep', 'Glob',
|
||||
'mcp__scrum4me__update_idea_plan_reviewed',
|
||||
'mcp__scrum4me__log_idea_decision',
|
||||
'mcp__scrum4me__update_job_status',
|
||||
'mcp__scrum4me__ask_user_question',
|
||||
],
|
||||
},
|
||||
PLAN_CHAT: {
|
||||
model: 'claude-sonnet-4-6',
|
||||
thinking_budget: 6000,
|
||||
|
|
|
|||
|
|
@ -25,7 +25,6 @@ function loadPrompt(rel: string): string {
|
|||
const KIND_TO_PROMPT_PATH: Partial<Record<ClaudeJobKind, string>> = {
|
||||
IDEA_GRILL: 'idea/grill.md',
|
||||
IDEA_MAKE_PLAN: 'idea/make-plan.md',
|
||||
IDEA_REVIEW_PLAN: 'idea/review-plan.md',
|
||||
TASK_IMPLEMENTATION: 'task/implementation.md',
|
||||
SPRINT_IMPLEMENTATION: 'sprint/implementation.md',
|
||||
PLAN_CHAT: 'plan-chat/chat.md',
|
||||
|
|
@ -41,9 +40,9 @@ export function getKindPromptText(kind: ClaudeJobKind): string {
|
|||
}
|
||||
|
||||
// Back-compat re-export. wait-for-job.ts roept getIdeaPromptText aan voor
|
||||
// de drie idea-kinds; behouden zodat we de bestaande call-site niet hoeven
|
||||
// de twee idea-kinds; behouden zodat we de bestaande call-site niet hoeven
|
||||
// te wijzigen tot een aparte cleanup-pass.
|
||||
export function getIdeaPromptText(kind: ClaudeJobKind): string {
|
||||
if (kind !== 'IDEA_GRILL' && kind !== 'IDEA_MAKE_PLAN' && kind !== 'IDEA_REVIEW_PLAN') return ''
|
||||
if (kind !== 'IDEA_GRILL' && kind !== 'IDEA_MAKE_PLAN') return ''
|
||||
return getKindPromptText(kind)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,210 +0,0 @@
|
|||
# Review-Plan-prompt voor IDEA_REVIEW_PLAN-jobs
|
||||
|
||||
> Deze prompt wordt door `wait_for_job` meegestuurd in de payload van een
|
||||
> `IDEA_REVIEW_PLAN`-job. Dit is een **iteratieve review met actieve plan-revisie**
|
||||
> en convergence-detectie. Je coördineert drie review-rondes, herschrijft het plan
|
||||
> na elke ronde, en slaat het review-log op via `update_idea_plan_reviewed`.
|
||||
|
||||
---
|
||||
|
||||
Je bent een **plan-review-orchestrator** voor Scrum4Me-idee `{idea_code}`.
|
||||
|
||||
Je context (meegegeven in `wait_for_job`-payload):
|
||||
|
||||
- `idea.plan_md`: het te reviewen plan-document (YAML frontmatter + body)
|
||||
- `idea.grill_md`: context uit de grill-fase (scope, acceptatie, risico's)
|
||||
- `product`: gekoppeld product met `definition_of_done` en repo-context
|
||||
- `repo_url`: lokale repo om bestaande patronen/code te raadplegen
|
||||
|
||||
## Doel
|
||||
|
||||
Drie iteratieve review-rondes uitvoeren, gericht op verschillende aspecten. Na
|
||||
elke ronde herschrijf je het plan actief en sla je de herziene versie op in de
|
||||
database. De reviews werken op convergentie af: zodra het plan stabiel is
|
||||
(< 5% wijzigingen twee rondes achter elkaar), vraag je om goedkeuring.
|
||||
|
||||
**Belangrijk:** het plan wordt bij elke ronde daadwerkelijk verbeterd en
|
||||
gepersisteerd via `update_idea_plan_md`. Dit is geen passieve review — je
|
||||
coördineert een actief verbeterproces.
|
||||
|
||||
## Werkwijze
|
||||
|
||||
### Setup (voor ronde 1)
|
||||
|
||||
1. Lees `idea.plan_md` volledig — dit is de startversie van het plan.
|
||||
2. Lees `idea.grill_md` voor scope/acceptatiecriteria-context.
|
||||
3. **Laad codex** (verplicht, niet optioneel):
|
||||
- Glob + Read alle `docs/patterns/**/*.md` → architectuurpatronen
|
||||
- Glob + Read alle `docs/architecture/**/*.md` → systeemdesign
|
||||
- Read `CLAUDE.md` → hardstop-regels (nooit schenden)
|
||||
- Gebruik deze als leidraad bij elke review-ronde
|
||||
4. Initialiseer `review_log`:
|
||||
```json
|
||||
{ "plan_file": "{idea_code}", "created_at": "<now>",
|
||||
"rounds": [], "approval": { "status": "pending" } }
|
||||
```
|
||||
|
||||
### Per Review-Ronde
|
||||
|
||||
**Ronde 1 — Structuur & Syntax (Haiku-perspectief: snel en scherp)**
|
||||
- Rol: structuur-reviewer — focus op correctheid, niet op inhoud
|
||||
- Controleer: YAML parseable, alle verplichte velden aanwezig, geen lege strings,
|
||||
priority-waarden valid (1–4), markdown-structuur intact
|
||||
- Herschrijf plan_md: corrigeer structuurfouten en formatting
|
||||
- *Opmerking multi-model:* directe Haiku API-call is momenteel niet beschikbaar
|
||||
via job-config; voer deze rol zelf uit met een compacte, syntax-gerichte blik
|
||||
|
||||
**Ronde 2 — Logica & Patronen (Sonnet-perspectief: diep en patroon-bewust)**
|
||||
- Rol: architectuur-reviewer — focus op logica, volledigheid en patroonconformiteit
|
||||
- Controleer: stories volgen uit grill-criteria, tasks zijn concreet
|
||||
(bestandsnamen, commando's), patterns uit `docs/patterns/` worden gevolgd,
|
||||
`verify_required` coherent, dependency-cascades geadresseerd
|
||||
- Herschrijf plan_md: vul gaten aan, maak tasks specifieker, voeg missende stappen toe
|
||||
|
||||
**Ronde 3 — Risico & Edge Cases (Opus-perspectief: kritisch en breed)**
|
||||
- Rol: risico-reviewer — focus op wat mis kan gaan
|
||||
- Controleer: grote taken gesplitst, refactors hebben undo-strategie,
|
||||
schema-changes hebben migratie-taken, type-checking expliciet, concurrency
|
||||
geadresseerd, error-handling per actie, feature-flags voor grote changes
|
||||
- Herschrijf plan_md: voeg risico-mitigatie toe, split te grote taken
|
||||
|
||||
### Plan Revision (na elke ronde — verplicht)
|
||||
|
||||
Na het uitvoeren van de review-criteria:
|
||||
|
||||
1. Sla de huidige versie op als `plan_before` in `review_log.rounds[N]`.
|
||||
2. Herschrijf `plan_md` — integreer de gevonden verbeteringen.
|
||||
3. Bereken `diff_pct = changed_lines / total_lines * 100`.
|
||||
4. Sla de herziene versie op als `plan_after` in `review_log.rounds[N]`.
|
||||
5. **Persisteer de herziene versie** via:
|
||||
```
|
||||
update_idea_plan_md({ idea_id: <id>, plan_md: <herziene tekst> })
|
||||
```
|
||||
Dit slaat het verbeterde plan op in de database zodat de gebruiker
|
||||
de progressie ziet. Sla dit stap niet over — ook al zijn er weinig
|
||||
wijzigingen.
|
||||
|
||||
### Convergence Detection
|
||||
|
||||
Na elke ronde (m.u.v. ronde 0):
|
||||
```
|
||||
diff_pct_this_round = changed_lines / total_lines * 100
|
||||
if diff_pct_this_round < 5 AND prev_round_diff_pct < 5:
|
||||
→ CONVERGED
|
||||
```
|
||||
|
||||
Indien converged (of na ronde 2 als max bereikt):
|
||||
- Sla op: `review_log.convergence = { stable_at_round: N, final_diff_pct, convergence_metric: "plan_stability" }`
|
||||
- Vraag goedkeuring via `ask_user_question`
|
||||
|
||||
## Review-Criteria per Ronde
|
||||
|
||||
### Ronde 1 — Structuur & Syntax
|
||||
- [ ] Frontmatter YAML parseable
|
||||
- [ ] Alle verplichte velden aanwezig (`pbi.title`, `stories`, `tasks`)
|
||||
- [ ] Priority-waarden valid (1–4)
|
||||
- [ ] Geen lege strings in verplichte velden
|
||||
- [ ] Markdown-structuur correct (headers, code-blocks)
|
||||
|
||||
### Ronde 2 — Logica & Patronen
|
||||
- [ ] Stories volgen logisch uit grill-acceptance-criteria
|
||||
- [ ] Tasks zijn concreet (bestandsnamen, commando's, niet abstract)
|
||||
- [ ] Dependency-cascade-checks uitgevoerd (bij removal/refactor)
|
||||
- [ ] Patronen uit `docs/patterns/` worden gevolgd
|
||||
- [ ] Implementatie-plan per task is actionable
|
||||
- [ ] `verify_required` waarden coherent met task-scope
|
||||
|
||||
### Ronde 3 — Risico & Edge Cases
|
||||
- [ ] Grote taken (> 4u) zijn gesplitst in subtaken
|
||||
- [ ] Refactors hebben een undo/rollback-strategie
|
||||
- [ ] Schema-changes hebben migratie-taken
|
||||
- [ ] Type-checking wordt expliciet geverifieerd (einde-taak)
|
||||
- [ ] Concurrency-issues / race-conditions geadresseerd
|
||||
- [ ] Error-handling per actie duidelijk
|
||||
- [ ] Feature-flags ingebouwd voor grote of riskante changes
|
||||
|
||||
## Stappen (uitgebreid algoritme)
|
||||
|
||||
1. **Init**
|
||||
- Lees plan_md + grill_md.
|
||||
- Laad codex (docs/patterns, docs/architecture, CLAUDE.md).
|
||||
- Initialiseer `review_log`.
|
||||
|
||||
2. **Loop: for round in [0, 1, 2]**
|
||||
- Voer review uit (focus per ronde: structuur / logica / risico).
|
||||
- Sla `plan_before` op.
|
||||
- Herschrijf plan_md op basis van bevindingen.
|
||||
- Roep `update_idea_plan_md` aan met de herziene tekst.
|
||||
- Sla `plan_after` + `issues` + `score` + `diff_pct` op in review_log.
|
||||
- Check convergence (na ronde 1+).
|
||||
- Break indien converged.
|
||||
|
||||
3. **Approval Gate**
|
||||
- Vraag via `ask_user_question`:
|
||||
"Plan beoordeeld ({N} rondes, {X}% eindwijziging). Goedkeuren?"
|
||||
- Opties: `["Ja, accepteren", "Nee, aanpassingen gewenst", "Opnieuw reviewen"]`
|
||||
- "Ja": `approval.status = 'approved'` → ga door naar Save & Close.
|
||||
- "Nee": `approval.status = 'rejected'` → sluit af (user kan handmatig editen).
|
||||
- "Opnieuw": max 2 extra rondes (rondes 3–4), dan dwingend approval vragen.
|
||||
|
||||
4. **Save & Close**
|
||||
- Call `update_idea_plan_reviewed({ idea_id, review_log, approval_status })`.
|
||||
- Call `update_job_status({ job_id, status: 'done', summary: review_log.summary })`.
|
||||
|
||||
## Output-format review_log (strikt JSON)
|
||||
|
||||
```json
|
||||
{
|
||||
"plan_file": "IDEA-016",
|
||||
"created_at": "ISO8601",
|
||||
"rounds": [
|
||||
{
|
||||
"round": 0,
|
||||
"model": "claude-opus-4-7",
|
||||
"role": "Structure Review",
|
||||
"focus": "YAML parsing, format, syntax",
|
||||
"plan_before": "<origineel plan_md>",
|
||||
"plan_after": "<herzien plan_md na ronde>",
|
||||
"issues": [
|
||||
{
|
||||
"category": "structure|logic|risk|pattern",
|
||||
"severity": "error|warning|info",
|
||||
"suggestion": "wat te fixen"
|
||||
}
|
||||
],
|
||||
"score": 75,
|
||||
"plan_diff_lines": 12,
|
||||
"converged": false,
|
||||
"timestamp": "ISO8601"
|
||||
}
|
||||
],
|
||||
"convergence": {
|
||||
"stable_at_round": 2,
|
||||
"final_diff_pct": 2.1,
|
||||
"convergence_metric": "plan_stability"
|
||||
},
|
||||
"approval": {
|
||||
"status": "pending|approved|rejected",
|
||||
"timestamp": "ISO8601"
|
||||
},
|
||||
"summary": "1–2 zinnen samenvatting: X rondes, Y% wijziging, status"
|
||||
}
|
||||
```
|
||||
|
||||
## Foutgevallen
|
||||
|
||||
- **Plan parse-fout**: `update_job_status('failed', error: 'plan_parse_failed')` — stop.
|
||||
- **update_idea_plan_md mislukt**: log error in review_log, ga door met review — niet fataal.
|
||||
- **Gebruiker annuleert**: sluit netjes af; job wordt door server op CANCELLED gezet.
|
||||
- **Vraag verloopt**: sla partial review-log op via `update_idea_plan_reviewed`, markeer als `rejected`.
|
||||
|
||||
## Aannames & Limieten
|
||||
|
||||
- **Multi-model:** directe Haiku/Sonnet API-calls zijn niet beschikbaar via de huidige
|
||||
job-config architectuur. Alle rondes draaien op het geconfigureerde Opus model.
|
||||
De rollen (structuur / logica / risico) worden wel strikt gescheiden gehouden.
|
||||
Toekomst: directe model-switching via Anthropic API.
|
||||
- Plan bevat geen versleutelde data (review-log opgeslagen als JSON in DB).
|
||||
- Repo is leesbaar; geen network-fouts verwacht.
|
||||
- Max 2 extra review-rondes buiten de initiële 3 (max 5 rondes totaal).
|
||||
- Per ronde: max 10 issues gelogd (overige → samenvatting in `summary`).
|
||||
|
|
@ -1,113 +0,0 @@
|
|||
// MCP authoring tool: create een Sprint binnen een product.
|
||||
//
|
||||
// Status start altijd op OPEN; geen reuse-check op bestaande OPEN-sprints
|
||||
// (per plan-to-pbi-flow.md "altijd nieuwe sprint"). Code wordt auto-gegenereerd
|
||||
// als S-{YYYY-MM-DD}-{N} per product per datum, met retry bij race-condition
|
||||
// op de unique constraint (@@unique([product_id, code])).
|
||||
|
||||
import { z } from 'zod'
|
||||
import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js'
|
||||
import { Prisma } from '@prisma/client'
|
||||
import { prisma } from '../prisma.js'
|
||||
import { requireWriteAccess } from '../auth.js'
|
||||
import { userCanAccessProduct } from '../access.js'
|
||||
import { toolError, toolJson, withToolErrors } from '../errors.js'
|
||||
|
||||
const SPRINT_AUTO_RE = /^S-(\d{4}-\d{2}-\d{2})-(\d+)$/
|
||||
const MAX_CODE_ATTEMPTS = 3
|
||||
|
||||
function todayIsoDate(): string {
|
||||
return new Date().toISOString().slice(0, 10)
|
||||
}
|
||||
|
||||
async function generateNextSprintCode(productId: string): Promise<string> {
|
||||
const today = todayIsoDate()
|
||||
const sprints = await prisma.sprint.findMany({
|
||||
where: { product_id: productId, code: { startsWith: `S-${today}-` } },
|
||||
select: { code: true },
|
||||
})
|
||||
let max = 0
|
||||
for (const s of sprints) {
|
||||
const m = s.code?.match(SPRINT_AUTO_RE)
|
||||
// Dubbele check op de datum — defensive tegen filterveranderingen
|
||||
// of mock-data die niet door de DB-where heen ging.
|
||||
if (m && m[1] === today) {
|
||||
const n = Number.parseInt(m[2], 10)
|
||||
if (!Number.isNaN(n) && n > max) max = n
|
||||
}
|
||||
}
|
||||
return `S-${today}-${max + 1}`
|
||||
}
|
||||
|
||||
function isCodeUniqueConflict(error: unknown): boolean {
|
||||
if (!(error instanceof Prisma.PrismaClientKnownRequestError)) return false
|
||||
if (error.code !== 'P2002') return false
|
||||
const target = (error.meta as { target?: string[] | string } | undefined)?.target
|
||||
if (!target) return false
|
||||
return Array.isArray(target) ? target.includes('code') : target.includes('code')
|
||||
}
|
||||
|
||||
export const inputSchema = z.object({
|
||||
product_id: z.string().min(1),
|
||||
code: z.string().min(1).max(30).optional(),
|
||||
sprint_goal: z.string().min(1).max(500),
|
||||
start_date: z.string().date().optional(),
|
||||
})
|
||||
|
||||
export async function handleCreateSprint(
|
||||
{ product_id, code, sprint_goal, start_date }: z.infer<typeof inputSchema>,
|
||||
) {
|
||||
return withToolErrors(async () => {
|
||||
const auth = await requireWriteAccess()
|
||||
if (!(await userCanAccessProduct(product_id, auth.userId))) {
|
||||
return toolError(`Product ${product_id} not found or not accessible`)
|
||||
}
|
||||
|
||||
const resolvedStartDate = start_date ? new Date(start_date) : new Date()
|
||||
const baseSelect = {
|
||||
id: true,
|
||||
code: true,
|
||||
sprint_goal: true,
|
||||
status: true,
|
||||
start_date: true,
|
||||
created_at: true,
|
||||
} as const
|
||||
|
||||
if (code) {
|
||||
const sprint = await prisma.sprint.create({
|
||||
data: { product_id, code, sprint_goal, status: 'OPEN', start_date: resolvedStartDate },
|
||||
select: baseSelect,
|
||||
})
|
||||
return toolJson(sprint)
|
||||
}
|
||||
|
||||
let lastError: unknown
|
||||
for (let attempt = 0; attempt < MAX_CODE_ATTEMPTS; attempt++) {
|
||||
const generated = await generateNextSprintCode(product_id)
|
||||
try {
|
||||
const sprint = await prisma.sprint.create({
|
||||
data: { product_id, code: generated, sprint_goal, status: 'OPEN', start_date: resolvedStartDate },
|
||||
select: baseSelect,
|
||||
})
|
||||
return toolJson(sprint)
|
||||
} catch (e) {
|
||||
if (isCodeUniqueConflict(e)) { lastError = e; continue }
|
||||
throw e
|
||||
}
|
||||
}
|
||||
throw lastError ?? new Error('Kon geen unieke sprint-code genereren')
|
||||
})
|
||||
}
|
||||
|
||||
export function registerCreateSprintTool(server: McpServer) {
|
||||
server.registerTool(
|
||||
'create_sprint',
|
||||
{
|
||||
title: 'Create Sprint',
|
||||
description:
|
||||
'Create a new sprint for a product with status=OPEN. Code auto-generated as S-{YYYY-MM-DD}-{N} per product per date if not provided. Forbidden for demo accounts.',
|
||||
inputSchema,
|
||||
},
|
||||
handleCreateSprint,
|
||||
)
|
||||
}
|
||||
|
|
@ -1,9 +1,8 @@
|
|||
// MCP authoring tool: create een Story onder een bestaande PBI.
|
||||
//
|
||||
// product_id wordt afgeleid uit de PBI (denormalized FK conform CLAUDE.md
|
||||
// convention — nooit vertrouwen op client-input). Zonder sprint_id is
|
||||
// status='OPEN' en landt de story in de Product Backlog; mét sprint_id
|
||||
// wordt de story direct aan die sprint gekoppeld (status='IN_SPRINT').
|
||||
// convention — nooit vertrouwen op client-input). status='OPEN' default;
|
||||
// landt in de Product Backlog, niet auto in een sprint.
|
||||
|
||||
import { z } from 'zod'
|
||||
import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js'
|
||||
|
|
@ -47,23 +46,19 @@ const inputSchema = z.object({
|
|||
acceptance_criteria: z.string().max(4000).optional(),
|
||||
priority: z.number().int().min(1).max(4),
|
||||
sort_order: z.number().optional(),
|
||||
// Optionele sprint-koppeling: bij creatie de story direct aan een sprint
|
||||
// hangen (status=IN_SPRINT). De sprint moet bij hetzelfde product horen.
|
||||
sprint_id: z.string().min(1).optional(),
|
||||
})
|
||||
|
||||
export async function handleCreateStory(
|
||||
export function registerCreateStoryTool(server: McpServer) {
|
||||
server.registerTool(
|
||||
'create_story',
|
||||
{
|
||||
pbi_id,
|
||||
title,
|
||||
description,
|
||||
acceptance_criteria,
|
||||
priority,
|
||||
sort_order,
|
||||
sprint_id,
|
||||
}: z.infer<typeof inputSchema>,
|
||||
) {
|
||||
return withToolErrors(async () => {
|
||||
title: 'Create story',
|
||||
description:
|
||||
'Add a story under an existing PBI. Status defaults to OPEN (lands in product backlog, not in a sprint). Sort_order auto-set to last+1 within the PBI/priority group if not provided. Forbidden for demo accounts.',
|
||||
inputSchema,
|
||||
},
|
||||
async ({ pbi_id, title, description, acceptance_criteria, priority, sort_order }) =>
|
||||
withToolErrors(async () => {
|
||||
const auth = await requireWriteAccess()
|
||||
|
||||
const pbi = await prisma.pbi.findUnique({
|
||||
|
|
@ -75,21 +70,6 @@ export async function handleCreateStory(
|
|||
return toolError(`PBI ${pbi_id} not accessible`)
|
||||
}
|
||||
|
||||
// Optionele sprint-koppeling: valideer dat de sprint bestaat én bij
|
||||
// hetzelfde product hoort — voorkomt een cross-product koppeling.
|
||||
if (sprint_id !== undefined) {
|
||||
const sprint = await prisma.sprint.findUnique({
|
||||
where: { id: sprint_id },
|
||||
select: { product_id: true },
|
||||
})
|
||||
if (!sprint) return toolError(`Sprint ${sprint_id} not found`)
|
||||
if (sprint.product_id !== pbi.product_id) {
|
||||
return toolError(
|
||||
`Sprint ${sprint_id} belongs to a different product than PBI ${pbi_id}`,
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
let resolvedSortOrder = sort_order
|
||||
if (resolvedSortOrder === undefined) {
|
||||
const last = await prisma.story.findFirst({
|
||||
|
|
@ -108,14 +88,13 @@ export async function handleCreateStory(
|
|||
data: {
|
||||
pbi_id,
|
||||
product_id: pbi.product_id, // denormalized uit DB-parent, niet uit input
|
||||
sprint_id: sprint_id ?? null,
|
||||
code,
|
||||
title,
|
||||
description: description ?? null,
|
||||
acceptance_criteria: acceptance_criteria ?? null,
|
||||
priority,
|
||||
sort_order: resolvedSortOrder,
|
||||
status: sprint_id ? 'IN_SPRINT' : 'OPEN',
|
||||
status: 'OPEN',
|
||||
},
|
||||
select: {
|
||||
id: true,
|
||||
|
|
@ -126,7 +105,6 @@ export async function handleCreateStory(
|
|||
priority: true,
|
||||
sort_order: true,
|
||||
status: true,
|
||||
sprint_id: true,
|
||||
created_at: true,
|
||||
},
|
||||
})
|
||||
|
|
@ -137,18 +115,6 @@ export async function handleCreateStory(
|
|||
}
|
||||
}
|
||||
throw lastError ?? new Error('Kon geen unieke Story-code genereren')
|
||||
})
|
||||
}
|
||||
|
||||
export function registerCreateStoryTool(server: McpServer) {
|
||||
server.registerTool(
|
||||
'create_story',
|
||||
{
|
||||
title: 'Create story',
|
||||
description:
|
||||
'Add a story under an existing PBI. Optionally link it to a sprint via sprint_id — when given, the story is created with status=IN_SPRINT and the sprint must belong to the same product as the PBI; otherwise status=OPEN and the story lands in the product backlog. Sort_order auto-set to last+1 within the PBI/priority group if not provided. Forbidden for demo accounts.',
|
||||
inputSchema,
|
||||
},
|
||||
handleCreateStory,
|
||||
}),
|
||||
)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,126 +0,0 @@
|
|||
// MCP-tool: writes the review-log result after an IDEA_REVIEW_PLAN job and
|
||||
// transitions idea.status. Only an explicit approval_status='approved' moves
|
||||
// the idea to PLAN_REVIEWED; anything else (rejected, pending, or omitted)
|
||||
// goes to PLAN_REVIEW_FAILED — a human must then decide. The tool never
|
||||
// silently approves.
|
||||
//
|
||||
// Called by the worker as the final step of a review-plan session.
|
||||
|
||||
import { z } from 'zod'
|
||||
import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js'
|
||||
|
||||
import { prisma } from '../prisma.js'
|
||||
import { requireWriteAccess } from '../auth.js'
|
||||
import { userOwnsIdea } from '../access.js'
|
||||
import { toolError, toolJson, withToolErrors } from '../errors.js'
|
||||
|
||||
export const inputSchema = z.object({
|
||||
idea_id: z.string().min(1),
|
||||
review_log: z.object({}).passthrough(), // Full ReviewLog from orchestrator (JSON object)
|
||||
approval_status: z
|
||||
.enum(['pending', 'approved', 'rejected'] as const)
|
||||
.optional(),
|
||||
})
|
||||
|
||||
export async function handleUpdateIdeaPlanReviewed(
|
||||
{ idea_id, review_log, approval_status }: z.infer<typeof inputSchema>,
|
||||
) {
|
||||
return withToolErrors(async () => {
|
||||
const auth = await requireWriteAccess()
|
||||
if (!(await userOwnsIdea(idea_id, auth.userId))) {
|
||||
return toolError('Idea not found')
|
||||
}
|
||||
|
||||
// Alleen een expliciete 'approved' brengt het idee naar PLAN_REVIEWED.
|
||||
// 'rejected', 'pending' én een weggelaten approval_status betekenen
|
||||
// allemaal "niet auto-goedgekeurd — mens moet beslissen" en gaan naar
|
||||
// PLAN_REVIEW_FAILED. Nooit stilzwijgend goedkeuren (de vorige
|
||||
// `: 'PLAN_REVIEWED'`-default deed dat wel bij pending/undefined).
|
||||
const nextStatus =
|
||||
approval_status === 'approved' ? 'PLAN_REVIEWED' : 'PLAN_REVIEW_FAILED'
|
||||
|
||||
// Log summary metrics from review_log
|
||||
const logSummary = buildReviewLogSummary(review_log)
|
||||
|
||||
const result = await prisma.$transaction([
|
||||
prisma.idea.update({
|
||||
where: { id: idea_id },
|
||||
data: {
|
||||
plan_review_log: review_log as any,
|
||||
reviewed_at: new Date(),
|
||||
status: nextStatus,
|
||||
},
|
||||
select: { id: true, status: true, code: true },
|
||||
}),
|
||||
prisma.ideaLog.create({
|
||||
data: {
|
||||
idea_id,
|
||||
type: 'PLAN_REVIEW_RESULT',
|
||||
content: logSummary.summary,
|
||||
metadata: {
|
||||
approval_status,
|
||||
convergence_status: logSummary.convergence_status,
|
||||
final_score: logSummary.final_score,
|
||||
rounds_completed: logSummary.rounds_completed,
|
||||
},
|
||||
},
|
||||
}),
|
||||
])
|
||||
|
||||
return toolJson({
|
||||
ok: true,
|
||||
idea: result[0],
|
||||
review_log_summary: logSummary,
|
||||
})
|
||||
})
|
||||
}
|
||||
|
||||
export function registerUpdateIdeaPlanReviewedTool(server: McpServer) {
|
||||
server.registerTool(
|
||||
'update_idea_plan_reviewed',
|
||||
{
|
||||
title: 'Mark plan as reviewed',
|
||||
description:
|
||||
'Save review-log after a plan review cycle and transition idea.status. ' +
|
||||
'Only approval_status="approved" → PLAN_REVIEWED; "rejected", "pending", ' +
|
||||
'or an omitted approval_status → PLAN_REVIEW_FAILED (needs manual ' +
|
||||
'approval — never silently approved). Forbidden for demo accounts.',
|
||||
inputSchema,
|
||||
},
|
||||
handleUpdateIdeaPlanReviewed,
|
||||
)
|
||||
}
|
||||
|
||||
function buildReviewLogSummary(
|
||||
reviewLog: Record<string, any>,
|
||||
): {
|
||||
summary: string
|
||||
convergence_status: string
|
||||
final_score: number
|
||||
rounds_completed: number
|
||||
} {
|
||||
const rounds = Array.isArray(reviewLog.rounds) ? reviewLog.rounds : []
|
||||
const convergence = reviewLog.convergence || {}
|
||||
const finalScore =
|
||||
rounds.length > 0 ? rounds[rounds.length - 1].score ?? 0 : 0
|
||||
|
||||
const convergenceStatus =
|
||||
convergence.stable_at_round !== undefined
|
||||
? `stable at round ${convergence.stable_at_round}`
|
||||
: convergence.final_diff_pct !== undefined
|
||||
? `${convergence.final_diff_pct}% diff`
|
||||
: 'pending'
|
||||
|
||||
const summary =
|
||||
`Plan reviewed in ${rounds.length} rounds. ` +
|
||||
`Convergence: ${convergenceStatus}. ` +
|
||||
`Final score: ${finalScore}/100. ` +
|
||||
`Status: ${reviewLog.approval?.status || 'pending'}.`
|
||||
|
||||
return {
|
||||
summary,
|
||||
convergence_status: convergenceStatus,
|
||||
final_score: finalScore,
|
||||
rounds_completed: rounds.length,
|
||||
}
|
||||
}
|
||||
|
|
@ -390,32 +390,6 @@ export function resolveNextAction(
|
|||
return queueCount > 0 ? 'wait_for_job_again' : 'queue_empty'
|
||||
}
|
||||
|
||||
export type JobTimestampUpdate = {
|
||||
claimed_at?: Date
|
||||
started_at?: Date
|
||||
finished_at?: Date
|
||||
}
|
||||
|
||||
// Bepaalt welke lifecycle-timestamps update_job_status schrijft bij een
|
||||
// status-overgang. Set-once (backfill alleen als nu null) houdt de invariant
|
||||
// claimed_at ≤ started_at ≤ finished_at: een job die CLAIMED → done gaat
|
||||
// zonder `running`-rapport krijgt alsnog een started_at, en claimed_at
|
||||
// (normaal door wait_for_job bij claim gezet) wordt nooit overschreven.
|
||||
export function resolveJobTimestamps(
|
||||
status: 'running' | 'done' | 'failed' | 'skipped',
|
||||
current: { claimed_at: Date | null; started_at: Date | null },
|
||||
now: Date = new Date(),
|
||||
): JobTimestampUpdate {
|
||||
const isTerminal = status === 'done' || status === 'failed' || status === 'skipped'
|
||||
const update: JobTimestampUpdate = {}
|
||||
if (current.claimed_at == null) update.claimed_at = now
|
||||
if (current.started_at == null && (status === 'running' || isTerminal)) {
|
||||
update.started_at = now
|
||||
}
|
||||
if (isTerminal) update.finished_at = now
|
||||
return update
|
||||
}
|
||||
|
||||
export async function maybeCreateAutoPr(opts: {
|
||||
jobId: string
|
||||
productId: string
|
||||
|
|
@ -446,35 +420,24 @@ export async function maybeCreateAutoPr(opts: {
|
|||
where: { id: taskId },
|
||||
select: {
|
||||
title: true,
|
||||
repo_url: true,
|
||||
story: { select: { id: true, code: true, title: true } },
|
||||
},
|
||||
})
|
||||
if (!task) return null
|
||||
|
||||
// Cross-repo sprints: een sprint kan taken hebben die via task.repo_url een
|
||||
// ander repo targeten. PRs en branches zijn per-repo, dus een sibling-PR mag
|
||||
// alleen hergebruikt worden als die sibling hetzelfde repo targette. null/leeg
|
||||
// repo_url = het product-repo; twee taken zitten in dezelfde repo-bucket als
|
||||
// hun (repo_url ?? null) gelijk is.
|
||||
const thisRepoKey = task.repo_url ?? null
|
||||
|
||||
// PBI-46 SPRINT-mode: hergebruik 1 draft-PR voor de hele SprintRun (per repo).
|
||||
// PBI-46 SPRINT-mode: hergebruik 1 draft-PR voor de hele SprintRun.
|
||||
// Mens zet 'm ready-for-review zodra de SprintRun DONE is.
|
||||
if (job?.sprint_run && job.sprint_run.pr_strategy === 'SPRINT') {
|
||||
const sprintSiblings = await prisma.claudeJob.findMany({
|
||||
const sprintSibling = await prisma.claudeJob.findFirst({
|
||||
where: {
|
||||
sprint_run_id: job.sprint_run_id,
|
||||
pr_url: { not: null },
|
||||
id: { not: jobId },
|
||||
},
|
||||
select: { pr_url: true, task: { select: { repo_url: true } } },
|
||||
select: { pr_url: true },
|
||||
orderBy: { created_at: 'asc' },
|
||||
})
|
||||
const sameRepoSibling = sprintSiblings.find(
|
||||
(s) => (s.task?.repo_url ?? null) === thisRepoKey,
|
||||
)
|
||||
if (sameRepoSibling?.pr_url) return sameRepoSibling.pr_url
|
||||
if (sprintSibling?.pr_url) return sprintSibling.pr_url
|
||||
|
||||
// Eerste DONE in deze SprintRun → maak draft-PR aan, geen auto-merge.
|
||||
const goal = job.sprint_run.sprint.sprint_goal
|
||||
|
|
@ -496,21 +459,17 @@ export async function maybeCreateAutoPr(opts: {
|
|||
return null
|
||||
}
|
||||
|
||||
// STORY-mode (default of legacy): branch-per-story, sibling-tasks delen PR
|
||||
// — maar alleen siblings die hetzelfde repo targeten (zie thisRepoKey).
|
||||
const storySiblings = await prisma.claudeJob.findMany({
|
||||
// STORY-mode (default of legacy): branch-per-story, sibling-tasks delen PR.
|
||||
const sibling = await prisma.claudeJob.findFirst({
|
||||
where: {
|
||||
task: { story_id: task.story.id },
|
||||
pr_url: { not: null },
|
||||
id: { not: jobId },
|
||||
},
|
||||
select: { pr_url: true, task: { select: { repo_url: true } } },
|
||||
select: { pr_url: true },
|
||||
orderBy: { created_at: 'asc' },
|
||||
})
|
||||
const sameRepoStorySibling = storySiblings.find(
|
||||
(s) => (s.task?.repo_url ?? null) === thisRepoKey,
|
||||
)
|
||||
if (sameRepoStorySibling?.pr_url) return sameRepoStorySibling.pr_url
|
||||
if (sibling?.pr_url) return sibling.pr_url
|
||||
|
||||
const storyTitle = task.story.code ? `${task.story.code}: ${task.story.title}` : task.story.title
|
||||
const body = summary
|
||||
|
|
@ -595,8 +554,6 @@ export function registerUpdateJobStatusTool(server: McpServer) {
|
|||
'Report progress on a claimed ClaudeJob. Allowed transitions from CLAIMED/RUNNING: ' +
|
||||
'running (start), done (finished), failed (error), skipped (no-op exit). ' +
|
||||
'The Bearer token must match the token that claimed the job. ' +
|
||||
'Stamps started_at on running and finished_at on done/failed/skipped, and backfills ' +
|
||||
'claimed_at/started_at when missing so claimed_at ≤ started_at ≤ finished_at always holds. ' +
|
||||
'Before marking done: call verify_task_against_plan first — done is rejected when ' +
|
||||
'verify_result is null, EMPTY (unless task.verify_only is true), or when the verify level ' +
|
||||
'doesn’t meet task.verify_required: ALIGNED-only is strict; ALIGNED_OR_PARTIAL accepts ' +
|
||||
|
|
@ -636,8 +593,6 @@ export function registerUpdateJobStatusTool(server: McpServer) {
|
|||
select: {
|
||||
id: true,
|
||||
status: true,
|
||||
claimed_at: true,
|
||||
started_at: true,
|
||||
claimed_by_token_id: true,
|
||||
user_id: true,
|
||||
product_id: true,
|
||||
|
|
@ -781,11 +736,10 @@ export function registerUpdateJobStatusTool(server: McpServer) {
|
|||
where: { id: job_id },
|
||||
data: {
|
||||
status: dbStatus,
|
||||
...resolveJobTimestamps(
|
||||
actualStatus,
|
||||
{ claimed_at: job.claimed_at, started_at: job.started_at },
|
||||
now,
|
||||
),
|
||||
...(actualStatus === 'running' ? { started_at: now } : {}),
|
||||
...(actualStatus === 'done' || actualStatus === 'failed' || actualStatus === 'skipped'
|
||||
? { finished_at: now }
|
||||
: {}),
|
||||
...(branchToWrite !== undefined ? { branch: branchToWrite } : {}),
|
||||
...(pushedAt !== undefined ? { pushed_at: pushedAt } : {}),
|
||||
...(summary !== undefined ? { summary } : {}),
|
||||
|
|
|
|||
|
|
@ -1,102 +0,0 @@
|
|||
// MCP tool: update een Sprint.
|
||||
//
|
||||
// Generieke update — wijzigt elke combinatie van status, sprint_goal,
|
||||
// start_date en end_date. Géén state-machine validatie (zie
|
||||
// docs/plans/sprint-mcp-tools.md): last-write-wins, het resubmit/heropen-pad
|
||||
// zit elders. Bij status → CLOSED/FAILED/ARCHIVED zonder expliciete end_date
|
||||
// wordt end_date automatisch op vandaag gezet. Bij status → CLOSED wordt
|
||||
// daarnaast `completed_at` op now() gezet (parity met
|
||||
// src/lib/tasks-status-update.ts dat hetzelfde doet bij auto-close via
|
||||
// task-status-cascade; zo houden reporting en UI één bron van waarheid voor
|
||||
// completion-tijd).
|
||||
|
||||
import { z } from 'zod'
|
||||
import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js'
|
||||
import type { SprintStatus } from '@prisma/client'
|
||||
import { prisma } from '../prisma.js'
|
||||
import { requireWriteAccess } from '../auth.js'
|
||||
import { userCanAccessProduct } from '../access.js'
|
||||
import { toolError, toolJson, withToolErrors } from '../errors.js'
|
||||
|
||||
const TERMINAL_STATUSES = new Set<SprintStatus>(['CLOSED', 'FAILED', 'ARCHIVED'])
|
||||
|
||||
export const inputSchema = z.object({
|
||||
sprint_id: z.string().min(1),
|
||||
status: z.enum(['OPEN', 'CLOSED', 'ARCHIVED', 'FAILED']).optional(),
|
||||
sprint_goal: z.string().min(1).max(500).optional(),
|
||||
end_date: z.string().date().optional(),
|
||||
start_date: z.string().date().optional(),
|
||||
})
|
||||
|
||||
export async function handleUpdateSprint(
|
||||
{ sprint_id, status, sprint_goal, end_date, start_date }: z.infer<typeof inputSchema>,
|
||||
) {
|
||||
return withToolErrors(async () => {
|
||||
if (
|
||||
status === undefined &&
|
||||
sprint_goal === undefined &&
|
||||
end_date === undefined &&
|
||||
start_date === undefined
|
||||
) {
|
||||
return toolError('Minstens één veld vereist om te wijzigen')
|
||||
}
|
||||
|
||||
const auth = await requireWriteAccess()
|
||||
|
||||
const sprint = await prisma.sprint.findUnique({
|
||||
where: { id: sprint_id },
|
||||
select: { id: true, product_id: true },
|
||||
})
|
||||
if (!sprint) {
|
||||
return toolError(`Sprint ${sprint_id} not found`)
|
||||
}
|
||||
if (!(await userCanAccessProduct(sprint.product_id, auth.userId))) {
|
||||
return toolError(`Sprint ${sprint_id} not accessible`)
|
||||
}
|
||||
|
||||
const data: {
|
||||
status?: SprintStatus
|
||||
sprint_goal?: string
|
||||
start_date?: Date
|
||||
end_date?: Date
|
||||
completed_at?: Date
|
||||
} = {}
|
||||
if (status !== undefined) data.status = status
|
||||
if (sprint_goal !== undefined) data.sprint_goal = sprint_goal
|
||||
if (start_date !== undefined) data.start_date = new Date(start_date)
|
||||
if (end_date !== undefined) {
|
||||
data.end_date = new Date(end_date)
|
||||
} else if (status !== undefined && TERMINAL_STATUSES.has(status)) {
|
||||
data.end_date = new Date()
|
||||
}
|
||||
if (status === 'CLOSED') data.completed_at = new Date()
|
||||
|
||||
const updated = await prisma.sprint.update({
|
||||
where: { id: sprint_id },
|
||||
data,
|
||||
select: {
|
||||
id: true,
|
||||
code: true,
|
||||
sprint_goal: true,
|
||||
status: true,
|
||||
start_date: true,
|
||||
end_date: true,
|
||||
completed_at: true,
|
||||
},
|
||||
})
|
||||
return toolJson(updated)
|
||||
})
|
||||
}
|
||||
|
||||
export function registerUpdateSprintTool(server: McpServer) {
|
||||
server.registerTool(
|
||||
'update_sprint',
|
||||
{
|
||||
title: 'Update Sprint',
|
||||
description:
|
||||
'Update a sprint: status, sprint_goal, start_date and/or end_date. At least one field required. No state-machine validation — last-write-wins. When status goes to CLOSED/FAILED/ARCHIVED and end_date is not provided, end_date is set to today. When status goes to CLOSED, completed_at is set to now (parity with auto-close via task-cascade). Forbidden for demo accounts.',
|
||||
inputSchema,
|
||||
},
|
||||
handleUpdateSprint,
|
||||
)
|
||||
}
|
||||
|
|
@ -508,7 +508,7 @@ export async function getFullJobContext(jobId: string) {
|
|||
|
||||
// M12: branch on kind. Idea-jobs hebben geen task/story/pbi/sprint; ze
|
||||
// hebben in plaats daarvan idea + embedded prompt_text.
|
||||
if (job.kind === 'IDEA_GRILL' || job.kind === 'IDEA_MAKE_PLAN' || job.kind === 'IDEA_REVIEW_PLAN') {
|
||||
if (job.kind === 'IDEA_GRILL' || job.kind === 'IDEA_MAKE_PLAN') {
|
||||
if (!job.idea) return null
|
||||
const { idea } = job
|
||||
const { getIdeaPromptText } = await import('../lib/kind-prompts.js')
|
||||
|
|
@ -569,11 +569,7 @@ export async function getFullJobContext(jobId: string) {
|
|||
pbi: idea.pbi,
|
||||
repo_url: job.product.repo_url,
|
||||
prompt_text: getIdeaPromptText(job.kind),
|
||||
branch_suggestion: `feat/idea-${idea.code.toLowerCase()}-${(() => {
|
||||
if (job.kind === 'IDEA_GRILL') return 'grill'
|
||||
if (job.kind === 'IDEA_REVIEW_PLAN') return 'review'
|
||||
return 'plan'
|
||||
})()}`,
|
||||
branch_suggestion: `feat/idea-${idea.code.toLowerCase()}-${job.kind === 'IDEA_GRILL' ? 'grill' : 'plan'}`,
|
||||
product_worktrees: worktrees.map((w) => ({
|
||||
product_id: w.productId,
|
||||
worktree_path: w.worktreePath,
|
||||
|
|
|
|||
2
vendor/scrum4me
vendored
2
vendor/scrum4me
vendored
|
|
@ -1 +1 @@
|
|||
Subproject commit 7bb252c528d810584bcb46a56cff3d26ebf392ff
|
||||
Subproject commit 3c773421dacaf506bf35a8270249822cf509ccf3
|
||||
Loading…
Add table
Add a link
Reference in a new issue