feat(max2-baseline): host_metrics read-only command (IDEA-277) #136

Merged
janpeter merged 1 commit from feat/idea-277-max2-host-metrics into master 2026-10-24 03:41:53 +02:00
Owner

IDEA-277 (Ops Dashboard, PBI-28 / ST-089 / T-235): /health comes to the max2 Ops-dashboard instance (ops2.jp-visser.nl).

Change

deploy/max2-workflows/ops-agent/baseline/commands.yml, and nothing else:

  • host_metrics: copied verbatim from Ops-dashboard deploy/ops-agent/baseline/commands.yml (main 57b1e61). It is a sudo -n call of the root-owned wrapper with read_only: true, output: text and no args.
  • read_backup_status: gets read_only: true, so the backup card stays off the legacy-mutation lease.

There are no changes to CI, to ops-agent/src or to the flows.

Classification proof

Ran from an Ops-dashboard checkout matching main 57b1e61f04e066b982e842317455c0cffb96c090 on the test file, the baseline and ops-agent/src, against this branch at ffc88f8991d60879d3c65959d30ad9c1f4c25c8a:

OPS_AGENT_EXTRA_BASELINES=<this checkout>/deploy/max2-workflows/ops-agent/baseline/commands.yml \
  npx vitest run test/host-metrics-command-classification.test.ts
  • On this branch: 7/7 passed. Both max2 cases are green: host_metrics is read-only and argument-less, and read_backup_status is read-only.
  • Negative control against master 78e7347: 2 of 7 fail, which shows the gate can catch a missing entry.

Rollout

The rollout on max2 is T-236 and is done by JP after this merge. Before it, drift should show "no drift".

🤖 Generated with Claude Code

IDEA-277 (Ops Dashboard, PBI-28 / ST-089 / T-235): `/health` comes to the max2 Ops-dashboard instance (`ops2.jp-visser.nl`). ## Change `deploy/max2-workflows/ops-agent/baseline/commands.yml`, and nothing else: - `host_metrics`: copied verbatim from Ops-dashboard `deploy/ops-agent/baseline/commands.yml` (main `57b1e61`). It is a `sudo -n` call of the root-owned wrapper with `read_only: true`, `output: text` and no args. - `read_backup_status`: gets `read_only: true`, so the backup card stays off the legacy-mutation lease. There are no changes to CI, to `ops-agent/src` or to the flows. ## Classification proof Ran from an Ops-dashboard checkout matching main `57b1e61f04e066b982e842317455c0cffb96c090` on the test file, the baseline and `ops-agent/src`, against this branch at `ffc88f8991d60879d3c65959d30ad9c1f4c25c8a`: ``` OPS_AGENT_EXTRA_BASELINES=<this checkout>/deploy/max2-workflows/ops-agent/baseline/commands.yml \ npx vitest run test/host-metrics-command-classification.test.ts ``` - On this branch: 7/7 passed. Both max2 cases are green: host_metrics is read-only and argument-less, and read_backup_status is read-only. - Negative control against `master` `78e7347`: 2 of 7 fail, which shows the gate can catch a missing entry. ## Rollout The rollout on max2 is T-236 and is done by JP after this merge. Before it, drift should show "no drift". 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(max2-baseline): host_metrics read-only command and read_only on read_backup_status
All checks were successful
CI / Compose config (pull_request) Successful in 18s
CI / Build-arg coverage (pull_request) Successful in 9s
CI / Scanner gelijk aan bron (pull_request) Successful in 9s
CI / Docker build (pull_request) Successful in 2m13s
ffc88f8991
IDEA-277 brings /health to the max2 Ops-dashboard instance. Its sampler
calls host_metrics every 30 s; the block is copied verbatim from the
Ops-dashboard baseline so both hosts classify it the same way, and
read_only: true keeps it off the legacy-mutation lease. read_backup_status
gets read_only: true so the backup card does not take that lease either.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
s4m-codex-reviewer left a comment

APPROVED

Findings:

  • Geen blokkerende of overige codefindings gevonden.

plan gekoppeld via pr_refs (product Ops Dashboard). Referenties: T-235 (Ops Dashboard), T-236 (Ops Dashboard), ST-089 (Ops Dashboard). Er zijn geen weggelaten plandelen (omitted leeg).

De wijziging voldoet aan de scope van T-235: uitsluitend deploy/max2-workflows/ops-agent/baseline/commands.yml wijzigt; host_metrics is letterlijk gelijk aan de baseline op Ops Dashboard-commit 57b1e61f04e066b982e842317455c0cffb96c090, met sudo -n, read_only: true, output: text en zonder argumenten. read_backup_status krijgt eveneens read_only: true. Geen afwijking van de geraadpleegde productstandaarden gevonden; CI blijft ongewijzigd. De bestaande beschrijving en commentaar zijn passend voor deze beperkte configuratiewijziging.

Verificatie: classificatietest zelfstandig herhaald vanuit genoemde Ops Dashboard-commit met OPS_AGENT_EXTRA_BASELINES gericht op scrum4me-docker-commit ffc88f8991d60879d3c65959d30ad9c1f4c25c8a: 7/7 geslaagd. Letterlijke blokvergelijking en git diff --check geslaagd. Geen volledige build of host-rollout uitgevoerd.

De PR claimt alleen de baseline-aanpassing af te ronden en benoemt de max2-rollout als T-236 na merge. T-236 en T-237 blijven vervolgwerk en blokkeren deze PR niet.

# APPROVED Findings: - Geen blokkerende of overige codefindings gevonden. plan gekoppeld via pr_refs (product Ops Dashboard). Referenties: T-235 (Ops Dashboard), T-236 (Ops Dashboard), ST-089 (Ops Dashboard). Er zijn geen weggelaten plandelen (`omitted` leeg). De wijziging voldoet aan de scope van T-235: uitsluitend `deploy/max2-workflows/ops-agent/baseline/commands.yml` wijzigt; `host_metrics` is letterlijk gelijk aan de baseline op Ops Dashboard-commit `57b1e61f04e066b982e842317455c0cffb96c090`, met `sudo -n`, `read_only: true`, `output: text` en zonder argumenten. `read_backup_status` krijgt eveneens `read_only: true`. Geen afwijking van de geraadpleegde productstandaarden gevonden; CI blijft ongewijzigd. De bestaande beschrijving en commentaar zijn passend voor deze beperkte configuratiewijziging. Verificatie: classificatietest zelfstandig herhaald vanuit genoemde Ops Dashboard-commit met `OPS_AGENT_EXTRA_BASELINES` gericht op scrum4me-docker-commit `ffc88f8991d60879d3c65959d30ad9c1f4c25c8a`: 7/7 geslaagd. Letterlijke blokvergelijking en `git diff --check` geslaagd. Geen volledige build of host-rollout uitgevoerd. De PR claimt alleen de baseline-aanpassing af te ronden en benoemt de max2-rollout als T-236 na merge. T-236 en T-237 blijven vervolgwerk en blokkeren deze PR niet.
janpeter merged commit 00981e3036 into master 2026-10-24 03:41:53 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janpeter/scrum4me-docker!136
No description provided.