Scrum4Me/components/shared/user-settings-bridge.tsx
Janpeter Visser bf7162a5fc
feat(PBI-76): migrate cookie-based prefs to user-settings (Phase 2) (#189)
* feat(PBI-76): extend UserSettings schema with layout

Adds layout.splitPanePositions and layout.activeSprints. These will
hold values currently kept in client-side and server-side cookies
(Phase 2). Two new tests cover the shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(PBI-76): migrate SplitPane positions to user-settings store

Outside of a drag the store is the source of truth (cross-tab
updates flow in for free). During a drag we keep splits in local
state so mousemove does not round-trip through the store. On
mouseup we persist the final splits via setPref. Removes
document.cookie reads/writes — cookieKey is reused as the
store-key for backwards compat.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(PBI-76): resolveActiveSprint reads from User.settings

lib/active-sprint:
- New helpers: getActiveSprintIdFromSettings, setActiveSprintInSettings,
  clearActiveSprintInSettings — all read/write user.settings.layout.activeSprints.
- resolveActiveSprint(productId, userId) — userId now required, falls back
  to first OPEN, then most recent CLOSED sprint.
- Cookie helpers (getActiveSprintIdFromCookie/setActiveSprintCookie/
  clearActiveSprintCookie) removed.

Callers updated to pass session.userId. The cookie-based fallback path
is gone — `actions/active-sprint.ts` and `actions/sprints.ts` will be
updated in the next commit (T-917).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(PBI-76): rewrite setActiveSprint callers to use settings

setActiveSprintAction, syncActiveSprintCookieAction, and the two
sprint-creation paths in actions/sprints.ts now write through
setActiveSprintInSettings (which also emits pg_notify for cross-tab
sync) instead of dropping a cookie. The action names keep the
'cookie' suffix in the user-visible API for now — clean rename can
come later.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(PBI-76): migration helper v2 — handle legacy cookies

Bumps marker version to 'v2'. buildMigrationPatch now also scans
document.cookie for `sp:*` (split-pane positions) and
`active_sprint_*` (active sprint per product) and lifts them into
layout.splitPanePositions / layout.activeSprints. clearLegacyStorage
replaces clearLegacyLocalStorage and clears both keys and cookies.
clearLegacyLocalStorage stays as a deprecated alias so the bridge
upgrade is a single rename.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(PBI-76): align tests with new SplitPane and active-sprint flow

- split-pane.test.tsx: seed positions via Zustand store instead of
  document.cookie; mock @/actions/user-settings so the prisma client
  is not transitively initialised in jsdom.
- backlog-split-pane.test.tsx: same action mock.
- sprint-dates.test.ts: add user.findUnique/update + $executeRaw
  mocks because createSprintAction now writes to user-settings.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-10 21:20:29 +02:00

69 lines
2 KiB
TypeScript

'use client'
import { useEffect } from 'react'
import { updateUserSettingsAction } from '@/actions/user-settings'
import { useUserSettingsStore } from '@/stores/user-settings/store'
import type { UserSettings } from '@/lib/user-settings'
import {
buildMigrationPatch,
clearLegacyStorage,
} from '@/lib/user-settings-migration'
interface Props {
initial: UserSettings
isDemo: boolean
}
/**
* PBI-76: hydrates the user-settings Zustand store with server-rendered prefs
* and opens an SSE subscription so other tabs/devices of the same user
* immediately see changes. Demo accounts skip the SSE subscription — their
* settings live only in-memory.
*/
export function UserSettingsBridge({ initial, isDemo }: Props) {
const hydrate = useUserSettingsStore((s) => s.hydrate)
const applyServerPatch = useUserSettingsStore((s) => s.applyServerPatch)
useEffect(() => {
hydrate(initial, isDemo)
}, [hydrate, initial, isDemo])
// One-shot migration: read legacy localStorage prefs, push to server, clear.
// Idempotent via marker; demo accounts skip (no server-write).
useEffect(() => {
if (isDemo) return
const result = buildMigrationPatch()
if (!result.hasData) {
clearLegacyStorage([], [])
return
}
let cancelled = false
void (async () => {
const res = await updateUserSettingsAction(result.patch)
if (cancelled) return
if ('success' in res && res.success) {
applyServerPatch(result.patch)
clearLegacyStorage(result.legacyKeys, result.legacyCookies)
}
})()
return () => {
cancelled = true
}
}, [isDemo, applyServerPatch])
useEffect(() => {
if (isDemo) return
const es = new EventSource('/api/realtime/user-settings')
es.onmessage = (e) => {
try {
const patch = JSON.parse(e.data) as Partial<UserSettings>
applyServerPatch(patch)
} catch {
// ignore malformed event
}
}
return () => es.close()
}, [applyServerPatch, isDemo])
return null
}