Madhura68
dac890b82c
- Phase 3: startReviewPlanJobAction, cancelIdeaJobAction, status transitions (REVIEWING_PLAN / PLAN_REVIEWED / PLAN_REVIEW_FAILED), status colors, job-card/jobs-column filters, idea-list status tabs - Phase 4: review-plan-job.md prompt (multi-model orchestration with codex injection + active plan revision via update_idea_plan_md after each round), runbook, 13 unit tests - Phase 5: ReviewLogViewer component (rounds, convergence, approval, issues), idea-detail integration, proper ReviewLog TypeScript types exported from component - Phase 6.1: wait-for-job discriminator wired (IDEA_REVIEW_PLAN), plan-revision step made mandatory in prompt (was previously optional/missing) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
96 lines
3.3 KiB
TypeScript
96 lines
3.3 KiB
TypeScript
// Bidirectionele case-mapper voor IdeaStatus + transitie-guard helper.
|
|
// DB houdt UPPER_SNAKE; API exposeert lowercase.
|
|
// Patroon volgt lib/task-status.ts.
|
|
|
|
import type { IdeaStatus } from '@prisma/client'
|
|
|
|
const IDEA_DB_TO_API = {
|
|
DRAFT: 'draft',
|
|
GRILLING: 'grilling',
|
|
GRILL_FAILED: 'grill_failed',
|
|
GRILLED: 'grilled',
|
|
PLANNING: 'planning',
|
|
PLAN_FAILED: 'plan_failed',
|
|
PLAN_READY: 'plan_ready',
|
|
REVIEWING_PLAN: 'reviewing_plan',
|
|
PLAN_REVIEW_FAILED: 'plan_review_failed',
|
|
PLAN_REVIEWED: 'plan_reviewed',
|
|
PLANNED: 'planned',
|
|
} as const satisfies Record<IdeaStatus, string>
|
|
|
|
const IDEA_API_TO_DB: Record<string, IdeaStatus> = {
|
|
draft: 'DRAFT',
|
|
grilling: 'GRILLING',
|
|
grill_failed: 'GRILL_FAILED',
|
|
grilled: 'GRILLED',
|
|
planning: 'PLANNING',
|
|
plan_failed: 'PLAN_FAILED',
|
|
plan_ready: 'PLAN_READY',
|
|
reviewing_plan: 'REVIEWING_PLAN',
|
|
plan_review_failed: 'PLAN_REVIEW_FAILED',
|
|
plan_reviewed: 'PLAN_REVIEWED',
|
|
planned: 'PLANNED',
|
|
}
|
|
|
|
export type IdeaStatusApi = (typeof IDEA_DB_TO_API)[IdeaStatus]
|
|
|
|
export function ideaStatusToApi(s: IdeaStatus): IdeaStatusApi {
|
|
return IDEA_DB_TO_API[s]
|
|
}
|
|
|
|
export function ideaStatusFromApi(s: string): IdeaStatus | null {
|
|
return IDEA_API_TO_DB[s.toLowerCase()] ?? null
|
|
}
|
|
|
|
export const IDEA_STATUS_API_VALUES = Object.values(IDEA_DB_TO_API)
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// State-machine transition table (zie docs/plans/M12-ideas.md state-machine).
|
|
// Server-actions gebruiken canTransition(from, to) als guard vóór mutatie.
|
|
//
|
|
// Asymmetrisch: trek vanuit DRAFT alleen naar GRILLING; vanuit GRILLED kan
|
|
// re-grill (→ GRILLING) of make-plan (→ PLANNING) gebeuren. PLANNED is een
|
|
// terminal state; verlaat alleen via expliciete relink (PBI verwijderd → PLAN_READY).
|
|
|
|
const ALLOWED_TRANSITIONS: Record<IdeaStatus, ReadonlyArray<IdeaStatus>> = {
|
|
DRAFT: ['GRILLING'],
|
|
GRILLING: ['GRILLED', 'GRILL_FAILED'],
|
|
GRILL_FAILED: ['GRILLING', 'DRAFT'],
|
|
GRILLED: ['GRILLING', 'PLANNING'],
|
|
PLANNING: ['PLAN_READY', 'PLAN_FAILED'],
|
|
PLAN_FAILED: ['PLANNING', 'GRILLED'],
|
|
PLAN_READY: ['PLANNING', 'PLANNED', 'GRILLING', 'REVIEWING_PLAN'], // + REVIEWING_PLAN via startReviewPlanJobAction
|
|
REVIEWING_PLAN: ['PLAN_REVIEWED', 'PLAN_REVIEW_FAILED'],
|
|
PLAN_REVIEW_FAILED: ['REVIEWING_PLAN', 'PLAN_READY'], // Can retry review or edit plan
|
|
PLAN_REVIEWED: ['REVIEWING_PLAN', 'PLANNED'], // Can re-review or create PBIs
|
|
PLANNED: ['PLAN_READY', 'GRILLING'], // PLAN_READY via relinkIdeaPlanAction; GRILLING via startGrillJobAction
|
|
}
|
|
|
|
export function canTransition(from: IdeaStatus, to: IdeaStatus): boolean {
|
|
return ALLOWED_TRANSITIONS[from].includes(to)
|
|
}
|
|
|
|
// Statussen waarin een idee bewerkbaar is (form-input, niet md-velden).
|
|
const EDITABLE_STATUSES: ReadonlyArray<IdeaStatus> = [
|
|
'DRAFT',
|
|
'GRILL_FAILED',
|
|
'GRILLED',
|
|
'PLAN_FAILED',
|
|
'PLAN_READY',
|
|
'PLAN_REVIEW_FAILED',
|
|
'PLAN_REVIEWED',
|
|
]
|
|
|
|
export function isIdeaEditable(s: IdeaStatus): boolean {
|
|
return EDITABLE_STATUSES.includes(s)
|
|
}
|
|
|
|
// Statussen waarin grill_md bewerkbaar is (handmatige finetuning).
|
|
export function isGrillMdEditable(s: IdeaStatus): boolean {
|
|
return s === 'GRILLED' || s === 'PLAN_READY'
|
|
}
|
|
|
|
// Statussen waarin plan_md bewerkbaar is.
|
|
export function isPlanMdEditable(s: IdeaStatus): boolean {
|
|
return s === 'PLAN_READY' || s === 'PLAN_REVIEWED' || s === 'PLAN_REVIEW_FAILED'
|
|
}
|