Scrum4Me/components/ideas/idea-row-actions.tsx
Janpeter Visser 5cb3abbd3d
Sprint: Idee regril mogelijkheid (#144)
* feat(ST-cmovhveef): add PLANNED to GRILL_TRIGGERABLE_FROM and PLANNED→GRILLING transition

- GRILL_TRIGGERABLE_FROM now includes 'PLANNED' in actions/ideas.ts
- ALLOWED_TRANSITIONS PLANNED entry extended with 'GRILLING' in lib/idea-status.ts
- Updated canTransition test to reflect the new re-grill-from-PLANNED behavior

* test(ST-cmovhvef3): add exhaustive re-grill canTransition test covering PLANNED

Adds a loop test that asserts canTransition(status, 'GRILLING') for all
statuses in GRILL_TRIGGERABLE_FROM that support the transition, explicitly
documenting PLANNED as a valid re-grill entry point.

* feat(ST-cmovhvegf): add existingPbi pre-check in materializeIdeaPlanAction

- Adds options.allowAlongside parameter to control behaviour when a PBI
  with executed tasks already exists.
- Returns 409 PBI_HAS_ACTIVE_TASKS:<code> when tasks are DONE/IN_PROGRESS
  and allowAlongside is not set.
- Auto-deletes the old PBI inside the transaction when no tasks have been
  executed (atomic replace).
- Alongside mode (allowAlongside=true) skips deletion and creates a new PBI.

* test(ST-cmovhveh3): add pre-check integration tests for materializeIdeaPlanAction

Three new scenarios in ideas-crud.test.ts:
- auto-vervang: old PBI deleted in transaction when no executed tasks
- conflict-409: returns PBI_HAS_ACTIVE_TASKS:<code> with active tasks
- alongside: skips delete and creates new PBI when allowAlongside=true
Also adds task.count, pbi.findUnique, pbi.delete to prisma mock.

* feat(ST-cmovhveih): remove PLANNED-blokkering in idea-row-actions, add inline Bekijk-PBI button

- Removed grillBlockedReason guard for status==='planned', enabling re-grill from PLANNED
- Removed the early return for PLANNED that hid all standard buttons
- Added conditional 'Bekijk <code>' button at the start of the standard button set,
  visible only when status==='planned' and PBI + product_id are present

* feat(ST-cmovhvej7): add PBI_HAS_ACTIVE_TASKS alongside-dialoog in materialize handler

When materializeIdeaPlanAction returns code 409 with PBI_HAS_ACTIVE_TASKS:<code>,
a confirm dialog offers the user a choice: create new PBI alongside the existing one
or cancel. Alongside=true retries the action; cancel leaves the idea in PLAN_READY.
2026-05-07 15:27:43 +02:00

281 lines
8.1 KiB
TypeScript

'use client'
// IdeaRowActions — Grill Me / Make Plan / Materialiseer / Archive / Open.
// Disabled-rules per M12 T-508:
//
// Grill Me: niet in GRILLING|PLANNING; vereist product-met-repo +
// connectedWorkers > 0
// Make Plan: alleen in GRILLED|PLAN_FAILED|PLAN_READY (re-plan); idem
// voorwaarden
// Materialiseer: alleen in PLAN_READY (geen worker nodig — synchrone parser)
// PLANNED: alle drie disabled, "Bekijk PBI" link
// *_FAILED: "Probeer opnieuw" knop (= start-job opnieuw)
//
// Demo-tooltip om elke muteer-knop. connectedWorkers wordt gelezen uit
// useSoloStore (M12 grill-keuze 16 — geen lift voor v1).
import { useTransition } from 'react'
import { useRouter } from 'next/navigation'
import {
Archive,
ArrowRight,
ExternalLink,
Flame,
Layers,
RotateCw,
Sparkles,
} from 'lucide-react'
import { toast } from 'sonner'
import { Button } from '@/components/ui/button'
import {
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger,
} from '@/components/ui/tooltip'
import { DemoTooltip } from '@/components/shared/demo-tooltip'
import { useSoloStore } from '@/stores/solo-store'
import {
startGrillJobAction,
startMakePlanJobAction,
materializeIdeaPlanAction,
} from '@/actions/ideas'
import type { IdeaDto } from '@/lib/idea-dto'
interface IdeaRowActionsProps {
idea: IdeaDto
isDemo: boolean
onArchive: () => void
}
export function IdeaRowActions({ idea, isDemo, onArchive }: IdeaRowActionsProps) {
const router = useRouter()
const connectedWorkers = useSoloStore((s) => s.connectedWorkers)
const [pending, startTransition] = useTransition()
const hasProductWithRepo = idea.product != null && idea.product.repo_url !== null
const workerOk = connectedWorkers > 0
const status = idea.status
// ---- Grill Me ----
const grillBlockedReason = (() => {
if (status === 'grilling' || status === 'planning') return 'Job loopt al'
if (!hasProductWithRepo) return 'Idee heeft een product met repo nodig'
if (!workerOk) return 'Geen Claude-worker actief'
return null
})()
const grillEnabled = !grillBlockedReason && !isDemo && !pending
// ---- Make Plan ----
const makePlanAllowedStates = ['grilled', 'plan_failed', 'plan_ready']
const makePlanBlockedReason = (() => {
if (!makePlanAllowedStates.includes(status)) {
if (status === 'draft' || status === 'grill_failed') return 'Eerst grillen'
if (status === 'grilling' || status === 'planning') return 'Job loopt al'
if (status === 'planned') return 'Idee is gepland — open de PBI'
return null
}
if (!hasProductWithRepo) return 'Idee heeft een product met repo nodig'
if (!workerOk) return 'Geen Claude-worker actief'
return null
})()
const makePlanEnabled = !makePlanBlockedReason && !isDemo && !pending
// ---- Materialiseer ----
const materializeBlockedReason = (() => {
if (status !== 'plan_ready') return 'Plan is niet klaar'
return null
})()
const materializeEnabled = !materializeBlockedReason && !isDemo && !pending
// ---- Failed-states tonen "Probeer opnieuw" ----
const isFailedState = status === 'grill_failed' || status === 'plan_failed'
function runStart(action: typeof startGrillJobAction | typeof startMakePlanJobAction) {
startTransition(async () => {
const r = await action(idea.id)
if ('error' in r) {
toast.error(r.error)
return
}
toast.success('Job in de wachtrij — een worker pakt hem op.')
router.refresh()
})
}
function handleMaterialize() {
if (!confirm('Plan materialiseren? Dit maakt PBI + stories + taken aan.')) return
startTransition(async () => {
let r = await materializeIdeaPlanAction(idea.id)
if ('error' in r && r.code === 409 && r.error.startsWith('PBI_HAS_ACTIVE_TASKS:')) {
const pbiCode = r.error.split(':')[1]
const alongside = confirm(
`De bestaande PBI (${pbiCode}) heeft uitgevoerde taken.\n` +
`OK = nieuwe PBI naast bestaande aanmaken.\n` +
`Annuleren = stoppen.`
)
if (!alongside) return
r = await materializeIdeaPlanAction(idea.id, { allowAlongside: true })
}
if ('error' in r) {
toast.error(r.error)
return
}
toast.success(`Gematerialiseerd als ${r.data?.pbi_code}`)
if (idea.product_id) {
router.push(`/products/${idea.product_id}`)
} else {
router.refresh()
}
})
}
return (
<div className="flex items-center gap-1">
{/* Bekijk PBI — alleen zichtbaar in PLANNED */}
{status === 'planned' && idea.pbi && idea.product_id && (
<Button
variant="outline"
size="sm"
onClick={() => router.push(`/products/${idea.product_id!}`)}
>
Bekijk {idea.pbi.code}
<ExternalLink className="ml-1 size-3.5" />
</Button>
)}
{/* Grill Me */}
<ActionButton
label="Grill"
icon={<Flame className="size-3.5" />}
enabled={grillEnabled}
blockedReason={grillBlockedReason}
isDemo={isDemo}
onClick={() => runStart(startGrillJobAction)}
/>
{/* Make Plan */}
<ActionButton
label="Plan"
icon={<Sparkles className="size-3.5" />}
enabled={makePlanEnabled}
blockedReason={makePlanBlockedReason}
isDemo={isDemo}
onClick={() => runStart(startMakePlanJobAction)}
/>
{/* Materialiseer */}
<ActionButton
label="Maak PBI"
icon={<Layers className="size-3.5" />}
enabled={materializeEnabled}
blockedReason={materializeBlockedReason}
isDemo={isDemo}
onClick={handleMaterialize}
variant="default"
/>
{/* Failed-states: kleine retry-shortcut */}
{isFailedState && (
<DemoTooltip show={isDemo}>
<Button
size="sm"
variant="outline"
disabled={isDemo || pending || !workerOk || !hasProductWithRepo}
onClick={() =>
runStart(
status === 'grill_failed' ? startGrillJobAction : startMakePlanJobAction,
)
}
title="Probeer opnieuw"
>
<RotateCw className="size-3.5" />
</Button>
</DemoTooltip>
)}
{/* Open detail */}
<Button
size="sm"
variant="ghost"
onClick={() => router.push(`/ideas/${idea.id}`)}
aria-label="Open idee"
title="Open idee"
>
<ArrowRight className="size-4" />
</Button>
{/* Archive */}
<DemoTooltip show={isDemo}>
<Button
size="sm"
variant="ghost"
onClick={onArchive}
disabled={isDemo || pending}
aria-label="Archiveer idee"
title="Archiveer"
>
<Archive className="size-4" />
</Button>
</DemoTooltip>
</div>
)
}
interface ActionButtonProps {
label: string
icon: React.ReactNode
enabled: boolean
blockedReason: string | null
isDemo: boolean
onClick: () => void
variant?: 'default' | 'outline'
}
function ActionButton({
label,
icon,
enabled,
blockedReason,
isDemo,
onClick,
variant = 'outline',
}: ActionButtonProps) {
// Bij demo: DemoTooltip toont reden. Bij niet-demo + reden: gewone tooltip.
if (isDemo) {
return (
<DemoTooltip show>
<Button size="sm" variant={variant} disabled>
{icon}
<span className="ml-1">{label}</span>
</Button>
</DemoTooltip>
)
}
if (!enabled && blockedReason) {
return (
<TooltipProvider>
<Tooltip>
<TooltipTrigger render={<span className="inline-flex" />}>
<Button size="sm" variant={variant} disabled>
{icon}
<span className="ml-1">{label}</span>
</Button>
</TooltipTrigger>
<TooltipContent>{blockedReason}</TooltipContent>
</Tooltip>
</TooltipProvider>
)
}
return (
<Button size="sm" variant={variant} onClick={onClick}>
{icon}
<span className="ml-1">{label}</span>
</Button>
)
}