T-789: Snapshot van resolved JobConfig in ClaudeJob.requested_*
bij elke job-creatie. Helper in lib/job-config-snapshot.ts laadt
product (preferred_*) en task (requires_opus) en draait de resolver
uit lib/job-config.ts (mirror van scrum4me-mcp/src/lib/job-config.ts —
zelfde matrix, sync-comment in bestand). Toegepast op alle 5
enqueue-locaties:
- actions/user-questions.ts (PLAN_CHAT)
- actions/sprint-runs.ts × 3 (SPRINT_IMPLEMENTATION x2,
TASK_IMPLEMENTATION loop)
- actions/ideas.ts (IDEA_GRILL / IDEA_MAKE_PLAN)
Test-mocks uitgebreid met product.findUnique en task.findUnique zodat
de helper bij unit tests veilig terugvalt op kind-defaults (alle 563
tests groen).
T-790: Sectie 'Config doorgeven aan Claude Code' toegevoegd aan
docs/runbooks/worker-idempotency.md met CLI-flag-mapping en de
verwachte aanroep per kind. Forward-link naar
docs/runbooks/job-model-selection.md (volgt in T-794).
Plus: docs/plans/job-model-selection.md (de approved plan-doc).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
141 lines
3.9 KiB
TypeScript
141 lines
3.9 KiB
TypeScript
// PBI-67: model + mode-selectie per ClaudeJob-kind.
|
|
//
|
|
// Sync with scrum4me-mcp/src/lib/job-config.ts — als je hier een veld
|
|
// aanpast, doe hetzelfde aan de MCP-kant. Dit is bewust een duplicate
|
|
// (geen gedeeld package) om de MCP-server eigenstandig te houden.
|
|
//
|
|
// Override-cascade (eerste match wint):
|
|
// 1. task.requires_opus === true → forceer Opus
|
|
// 2. job.requested_* (snapshot bij enqueue, ingevuld door deze module)
|
|
// 3. product.preferred_*
|
|
// 4. KIND_DEFAULTS hieronder
|
|
|
|
export type ClaudeModel =
|
|
| 'claude-opus-4-7'
|
|
| 'claude-sonnet-4-6'
|
|
| 'claude-haiku-4-5-20251001'
|
|
|
|
export type PermissionMode = 'plan' | 'default' | 'acceptEdits' | 'bypassPermissions'
|
|
|
|
export type JobConfig = {
|
|
model: ClaudeModel
|
|
thinking_budget: number
|
|
permission_mode: PermissionMode
|
|
max_turns: number | null
|
|
allowed_tools: string[] | null
|
|
}
|
|
|
|
export type JobInput = {
|
|
kind: string
|
|
requested_model?: string | null
|
|
requested_thinking_budget?: number | null
|
|
requested_permission_mode?: string | null
|
|
}
|
|
|
|
export type ProductInput = {
|
|
preferred_model?: string | null
|
|
thinking_budget_default?: number | null
|
|
preferred_permission_mode?: string | null
|
|
}
|
|
|
|
export type TaskInput = {
|
|
requires_opus?: boolean | null
|
|
}
|
|
|
|
const KIND_DEFAULTS: Record<string, JobConfig> = {
|
|
IDEA_GRILL: {
|
|
model: 'claude-sonnet-4-6',
|
|
thinking_budget: 12000,
|
|
permission_mode: 'plan',
|
|
max_turns: 15,
|
|
allowed_tools: ['Read', 'Grep', 'Glob', 'WebSearch', 'AskUserQuestion'],
|
|
},
|
|
IDEA_MAKE_PLAN: {
|
|
model: 'claude-opus-4-7',
|
|
thinking_budget: 24000,
|
|
permission_mode: 'plan',
|
|
max_turns: 20,
|
|
allowed_tools: ['Read', 'Grep', 'Glob', 'WebSearch', 'AskUserQuestion', 'Write'],
|
|
},
|
|
PLAN_CHAT: {
|
|
model: 'claude-sonnet-4-6',
|
|
thinking_budget: 6000,
|
|
permission_mode: 'plan',
|
|
max_turns: 5,
|
|
allowed_tools: ['Read', 'Grep', 'AskUserQuestion'],
|
|
},
|
|
TASK_IMPLEMENTATION: {
|
|
model: 'claude-sonnet-4-6',
|
|
thinking_budget: 6000,
|
|
permission_mode: 'bypassPermissions',
|
|
max_turns: 50,
|
|
allowed_tools: null,
|
|
},
|
|
SPRINT_IMPLEMENTATION: {
|
|
model: 'claude-sonnet-4-6',
|
|
thinking_budget: 6000,
|
|
permission_mode: 'bypassPermissions',
|
|
max_turns: null,
|
|
allowed_tools: null,
|
|
},
|
|
}
|
|
|
|
const FALLBACK: JobConfig = {
|
|
model: 'claude-sonnet-4-6',
|
|
thinking_budget: 6000,
|
|
permission_mode: 'default',
|
|
max_turns: 50,
|
|
allowed_tools: null,
|
|
}
|
|
|
|
export function getKindDefault(kind: string): JobConfig {
|
|
return KIND_DEFAULTS[kind] ?? FALLBACK
|
|
}
|
|
|
|
// max_turns en allowed_tools blijven kind-default (geen product/task override
|
|
// in V1 — als de behoefte ontstaat, voeg analoge velden toe aan Product/Task).
|
|
export function resolveJobConfig(
|
|
job: JobInput,
|
|
product: ProductInput,
|
|
task?: TaskInput,
|
|
): JobConfig {
|
|
const base = getKindDefault(job.kind)
|
|
|
|
const model = (
|
|
task?.requires_opus
|
|
? 'claude-opus-4-7'
|
|
: job.requested_model ?? product.preferred_model ?? base.model
|
|
) as ClaudeModel
|
|
|
|
const thinking_budget =
|
|
job.requested_thinking_budget ?? product.thinking_budget_default ?? base.thinking_budget
|
|
|
|
const permission_mode = (job.requested_permission_mode ??
|
|
product.preferred_permission_mode ??
|
|
base.permission_mode) as PermissionMode
|
|
|
|
return {
|
|
model,
|
|
thinking_budget,
|
|
permission_mode,
|
|
max_turns: base.max_turns,
|
|
allowed_tools: base.allowed_tools,
|
|
}
|
|
}
|
|
|
|
// Snapshot-velden voor ClaudeJob.requested_*. Bij elke enqueue laden we
|
|
// product (voor preferred_*) en optioneel task (voor requires_opus), draaien
|
|
// de resolver, en schrijven het resultaat als auditspoor in de job-rij.
|
|
export type ClaudeJobSnapshotFields = {
|
|
requested_model: string
|
|
requested_thinking_budget: number
|
|
requested_permission_mode: string
|
|
}
|
|
|
|
export function snapshotFromConfig(cfg: JobConfig): ClaudeJobSnapshotFields {
|
|
return {
|
|
requested_model: cfg.model,
|
|
requested_thinking_budget: cfg.thinking_budget,
|
|
requested_permission_mode: cfg.permission_mode,
|
|
}
|
|
}
|