d750676f5e
* fix(ST-1272): allow PLAN_READY → GRILLING re-grill transition
actions/ideas.ts already lists PLAN_READY in GRILL_TRIGGERABLE_FROM,
but lib/idea-status.ts ALLOWED_TRANSITIONS was missing the
PLAN_READY → GRILLING edge. As a result, clicking Grill on a PLAN_READY
idea returned 422 "Status-transitie ongeldig" while the UI button was
enabled. Mirrors the existing PLANNED → GRILLING re-grill behaviour.
- lib/idea-status.ts: PLAN_READY allows GRILLING in addition to
PLANNING/PLANNED
- __tests__/lib/idea-status.test.ts: explicit assert for
PLAN_READY → GRILLING and PLAN_READY added to the regrill loop
covering every GRILL_TRIGGERABLE_FROM status
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(ST-1275): render SKIPPED job status in chart-colors and insights
Closing the gap left when ClaudeJobStatus.SKIPPED was added to the schema:
the badge map and case-mapper already covered it, but the chart palette,
the per-day insights aggregator and the stacked-bar chart did not. SKIPPED
jobs (e.g. cmovkur8 manually flipped during the no-op-exit hotfix) now
render with a muted style consistent with cancelled.
- lib/chart-colors.ts: JOB_STATUS_COLORS gains a 'skipped' entry
(var(--muted-foreground), same intensity as cancelled — neither rood/orange)
- lib/insights/agent-throughput.ts: DayCount + STATUSES + perDay zero-fill
now include 'skipped'; the SQL terminal_7d filter already counted SKIPPED
- app/(app)/insights/components/agent-throughput.tsx: STACKED_STATUSES and
the empty-state guard include 'skipped'
- __tests__: chart-colors keys list, job-status round-trip ('all 7 statuses')
and the insights non-zero filter all account for SKIPPED
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
44 lines
1.5 KiB
TypeScript
44 lines
1.5 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import {
|
|
jobStatusToApi,
|
|
jobStatusFromApi,
|
|
JOB_STATUS_API_VALUES,
|
|
ACTIVE_JOB_STATUSES,
|
|
} from '@/lib/job-status'
|
|
|
|
describe('job-status mappers', () => {
|
|
it('round-trips every API value', () => {
|
|
for (const api of JOB_STATUS_API_VALUES) {
|
|
const db = jobStatusFromApi(api)
|
|
expect(db).not.toBeNull()
|
|
expect(jobStatusToApi(db!)).toBe(api)
|
|
}
|
|
})
|
|
|
|
it('returns null for invalid input', () => {
|
|
expect(jobStatusFromApi('NOT_A_STATUS')).toBeNull()
|
|
expect(jobStatusFromApi('')).toBeNull()
|
|
expect(jobStatusFromApi('active')).toBeNull()
|
|
})
|
|
|
|
it('is case-insensitive on the API side (accepts both upper and lower)', () => {
|
|
expect(jobStatusFromApi('running')).toBe('RUNNING')
|
|
expect(jobStatusFromApi('RUNNING')).toBe('RUNNING')
|
|
expect(jobStatusFromApi('QUEUED')).toBe('QUEUED')
|
|
})
|
|
|
|
it('maps all 7 DB statuses to API', () => {
|
|
expect(jobStatusToApi('QUEUED')).toBe('queued')
|
|
expect(jobStatusToApi('CLAIMED')).toBe('claimed')
|
|
expect(jobStatusToApi('RUNNING')).toBe('running')
|
|
expect(jobStatusToApi('DONE')).toBe('done')
|
|
expect(jobStatusToApi('FAILED')).toBe('failed')
|
|
expect(jobStatusToApi('CANCELLED')).toBe('cancelled')
|
|
expect(jobStatusToApi('SKIPPED')).toBe('skipped')
|
|
})
|
|
|
|
it('ACTIVE_JOB_STATUSES contains exactly QUEUED, CLAIMED, RUNNING', () => {
|
|
expect(ACTIVE_JOB_STATUSES).toEqual(expect.arrayContaining(['QUEUED', 'CLAIMED', 'RUNNING']))
|
|
expect(ACTIVE_JOB_STATUSES).toHaveLength(3)
|
|
})
|
|
})
|