* docs(ST-511): add backlog entry for entity codes feature Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): add createWithCodeRetry helper to handle P2002 race on auto codes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): retry on auto-code unique conflict in story and pbi create Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): surface field errors for code and title in PBI dialog Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): read create-state errors in Story dialog fieldError Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-512): add backlog entry for REST API code/description/implementation_plan extensions; mark ST-511 done Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-512): extend REST API with code, description and implementation_plan - GET /api/products returns code, description and definition_of_done - GET /api/products/:id/next-story returns story.code and per-task code + implementation_plan - GET /api/sprints/:id/tasks returns description, implementation_plan, story_code and derived per-task code - POST /api/todos accepts and returns optional description (max 2000) All changes are additive — existing clients ignore unknown keys. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-512): mark ST-512 as done Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-513): add backlog entry for API hardening for Claude Code Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add task and story status mappers for API boundary Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): expose lowercase status on API and accept lowercase in PATCH /api/tasks Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add metadata JSONB column to StoryLog Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): accept optional metadata in story log and switch validation errors to 422 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add GET /api/health endpoint with optional db ping Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add GET /api/products/:id/claude-context bundled endpoint Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-513): add docs/API.md and link from CLAUDE.md specs table Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-513): mark ST-513 as done Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-513): split 400 (malformed JSON) from 422 (validation), reject 'review' Codex review on PR #2: - P2.1: routes treated JSON parse failures as 422 instead of 400, breaking the contract in docs/API.md. Replace `request.json().catch(() => null)` with try/catch in 4 routes (tasks, reorder, todos, story-log) so a malformed body returns 400 and only well-formed-but-invalid bodies return 422. - P2.2: PATCH /api/tasks/:id accepted `status: "review"`, but the sprint task list UI does not render REVIEW (no label/color, the cycle helper falls back to TO_DO). Reject `review` at the API until the sprint UI is extended; document the subset in docs/API.md. Tests in __tests__/api updated for the new contract (29 assertions: zod-failures now expect 422, status payloads use lowercase API values, sprint-tasks mocks include the new story relation). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
158 lines
5.4 KiB
TypeScript
158 lines
5.4 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
vi.mock('@/lib/prisma', () => ({
|
|
prisma: {
|
|
task: {
|
|
findFirst: vi.fn(),
|
|
update: vi.fn(),
|
|
},
|
|
},
|
|
}))
|
|
|
|
vi.mock('@/lib/api-auth', () => ({
|
|
authenticateApiRequest: vi.fn(),
|
|
}))
|
|
|
|
import { prisma } from '@/lib/prisma'
|
|
import { authenticateApiRequest } from '@/lib/api-auth'
|
|
import { PATCH as patchTask } from '@/app/api/tasks/[id]/route'
|
|
|
|
const mockPrisma = prisma as unknown as {
|
|
task: { findFirst: ReturnType<typeof vi.fn>; update: ReturnType<typeof vi.fn> }
|
|
}
|
|
const mockAuth = authenticateApiRequest as ReturnType<typeof vi.fn>
|
|
|
|
function makeTask(overrides: { userId?: string; membersLength?: number } = {}) {
|
|
const { userId = 'user-1', membersLength = 0 } = overrides
|
|
return {
|
|
id: 'task-1',
|
|
story: {
|
|
product: {
|
|
user_id: userId,
|
|
members: Array.from({ length: membersLength }, (_, i) => ({ id: `member-${i}` })),
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
function makeRequest(body: unknown, taskId = 'task-1'): [Request, { params: Promise<{ id: string }> }] {
|
|
return [
|
|
new Request(`http://localhost/api/tasks/${taskId}`, {
|
|
method: 'PATCH',
|
|
headers: { Authorization: 'Bearer test-token', 'Content-Type': 'application/json' },
|
|
body: JSON.stringify(body),
|
|
}),
|
|
{ params: Promise.resolve({ id: taskId }) },
|
|
]
|
|
}
|
|
|
|
describe('PATCH /api/tasks/:id', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mockAuth.mockResolvedValue({ userId: 'user-1', isDemo: false })
|
|
mockPrisma.task.findFirst.mockResolvedValue(makeTask())
|
|
mockPrisma.task.update.mockResolvedValue({
|
|
id: 'task-1',
|
|
status: 'DONE',
|
|
implementation_plan: null,
|
|
})
|
|
})
|
|
|
|
// TC-T-06
|
|
it('returns 422 for invalid status value', async () => {
|
|
const res = await patchTask(...makeRequest({ status: 'INVALID' }))
|
|
expect(res.status).toBe(422)
|
|
})
|
|
|
|
// TC-T-07
|
|
it('returns 422 when body has no recognized fields', async () => {
|
|
const res = await patchTask(...makeRequest({}))
|
|
expect(res.status).toBe(422)
|
|
})
|
|
|
|
it('returns 422 when body has only unrecognized fields', async () => {
|
|
const res = await patchTask(...makeRequest({ unknown_field: 'value' }))
|
|
expect(res.status).toBe(422)
|
|
})
|
|
|
|
// TC-T-08
|
|
it('updates status only and returns 200 with updated task', async () => {
|
|
mockPrisma.task.update.mockResolvedValue({ id: 'task-1', status: 'IN_PROGRESS', implementation_plan: null })
|
|
|
|
const res = await patchTask(...makeRequest({ status: 'in_progress' }))
|
|
const data = await res.json()
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(data).toMatchObject({ id: 'task-1', status: 'in_progress' })
|
|
expect(mockPrisma.task.update).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
data: { status: 'IN_PROGRESS' },
|
|
})
|
|
)
|
|
})
|
|
|
|
// TC-T-09
|
|
it('updates implementation_plan only and returns 200', async () => {
|
|
const plan = 'Step 1: implement. Step 2: test.'
|
|
mockPrisma.task.update.mockResolvedValue({ id: 'task-1', status: 'TO_DO', implementation_plan: plan })
|
|
|
|
const res = await patchTask(...makeRequest({ implementation_plan: plan }))
|
|
const data = await res.json()
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(data.implementation_plan).toBe(plan)
|
|
expect(mockPrisma.task.update).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
data: { implementation_plan: plan },
|
|
})
|
|
)
|
|
})
|
|
|
|
// TC-T-10
|
|
it('updates both status and implementation_plan and returns 200', async () => {
|
|
const plan = 'Full plan here.'
|
|
mockPrisma.task.update.mockResolvedValue({ id: 'task-1', status: 'DONE', implementation_plan: plan })
|
|
|
|
const res = await patchTask(...makeRequest({ status: 'done', implementation_plan: plan }))
|
|
const data = await res.json()
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(data).toMatchObject({ status: 'done', implementation_plan: plan })
|
|
expect(mockPrisma.task.update).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
data: { status: 'DONE', implementation_plan: plan },
|
|
})
|
|
)
|
|
})
|
|
|
|
// TC-T-11
|
|
it('allows update when user is a team member (not product owner)', async () => {
|
|
mockAuth.mockResolvedValue({ userId: 'user-1', isDemo: false })
|
|
mockPrisma.task.findFirst.mockResolvedValue(makeTask({ userId: 'user-2', membersLength: 1 }))
|
|
mockPrisma.task.update.mockResolvedValue({ id: 'task-1', status: 'DONE', implementation_plan: null })
|
|
|
|
const res = await patchTask(...makeRequest({ status: 'done' }))
|
|
expect(res.status).toBe(200)
|
|
})
|
|
|
|
it('the three patchable status values are accepted (review is rejected)', async () => {
|
|
for (const apiStatus of ['todo', 'in_progress', 'done'] as const) {
|
|
const dbStatus = { todo: 'TO_DO', in_progress: 'IN_PROGRESS', done: 'DONE' }[apiStatus]
|
|
mockPrisma.task.update.mockResolvedValue({ id: 'task-1', status: dbStatus, implementation_plan: null })
|
|
const res = await patchTask(...makeRequest({ status: apiStatus }))
|
|
expect(res.status).toBe(200)
|
|
}
|
|
const reviewRes = await patchTask(...makeRequest({ status: 'review' }))
|
|
expect(reviewRes.status).toBe(422)
|
|
})
|
|
|
|
it('returns 400 for malformed JSON', async () => {
|
|
const req = new Request('http://localhost/api/tasks/task-1', {
|
|
method: 'PATCH',
|
|
headers: { Authorization: 'Bearer test-token', 'Content-Type': 'application/json' },
|
|
body: '{not json',
|
|
})
|
|
const res = await patchTask(req, { params: Promise.resolve({ id: 'task-1' }) })
|
|
expect(res.status).toBe(400)
|
|
})
|
|
})
|