* docs(ST-511): add backlog entry for entity codes feature Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): add createWithCodeRetry helper to handle P2002 race on auto codes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): retry on auto-code unique conflict in story and pbi create Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): surface field errors for code and title in PBI dialog Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): read create-state errors in Story dialog fieldError Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-512): add backlog entry for REST API code/description/implementation_plan extensions; mark ST-511 done Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-512): extend REST API with code, description and implementation_plan - GET /api/products returns code, description and definition_of_done - GET /api/products/:id/next-story returns story.code and per-task code + implementation_plan - GET /api/sprints/:id/tasks returns description, implementation_plan, story_code and derived per-task code - POST /api/todos accepts and returns optional description (max 2000) All changes are additive — existing clients ignore unknown keys. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-512): mark ST-512 as done Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-513): add backlog entry for API hardening for Claude Code Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add task and story status mappers for API boundary Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): expose lowercase status on API and accept lowercase in PATCH /api/tasks Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add metadata JSONB column to StoryLog Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): accept optional metadata in story log and switch validation errors to 422 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add GET /api/health endpoint with optional db ping Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add GET /api/products/:id/claude-context bundled endpoint Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-513): add docs/API.md and link from CLAUDE.md specs table Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-513): mark ST-513 as done Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-513): split 400 (malformed JSON) from 422 (validation), reject 'review' Codex review on PR #2: - P2.1: routes treated JSON parse failures as 422 instead of 400, breaking the contract in docs/API.md. Replace `request.json().catch(() => null)` with try/catch in 4 routes (tasks, reorder, todos, story-log) so a malformed body returns 400 and only well-formed-but-invalid bodies return 422. - P2.2: PATCH /api/tasks/:id accepted `status: "review"`, but the sprint task list UI does not render REVIEW (no label/color, the cycle helper falls back to TO_DO). Reject `review` at the API until the sprint UI is extended; document the subset in docs/API.md. Tests in __tests__/api updated for the new contract (29 assertions: zod-failures now expect 422, status payloads use lowercase API values, sprint-tasks mocks include the new story relation). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
111 lines
3.6 KiB
TypeScript
111 lines
3.6 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
vi.mock('@/lib/prisma', () => ({
|
|
prisma: {
|
|
story: {
|
|
findFirst: vi.fn(),
|
|
},
|
|
task: {
|
|
update: vi.fn(),
|
|
},
|
|
$transaction: vi.fn(),
|
|
},
|
|
}))
|
|
|
|
vi.mock('@/lib/api-auth', () => ({
|
|
authenticateApiRequest: vi.fn(),
|
|
}))
|
|
|
|
import { prisma } from '@/lib/prisma'
|
|
import { authenticateApiRequest } from '@/lib/api-auth'
|
|
import { PATCH as patchReorder } from '@/app/api/stories/[id]/tasks/reorder/route'
|
|
|
|
const mockPrisma = prisma as unknown as {
|
|
story: { findFirst: ReturnType<typeof vi.fn> }
|
|
task: { update: ReturnType<typeof vi.fn> }
|
|
$transaction: ReturnType<typeof vi.fn>
|
|
}
|
|
const mockAuth = authenticateApiRequest as ReturnType<typeof vi.fn>
|
|
|
|
function makeStory(taskIds: string[]) {
|
|
return {
|
|
id: 'story-1',
|
|
product_id: 'prod-1',
|
|
tasks: taskIds.map(id => ({ id })),
|
|
}
|
|
}
|
|
|
|
function makeRequest(body: unknown, storyId = 'story-1'): [Request, { params: Promise<{ id: string }> }] {
|
|
return [
|
|
new Request(`http://localhost/api/stories/${storyId}/tasks/reorder`, {
|
|
method: 'PATCH',
|
|
headers: { Authorization: 'Bearer test-token', 'Content-Type': 'application/json' },
|
|
body: JSON.stringify(body),
|
|
}),
|
|
{ params: Promise.resolve({ id: storyId }) },
|
|
]
|
|
}
|
|
|
|
describe('PATCH /api/stories/:id/tasks/reorder', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mockAuth.mockResolvedValue({ userId: 'user-1', isDemo: false })
|
|
mockPrisma.$transaction.mockResolvedValue([])
|
|
mockPrisma.task.update.mockResolvedValue({ id: 'task-1', sort_order: 1 })
|
|
})
|
|
|
|
// TC-RO-06 — body validation fires before story lookup
|
|
it('returns 422 when task_ids is an empty array', async () => {
|
|
const res = await patchReorder(...makeRequest({ task_ids: [] }))
|
|
expect(res.status).toBe(422)
|
|
expect(mockPrisma.story.findFirst).not.toHaveBeenCalled()
|
|
})
|
|
|
|
// TC-RO-07
|
|
it('returns 422 when task_ids is not an array', async () => {
|
|
const res = await patchReorder(...makeRequest({ task_ids: 'task-1' }))
|
|
expect(res.status).toBe(422)
|
|
expect(mockPrisma.story.findFirst).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('returns 422 when task_ids is missing entirely', async () => {
|
|
const res = await patchReorder(...makeRequest({}))
|
|
expect(res.status).toBe(422)
|
|
})
|
|
|
|
// TC-RO-08
|
|
it('returns 422 when task_ids contains an ID not belonging to the story', async () => {
|
|
mockPrisma.story.findFirst.mockResolvedValue(makeStory(['task-1', 'task-2']))
|
|
|
|
const res = await patchReorder(...makeRequest({ task_ids: ['task-1', 'task-from-other-story'] }))
|
|
const data = await res.json()
|
|
|
|
expect(res.status).toBe(422)
|
|
expect(data.error).toContain('task-from-other-story')
|
|
})
|
|
|
|
// TC-RO-09
|
|
it('reorders tasks and returns 200 with success: true', async () => {
|
|
mockPrisma.story.findFirst.mockResolvedValue(makeStory(['task-1', 'task-2', 'task-3']))
|
|
|
|
const res = await patchReorder(...makeRequest({ task_ids: ['task-3', 'task-1', 'task-2'] }))
|
|
const data = await res.json()
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(data).toEqual({ success: true })
|
|
expect(mockPrisma.$transaction).toHaveBeenCalled()
|
|
})
|
|
|
|
it('updates each task with its new sort_order index', async () => {
|
|
mockPrisma.story.findFirst.mockResolvedValue(makeStory(['task-1', 'task-2']))
|
|
|
|
await patchReorder(...makeRequest({ task_ids: ['task-2', 'task-1'] }))
|
|
|
|
expect(mockPrisma.task.update).toHaveBeenCalledWith(
|
|
expect.objectContaining({ where: { id: 'task-2' }, data: { sort_order: 1 } })
|
|
)
|
|
expect(mockPrisma.task.update).toHaveBeenCalledWith(
|
|
expect.objectContaining({ where: { id: 'task-1' }, data: { sort_order: 2 } })
|
|
)
|
|
})
|
|
})
|