* docs(ST-511): add backlog entry for entity codes feature Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): add createWithCodeRetry helper to handle P2002 race on auto codes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): retry on auto-code unique conflict in story and pbi create Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): surface field errors for code and title in PBI dialog Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-511): read create-state errors in Story dialog fieldError Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-512): add backlog entry for REST API code/description/implementation_plan extensions; mark ST-511 done Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-512): extend REST API with code, description and implementation_plan - GET /api/products returns code, description and definition_of_done - GET /api/products/:id/next-story returns story.code and per-task code + implementation_plan - GET /api/sprints/:id/tasks returns description, implementation_plan, story_code and derived per-task code - POST /api/todos accepts and returns optional description (max 2000) All changes are additive — existing clients ignore unknown keys. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-512): mark ST-512 as done Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-513): add backlog entry for API hardening for Claude Code Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add task and story status mappers for API boundary Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): expose lowercase status on API and accept lowercase in PATCH /api/tasks Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add metadata JSONB column to StoryLog Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): accept optional metadata in story log and switch validation errors to 422 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add GET /api/health endpoint with optional db ping Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(ST-513): add GET /api/products/:id/claude-context bundled endpoint Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-513): add docs/API.md and link from CLAUDE.md specs table Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(ST-513): mark ST-513 as done Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ST-513): split 400 (malformed JSON) from 422 (validation), reject 'review' Codex review on PR #2: - P2.1: routes treated JSON parse failures as 422 instead of 400, breaking the contract in docs/API.md. Replace `request.json().catch(() => null)` with try/catch in 4 routes (tasks, reorder, todos, story-log) so a malformed body returns 400 and only well-formed-but-invalid bodies return 422. - P2.2: PATCH /api/tasks/:id accepted `status: "review"`, but the sprint task list UI does not render REVIEW (no label/color, the cycle helper falls back to TO_DO). Reject `review` at the API until the sprint UI is extended; document the subset in docs/API.md. Tests in __tests__/api updated for the new contract (29 assertions: zod-failures now expect 422, status payloads use lowercase API values, sprint-tasks mocks include the new story relation). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
170 lines
5.9 KiB
TypeScript
170 lines
5.9 KiB
TypeScript
'use client'
|
|
|
|
import { useEffect, useRef, useState } from 'react'
|
|
import { useActionState } from 'react'
|
|
import { useFormStatus } from 'react-dom'
|
|
import { toast } from 'sonner'
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
DialogFooter,
|
|
DialogClose,
|
|
} from '@/components/ui/dialog'
|
|
import { Button } from '@/components/ui/button'
|
|
import { Input } from '@/components/ui/input'
|
|
import { Textarea } from '@/components/ui/textarea'
|
|
import { PrioritySelect } from '@/components/shared/priority-select'
|
|
import { createPbiAction, updatePbiAction } from '@/actions/pbis'
|
|
|
|
export interface PbiDialogPbi {
|
|
id: string
|
|
title: string
|
|
priority: number
|
|
description?: string | null
|
|
code?: string | null
|
|
}
|
|
|
|
type CreateState = { mode: 'create'; productId: string; defaultPriority?: number }
|
|
type EditState = { mode: 'edit'; pbi: PbiDialogPbi; productId: string }
|
|
export type PbiDialogState = CreateState | EditState
|
|
|
|
interface PbiDialogProps {
|
|
state: PbiDialogState | null
|
|
onClose: () => void
|
|
}
|
|
|
|
function SubmitButton({ label }: { label: string }) {
|
|
const { pending } = useFormStatus()
|
|
return (
|
|
<Button type="submit" disabled={pending}>
|
|
{pending ? '…' : label}
|
|
</Button>
|
|
)
|
|
}
|
|
|
|
export function PbiDialog({ state, onClose }: PbiDialogProps) {
|
|
const isEdit = state?.mode === 'edit'
|
|
const pbi = isEdit ? state.pbi : null
|
|
|
|
const initialPriority = isEdit ? pbi!.priority : (state?.defaultPriority ?? 2)
|
|
const [priority, setPriority] = useState<number>(initialPriority)
|
|
|
|
// Sync priority when dialog opens for a different PBI or switches create/edit mode
|
|
useEffect(() => {
|
|
if (state) {
|
|
// eslint-disable-next-line react-hooks/set-state-in-effect
|
|
setPriority(isEdit ? (state as EditState).pbi.priority : ((state as CreateState).defaultPriority ?? 2))
|
|
}
|
|
}, [state, isEdit])
|
|
|
|
const [createState, createAction] = useActionState(
|
|
async (_prev: unknown, fd: FormData) => {
|
|
const result = await createPbiAction(_prev, fd)
|
|
if (result?.success) { toast.success('PBI aangemaakt'); onClose() }
|
|
else if (typeof result?.error === 'string') toast.error(result.error)
|
|
return result
|
|
},
|
|
undefined
|
|
)
|
|
|
|
const [updateState, updateAction] = useActionState(
|
|
async (_prev: unknown, fd: FormData) => {
|
|
const result = await updatePbiAction(_prev, fd)
|
|
if (result?.success) { toast.success('PBI opgeslagen'); onClose() }
|
|
else if (typeof result?.error === 'string') toast.error(result.error)
|
|
return result
|
|
},
|
|
undefined
|
|
)
|
|
|
|
const activeState = isEdit ? updateState : createState
|
|
const error = typeof activeState?.error === 'string' ? activeState.error : null
|
|
const fieldError = (field: string) => {
|
|
const err = activeState?.error
|
|
if (!err || typeof err === 'string') return undefined
|
|
return (err as Record<string, string[]>)[field]?.[0]
|
|
}
|
|
|
|
const titleRef = useRef<HTMLInputElement>(null)
|
|
useEffect(() => {
|
|
if (state) {
|
|
setTimeout(() => titleRef.current?.focus(), 50)
|
|
}
|
|
}, [state])
|
|
|
|
return (
|
|
<Dialog open={!!state} onOpenChange={(open) => { if (!open) onClose() }}>
|
|
<DialogContent className="sm:max-w-md">
|
|
<DialogHeader>
|
|
<DialogTitle>{isEdit ? 'PBI bewerken' : 'Nieuw PBI'}</DialogTitle>
|
|
</DialogHeader>
|
|
|
|
<form key={isEdit ? pbi!.id : 'create'} action={isEdit ? updateAction : createAction} className="grid gap-4">
|
|
{isEdit && <input type="hidden" name="id" value={pbi!.id} />}
|
|
{!isEdit && <input type="hidden" name="productId" value={(state as CreateState | null)?.productId ?? ''} />}
|
|
<input type="hidden" name="priority" value={priority} />
|
|
|
|
<div className="grid grid-cols-[6rem_1fr] gap-3">
|
|
<div className="grid gap-1.5">
|
|
<label htmlFor="pbi-code" className="text-sm font-medium">Code</label>
|
|
<Input
|
|
id="pbi-code"
|
|
name="code"
|
|
defaultValue={pbi?.code ?? ''}
|
|
placeholder={isEdit ? '' : 'auto'}
|
|
maxLength={30}
|
|
className={fieldError('code') ? 'font-mono text-sm border-error' : 'font-mono text-sm'}
|
|
/>
|
|
{fieldError('code') && <p className="text-xs text-error">{fieldError('code')}</p>}
|
|
</div>
|
|
<div className="grid gap-1.5">
|
|
<label htmlFor="pbi-title" className="text-sm font-medium">Titel</label>
|
|
<Input
|
|
id="pbi-title"
|
|
ref={titleRef}
|
|
name="title"
|
|
defaultValue={pbi?.title ?? ''}
|
|
placeholder="PBI-titel…"
|
|
required
|
|
maxLength={200}
|
|
className={fieldError('title') ? 'border-error' : ''}
|
|
/>
|
|
{fieldError('title') && <p className="text-xs text-error">{fieldError('title')}</p>}
|
|
</div>
|
|
</div>
|
|
|
|
<div className="grid gap-1.5">
|
|
<label className="text-sm font-medium">Prioriteit</label>
|
|
<PrioritySelect value={priority} onChange={setPriority} />
|
|
</div>
|
|
|
|
<div className="grid gap-1.5">
|
|
<label htmlFor="pbi-description" className="text-sm font-medium">
|
|
Beschrijving <span className="text-muted-foreground font-normal">(optioneel)</span>
|
|
</label>
|
|
<Textarea
|
|
id="pbi-description"
|
|
name="description"
|
|
defaultValue={pbi?.description ?? ''}
|
|
placeholder="Korte omschrijving van het PBI…"
|
|
rows={3}
|
|
maxLength={2000}
|
|
className="resize-none"
|
|
/>
|
|
</div>
|
|
|
|
{error && <p className="text-xs text-error">{error}</p>}
|
|
|
|
<DialogFooter>
|
|
<DialogClose render={<Button type="button" variant="outline" />}>
|
|
Annuleren
|
|
</DialogClose>
|
|
<SubmitButton label={isEdit ? 'Opslaan' : 'Aanmaken'} />
|
|
</DialogFooter>
|
|
</form>
|
|
</DialogContent>
|
|
</Dialog>
|
|
)
|
|
}
|