Schema-uitbreidingen voor de sprint-niveau jobflow (PBI-46): - TaskStatus, StoryStatus, PbiStatus, SprintStatus krijgen FAILED - Nieuwe enums: SprintRunStatus, PrStrategy - Nieuw SprintRun-model dat per-task ClaudeJobs groepeert - ClaudeJob.sprint_run_id koppeling + index - Product.pr_strategy (default SPRINT) - Bijhorende Prisma-migratie propagateStatusUpwards vervangt updateTaskStatusWithStoryPromotion en herevalueert de keten Task → Story → PBI → Sprint → SprintRun bij elke task-statuswijziging. Bij FAILED cancelt het sibling-jobs in dezelfde SprintRun. PBI-status BLOCKED blijft handmatig en wordt niet overschreven. Status-mappers + theme krijgen failed-token + label-uitbreidingen. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
335 lines
12 KiB
TypeScript
335 lines
12 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
vi.mock('@/lib/prisma', () => ({
|
|
prisma: {
|
|
task: {
|
|
update: vi.fn(),
|
|
findMany: vi.fn(),
|
|
},
|
|
story: {
|
|
findUniqueOrThrow: vi.fn(),
|
|
findMany: vi.fn(),
|
|
update: vi.fn(),
|
|
},
|
|
pbi: {
|
|
findUniqueOrThrow: vi.fn(),
|
|
update: vi.fn(),
|
|
},
|
|
sprint: {
|
|
findUniqueOrThrow: vi.fn(),
|
|
update: vi.fn(),
|
|
},
|
|
claudeJob: {
|
|
findFirst: vi.fn(),
|
|
updateMany: vi.fn(),
|
|
},
|
|
sprintRun: {
|
|
findUnique: vi.fn(),
|
|
update: vi.fn(),
|
|
},
|
|
$transaction: vi.fn(),
|
|
},
|
|
}))
|
|
|
|
import { prisma } from '@/lib/prisma'
|
|
import { propagateStatusUpwards } from '@/lib/tasks-status-update'
|
|
|
|
type MockedPrisma = {
|
|
task: { update: ReturnType<typeof vi.fn>; findMany: ReturnType<typeof vi.fn> }
|
|
story: {
|
|
findUniqueOrThrow: ReturnType<typeof vi.fn>
|
|
findMany: ReturnType<typeof vi.fn>
|
|
update: ReturnType<typeof vi.fn>
|
|
}
|
|
pbi: {
|
|
findUniqueOrThrow: ReturnType<typeof vi.fn>
|
|
update: ReturnType<typeof vi.fn>
|
|
}
|
|
sprint: {
|
|
findUniqueOrThrow: ReturnType<typeof vi.fn>
|
|
update: ReturnType<typeof vi.fn>
|
|
}
|
|
claudeJob: {
|
|
findFirst: ReturnType<typeof vi.fn>
|
|
updateMany: ReturnType<typeof vi.fn>
|
|
}
|
|
sprintRun: {
|
|
findUnique: ReturnType<typeof vi.fn>
|
|
update: ReturnType<typeof vi.fn>
|
|
}
|
|
$transaction: ReturnType<typeof vi.fn>
|
|
}
|
|
|
|
const mockPrisma = prisma as unknown as MockedPrisma
|
|
|
|
const TASK_BASE = {
|
|
id: 'task-1',
|
|
title: 'Task',
|
|
story_id: 'story-1',
|
|
implementation_plan: null,
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mockPrisma.$transaction.mockImplementation(
|
|
async (run: (tx: typeof prisma) => Promise<unknown>) => run(prisma),
|
|
)
|
|
})
|
|
|
|
describe('propagateStatusUpwards — story-niveau', () => {
|
|
it('zet story op DONE wanneer alle siblings DONE zijn', async () => {
|
|
mockPrisma.task.update.mockResolvedValue({ ...TASK_BASE, status: 'DONE' })
|
|
mockPrisma.task.findMany.mockResolvedValue([
|
|
{ status: 'DONE' },
|
|
{ status: 'DONE' },
|
|
])
|
|
mockPrisma.story.findUniqueOrThrow.mockResolvedValue({
|
|
id: 'story-1',
|
|
status: 'IN_SPRINT',
|
|
pbi_id: 'pbi-1',
|
|
sprint_id: null,
|
|
})
|
|
mockPrisma.pbi.findUniqueOrThrow.mockResolvedValue({ id: 'pbi-1', status: 'READY' })
|
|
mockPrisma.story.findMany.mockResolvedValue([{ status: 'DONE' }])
|
|
|
|
const result = await propagateStatusUpwards('task-1', 'DONE')
|
|
|
|
expect(result.storyChanged).toBe(true)
|
|
expect(mockPrisma.story.update).toHaveBeenCalledWith({
|
|
where: { id: 'story-1' },
|
|
data: { status: 'DONE' },
|
|
})
|
|
})
|
|
|
|
it('zet story op FAILED wanneer een task FAILED is, ongeacht andere tasks', async () => {
|
|
mockPrisma.task.update.mockResolvedValue({ ...TASK_BASE, status: 'FAILED' })
|
|
mockPrisma.task.findMany.mockResolvedValue([
|
|
{ status: 'FAILED' },
|
|
{ status: 'DONE' },
|
|
{ status: 'TO_DO' },
|
|
])
|
|
mockPrisma.story.findUniqueOrThrow.mockResolvedValue({
|
|
id: 'story-1',
|
|
status: 'IN_SPRINT',
|
|
pbi_id: 'pbi-1',
|
|
sprint_id: null,
|
|
})
|
|
mockPrisma.pbi.findUniqueOrThrow.mockResolvedValue({ id: 'pbi-1', status: 'READY' })
|
|
mockPrisma.story.findMany.mockResolvedValue([{ status: 'FAILED' }])
|
|
|
|
const result = await propagateStatusUpwards('task-1', 'FAILED')
|
|
|
|
expect(result.storyChanged).toBe(true)
|
|
expect(mockPrisma.story.update).toHaveBeenCalledWith({
|
|
where: { id: 'story-1' },
|
|
data: { status: 'FAILED' },
|
|
})
|
|
})
|
|
|
|
it('houdt story op IN_SPRINT als nog niet alle tasks DONE en geen FAILED', async () => {
|
|
mockPrisma.task.update.mockResolvedValue({ ...TASK_BASE, status: 'DONE' })
|
|
mockPrisma.task.findMany.mockResolvedValue([
|
|
{ status: 'DONE' },
|
|
{ status: 'TO_DO' },
|
|
])
|
|
mockPrisma.story.findUniqueOrThrow.mockResolvedValue({
|
|
id: 'story-1',
|
|
status: 'IN_SPRINT',
|
|
pbi_id: 'pbi-1',
|
|
sprint_id: 'sprint-1',
|
|
})
|
|
mockPrisma.pbi.findUniqueOrThrow.mockResolvedValue({ id: 'pbi-1', status: 'READY' })
|
|
mockPrisma.story.findMany.mockImplementation(async (args: { where?: { pbi_id?: string; sprint_id?: string } }) => {
|
|
if (args.where?.pbi_id) return [{ status: 'IN_SPRINT' }]
|
|
if (args.where?.sprint_id) return [{ pbi_id: 'pbi-1' }]
|
|
return []
|
|
})
|
|
mockPrisma.sprint.findUniqueOrThrow.mockResolvedValue({ id: 'sprint-1', status: 'ACTIVE' })
|
|
;(mockPrisma.pbi as unknown as { findMany: ReturnType<typeof vi.fn> }).findMany = vi.fn().mockResolvedValue([{ status: 'READY' }])
|
|
|
|
const result = await propagateStatusUpwards('task-1', 'DONE')
|
|
|
|
expect(result.storyChanged).toBe(false)
|
|
expect(mockPrisma.story.update).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('demoot story uit DONE als een task terug naar TO_DO gaat', async () => {
|
|
mockPrisma.task.update.mockResolvedValue({ ...TASK_BASE, status: 'TO_DO' })
|
|
mockPrisma.task.findMany.mockResolvedValue([
|
|
{ status: 'TO_DO' },
|
|
{ status: 'DONE' },
|
|
])
|
|
mockPrisma.story.findUniqueOrThrow.mockResolvedValue({
|
|
id: 'story-1',
|
|
status: 'DONE',
|
|
pbi_id: 'pbi-1',
|
|
sprint_id: 'sprint-1',
|
|
})
|
|
mockPrisma.pbi.findUniqueOrThrow.mockResolvedValue({ id: 'pbi-1', status: 'DONE' })
|
|
mockPrisma.story.findMany.mockImplementation(async (args: { where?: { pbi_id?: string; sprint_id?: string } }) => {
|
|
if (args.where?.pbi_id) return [{ status: 'IN_SPRINT' }, { status: 'DONE' }]
|
|
if (args.where?.sprint_id) return [{ pbi_id: 'pbi-1' }]
|
|
return []
|
|
})
|
|
mockPrisma.sprint.findUniqueOrThrow.mockResolvedValue({ id: 'sprint-1', status: 'COMPLETED' })
|
|
;(mockPrisma.pbi as unknown as { findMany: ReturnType<typeof vi.fn> }).findMany = vi.fn().mockResolvedValue([{ status: 'READY' }])
|
|
|
|
const result = await propagateStatusUpwards('task-1', 'TO_DO')
|
|
|
|
expect(result.storyChanged).toBe(true)
|
|
expect(mockPrisma.story.update).toHaveBeenCalledWith({
|
|
where: { id: 'story-1' },
|
|
data: { status: 'IN_SPRINT' },
|
|
})
|
|
})
|
|
|
|
it('zet story op OPEN als sprint_id null is en niet DONE/FAILED', async () => {
|
|
mockPrisma.task.update.mockResolvedValue({ ...TASK_BASE, status: 'IN_PROGRESS' })
|
|
mockPrisma.task.findMany.mockResolvedValue([{ status: 'IN_PROGRESS' }])
|
|
mockPrisma.story.findUniqueOrThrow.mockResolvedValue({
|
|
id: 'story-1',
|
|
status: 'IN_SPRINT',
|
|
pbi_id: 'pbi-1',
|
|
sprint_id: null,
|
|
})
|
|
mockPrisma.pbi.findUniqueOrThrow.mockResolvedValue({ id: 'pbi-1', status: 'READY' })
|
|
mockPrisma.story.findMany.mockResolvedValue([{ status: 'OPEN' }])
|
|
|
|
const result = await propagateStatusUpwards('task-1', 'IN_PROGRESS')
|
|
|
|
expect(result.storyChanged).toBe(true)
|
|
expect(mockPrisma.story.update).toHaveBeenCalledWith({
|
|
where: { id: 'story-1' },
|
|
data: { status: 'OPEN' },
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('propagateStatusUpwards — PBI BLOCKED met rust laten', () => {
|
|
it('overschrijft een handmatig BLOCKED PBI niet', async () => {
|
|
mockPrisma.task.update.mockResolvedValue({ ...TASK_BASE, status: 'DONE' })
|
|
mockPrisma.task.findMany.mockResolvedValue([{ status: 'DONE' }])
|
|
mockPrisma.story.findUniqueOrThrow.mockResolvedValue({
|
|
id: 'story-1',
|
|
status: 'IN_SPRINT',
|
|
pbi_id: 'pbi-1',
|
|
sprint_id: null,
|
|
})
|
|
mockPrisma.pbi.findUniqueOrThrow.mockResolvedValue({ id: 'pbi-1', status: 'BLOCKED' })
|
|
|
|
const result = await propagateStatusUpwards('task-1', 'DONE')
|
|
|
|
expect(result.pbiChanged).toBe(false)
|
|
expect(mockPrisma.pbi.update).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
|
|
describe('propagateStatusUpwards — sprint cascade tot SprintRun', () => {
|
|
it('zet bij FAILED de hele keten op FAILED en cancelt sibling-jobs', async () => {
|
|
mockPrisma.task.update.mockResolvedValue({ ...TASK_BASE, status: 'FAILED' })
|
|
mockPrisma.task.findMany.mockResolvedValue([
|
|
{ status: 'FAILED' },
|
|
{ status: 'DONE' },
|
|
])
|
|
mockPrisma.story.findUniqueOrThrow.mockResolvedValue({
|
|
id: 'story-1',
|
|
status: 'IN_SPRINT',
|
|
pbi_id: 'pbi-1',
|
|
sprint_id: 'sprint-1',
|
|
})
|
|
mockPrisma.pbi.findUniqueOrThrow.mockResolvedValue({ id: 'pbi-1', status: 'READY' })
|
|
mockPrisma.story.findMany.mockImplementation(async (args: { where?: { pbi_id?: string; sprint_id?: string } }) => {
|
|
if (args.where?.pbi_id) return [{ status: 'FAILED' }]
|
|
if (args.where?.sprint_id) return [{ pbi_id: 'pbi-1' }]
|
|
return []
|
|
})
|
|
mockPrisma.sprint.findUniqueOrThrow.mockResolvedValue({ id: 'sprint-1', status: 'ACTIVE' })
|
|
// findMany on pbi:
|
|
;(mockPrisma.pbi as unknown as { findMany: ReturnType<typeof vi.fn> }).findMany = vi.fn().mockResolvedValue([{ status: 'FAILED' }])
|
|
mockPrisma.claudeJob.findFirst.mockResolvedValue({ id: 'job-1', sprint_run_id: 'run-1' })
|
|
mockPrisma.sprintRun.findUnique.mockResolvedValue({ id: 'run-1', status: 'RUNNING' })
|
|
|
|
const result = await propagateStatusUpwards('task-1', 'FAILED')
|
|
|
|
expect(result.storyChanged).toBe(true)
|
|
expect(result.pbiChanged).toBe(true)
|
|
expect(result.sprintChanged).toBe(true)
|
|
expect(result.sprintRunChanged).toBe(true)
|
|
|
|
expect(mockPrisma.sprintRun.update).toHaveBeenCalledWith(expect.objectContaining({
|
|
where: { id: 'run-1' },
|
|
data: expect.objectContaining({ status: 'FAILED', failed_task_id: 'task-1' }),
|
|
}))
|
|
expect(mockPrisma.claudeJob.updateMany).toHaveBeenCalledWith(expect.objectContaining({
|
|
where: expect.objectContaining({
|
|
sprint_run_id: 'run-1',
|
|
status: { in: ['QUEUED', 'CLAIMED', 'RUNNING'] },
|
|
id: { not: 'job-1' },
|
|
}),
|
|
data: expect.objectContaining({ status: 'CANCELLED' }),
|
|
}))
|
|
})
|
|
|
|
it('zet bij alle DONE de SprintRun op DONE en Sprint op COMPLETED', async () => {
|
|
mockPrisma.task.update.mockResolvedValue({ ...TASK_BASE, status: 'DONE' })
|
|
mockPrisma.task.findMany.mockResolvedValue([{ status: 'DONE' }])
|
|
mockPrisma.story.findUniqueOrThrow.mockResolvedValue({
|
|
id: 'story-1',
|
|
status: 'IN_SPRINT',
|
|
pbi_id: 'pbi-1',
|
|
sprint_id: 'sprint-1',
|
|
})
|
|
mockPrisma.pbi.findUniqueOrThrow.mockResolvedValue({ id: 'pbi-1', status: 'READY' })
|
|
mockPrisma.story.findMany.mockImplementation(async (args: { where?: { pbi_id?: string; sprint_id?: string } }) => {
|
|
if (args.where?.pbi_id) return [{ status: 'DONE' }]
|
|
if (args.where?.sprint_id) return [{ pbi_id: 'pbi-1' }]
|
|
return []
|
|
})
|
|
mockPrisma.sprint.findUniqueOrThrow.mockResolvedValue({ id: 'sprint-1', status: 'ACTIVE' })
|
|
;(mockPrisma.pbi as unknown as { findMany: ReturnType<typeof vi.fn> }).findMany = vi.fn().mockResolvedValue([{ status: 'DONE' }])
|
|
mockPrisma.claudeJob.findFirst.mockResolvedValue({ id: 'job-1', sprint_run_id: 'run-1' })
|
|
mockPrisma.sprintRun.findUnique.mockResolvedValue({ id: 'run-1', status: 'RUNNING' })
|
|
|
|
const result = await propagateStatusUpwards('task-1', 'DONE')
|
|
|
|
expect(result.sprintRunChanged).toBe(true)
|
|
expect(mockPrisma.sprint.update).toHaveBeenCalledWith(expect.objectContaining({
|
|
where: { id: 'sprint-1' },
|
|
data: expect.objectContaining({ status: 'COMPLETED' }),
|
|
}))
|
|
expect(mockPrisma.sprintRun.update).toHaveBeenCalledWith(expect.objectContaining({
|
|
where: { id: 'run-1' },
|
|
data: expect.objectContaining({ status: 'DONE' }),
|
|
}))
|
|
})
|
|
})
|
|
|
|
describe('propagateStatusUpwards — transactionele aanroep', () => {
|
|
it('gebruikt de meegegeven transaction client', async () => {
|
|
const tx = {
|
|
task: { update: vi.fn(), findMany: vi.fn() },
|
|
story: { findUniqueOrThrow: vi.fn(), findMany: vi.fn(), update: vi.fn() },
|
|
pbi: { findUniqueOrThrow: vi.fn(), findMany: vi.fn(), update: vi.fn() },
|
|
sprint: { findUniqueOrThrow: vi.fn(), update: vi.fn() },
|
|
claudeJob: { findFirst: vi.fn(), updateMany: vi.fn() },
|
|
sprintRun: { findUnique: vi.fn(), update: vi.fn() },
|
|
}
|
|
tx.task.update.mockResolvedValue({ ...TASK_BASE, status: 'IN_PROGRESS' })
|
|
tx.task.findMany.mockResolvedValue([{ status: 'IN_PROGRESS' }])
|
|
tx.story.findUniqueOrThrow.mockResolvedValue({
|
|
id: 'story-1',
|
|
status: 'OPEN',
|
|
pbi_id: 'pbi-1',
|
|
sprint_id: null,
|
|
})
|
|
tx.pbi.findUniqueOrThrow.mockResolvedValue({ id: 'pbi-1', status: 'READY' })
|
|
tx.story.findMany.mockResolvedValue([{ status: 'OPEN' }])
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const result = await propagateStatusUpwards('task-1', 'IN_PROGRESS', tx as any)
|
|
|
|
expect(result.storyChanged).toBe(false)
|
|
// $transaction wordt niet aangeroepen wanneer caller al een tx meegeeft.
|
|
expect(mockPrisma.$transaction).not.toHaveBeenCalled()
|
|
})
|
|
})
|