- lib/user-settings.ts: activeSprints values nullable in Zod-schema. Key-aanwezigheid heeft nu betekenis (key+null = bewust geen sprint; key ontbreekt = fallback-cascade). - lib/active-sprint.ts: nieuwe readStoredActiveSprintState helper + resolveActiveSprint respecteert expliciet 'cleared' state zonder fallback. clearActiveSprintInSettings schrijft null i.p.v. de key te verwijderen. - actions/active-sprint.ts: nieuwe clearActiveSprintAction met auth + membership-check. - components/shared/sprint-switcher.tsx: '— Geen actieve sprint —'-optie in dropdown, disabled wanneer er geen actieve sprint is. - Tests: nieuwe active-sprint.test.ts (resolver-paden + clear), active-sprint-action.test.ts (action-laag), uitbreiding user-settings.test.ts. Plan: docs/plans/PBI-79-backlog-sprint-workflow.md Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
138 lines
4.3 KiB
TypeScript
138 lines
4.3 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import {
|
|
DEFAULT_USER_SETTINGS,
|
|
UserSettingsSchema,
|
|
mergeSettings,
|
|
parseUserSettings,
|
|
type UserSettings,
|
|
} from '@/lib/user-settings'
|
|
|
|
describe('mergeSettings', () => {
|
|
it('returns the patch when previous is empty', () => {
|
|
const result = mergeSettings({}, { views: { sprintBacklog: { sort: 'code' } } })
|
|
expect(result).toEqual({ views: { sprintBacklog: { sort: 'code' } } })
|
|
})
|
|
|
|
it('preserves existing keys when patch only sets new ones', () => {
|
|
const prev: UserSettings = { views: { sprintBacklog: { sort: 'code' } } }
|
|
const result = mergeSettings(prev, {
|
|
views: { pbiList: { sort: 'date' } },
|
|
})
|
|
expect(result).toEqual({
|
|
views: {
|
|
sprintBacklog: { sort: 'code' },
|
|
pbiList: { sort: 'date' },
|
|
},
|
|
})
|
|
})
|
|
|
|
it('merges nested objects without overwriting siblings', () => {
|
|
const prev: UserSettings = {
|
|
views: { sprintBacklog: { sort: 'code', sortDir: 'asc' } },
|
|
}
|
|
const result = mergeSettings(prev, {
|
|
views: { sprintBacklog: { sort: 'priority' } },
|
|
})
|
|
expect(result).toEqual({
|
|
views: { sprintBacklog: { sort: 'priority', sortDir: 'asc' } },
|
|
})
|
|
})
|
|
|
|
it('replaces arrays instead of appending', () => {
|
|
const prev: UserSettings = {
|
|
views: { sprintBacklog: { collapsedPbis: ['a', 'b'] } },
|
|
}
|
|
const result = mergeSettings(prev, {
|
|
views: { sprintBacklog: { collapsedPbis: ['c'] } },
|
|
})
|
|
expect(result.views?.sprintBacklog?.collapsedPbis).toEqual(['c'])
|
|
})
|
|
|
|
it('does not mutate the previous object', () => {
|
|
const prev: UserSettings = { views: { sprintBacklog: { sort: 'code' } } }
|
|
const snapshot = JSON.parse(JSON.stringify(prev))
|
|
mergeSettings(prev, { views: { sprintBacklog: { sortDir: 'desc' } } })
|
|
expect(prev).toEqual(snapshot)
|
|
})
|
|
|
|
it('skips undefined values in the patch', () => {
|
|
const prev: UserSettings = { views: { sprintBacklog: { sort: 'code' } } }
|
|
const result = mergeSettings(prev, { views: undefined })
|
|
expect(result).toEqual(prev)
|
|
})
|
|
})
|
|
|
|
describe('parseUserSettings', () => {
|
|
it('returns defaults for null', () => {
|
|
expect(parseUserSettings(null)).toEqual(DEFAULT_USER_SETTINGS)
|
|
})
|
|
|
|
it('returns defaults for undefined', () => {
|
|
expect(parseUserSettings(undefined)).toEqual(DEFAULT_USER_SETTINGS)
|
|
})
|
|
|
|
it('returns defaults for invalid input', () => {
|
|
expect(parseUserSettings({ views: { sprintBacklog: { filterStatus: 'BOGUS' } } }))
|
|
.toEqual(DEFAULT_USER_SETTINGS)
|
|
})
|
|
|
|
it('passes valid settings through', () => {
|
|
const valid = { views: { sprintBacklog: { sort: 'code' as const } } }
|
|
expect(parseUserSettings(valid)).toEqual(valid)
|
|
})
|
|
})
|
|
|
|
describe('UserSettingsSchema', () => {
|
|
it('rejects unknown top-level keys', () => {
|
|
const result = UserSettingsSchema.safeParse({ unknown: 1 })
|
|
expect(result.success).toBe(false)
|
|
})
|
|
|
|
it('accepts an empty object', () => {
|
|
expect(UserSettingsSchema.safeParse({}).success).toBe(true)
|
|
})
|
|
|
|
it('accepts the full shape', () => {
|
|
const result = UserSettingsSchema.safeParse({
|
|
views: {
|
|
sprintBacklog: {
|
|
filterPriority: 1,
|
|
filterStatus: 'OPEN',
|
|
sort: 'code',
|
|
sortDir: 'asc',
|
|
collapsedPbis: ['x'],
|
|
filterPopoverOpen: true,
|
|
},
|
|
pbiList: { sort: 'priority', filterPriority: 'all', filterStatus: 'ready', sortDir: 'desc' },
|
|
storyPanel: { sort: 'date' },
|
|
jobsColumns: { 'queue:active': { kinds: ['TASK_IMPLEMENTATION'], statuses: [] } },
|
|
},
|
|
devTools: { debugMode: true },
|
|
layout: {
|
|
splitPanePositions: { 'backlog-pid': [25, 35, 40] },
|
|
activeSprints: { 'product-1': 'sprint-1' },
|
|
},
|
|
})
|
|
expect(result.success).toBe(true)
|
|
})
|
|
|
|
it('accepts layout-only settings', () => {
|
|
expect(UserSettingsSchema.safeParse({
|
|
layout: { splitPanePositions: { x: [50, 50] }, activeSprints: { p: 's' } },
|
|
}).success).toBe(true)
|
|
})
|
|
|
|
it('accepts null values in activeSprints (explicit "no active sprint")', () => {
|
|
const result = UserSettingsSchema.safeParse({
|
|
layout: { activeSprints: { 'product-1': null, 'product-2': 'sprint-2' } },
|
|
})
|
|
expect(result.success).toBe(true)
|
|
if (result.success) {
|
|
expect(result.data.layout?.activeSprints).toEqual({
|
|
'product-1': null,
|
|
'product-2': 'sprint-2',
|
|
})
|
|
}
|
|
})
|
|
})
|