* fix(ideas): respecteer YAML-volgorde bij plan-materialize Tasks erven nu story-priority i.p.v. eigen task.priority bij materializeIdeaPlanAction. Worker sorteert op `priority ASC, sort_order ASC`; gemixte task-priorities binnen één story zouden anders de YAML-volgorde verstoren (e.g. tasks met priority 1/1/1/2/1/2 → worker-volgorde 1,2,3,5,4,6 i.p.v. 1,2,3,4,5,6). - actions/ideas.ts: priority = s.priority bij task-create - lib/schemas/idea.ts: task.priority optional (geaccepteerd, genegeerd) - lib/idea-prompts/make-plan.md: documenteer dat task.priority genegeerd wordt - __tests__/lib/idea-schemas.test.ts: test dat omitted task.priority slaagt Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(make-plan): documenteer backtick-format voor implementation_plan-paden verify_task_against_plan extraheert paden uit implementation_plan via twee regex-patronen (backticks + bullet). Paden inline in genummerde tekst-stappen worden niet herkend → planPaths.length=0 → bij diff >50 regels DIVERGENT. Voeg sectie "Bestandspaden in implementation_plan — verplicht format" toe die uitlegt welke formats werken (backticks, bullets) en welke niet (inline). Plus verband met verify_required-keuze: default ALIGNED_OR_PARTIAL behouden voor ADR-stubs en multi-file edits. Voorkomt herhaling van T-963 cancelled_by_self-symptoom waar implementatie slaagde maar verifier DIVERGENT teruggaf. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
148 lines
3.9 KiB
TypeScript
148 lines
3.9 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
|
|
import {
|
|
ideaCreateSchema,
|
|
ideaUpdateSchema,
|
|
ideaPlanMdFrontmatterSchema,
|
|
} from '@/lib/schemas/idea'
|
|
|
|
describe('ideaCreateSchema', () => {
|
|
it('accepts minimal valid input', () => {
|
|
const r = ideaCreateSchema.safeParse({ title: 'Plant-watering reminder' })
|
|
expect(r.success).toBe(true)
|
|
})
|
|
|
|
it('trims and enforces non-empty title', () => {
|
|
const r = ideaCreateSchema.safeParse({ title: ' ' })
|
|
expect(r.success).toBe(false)
|
|
})
|
|
|
|
it('rejects oversized title and description', () => {
|
|
expect(ideaCreateSchema.safeParse({ title: 'x'.repeat(201) }).success).toBe(false)
|
|
expect(
|
|
ideaCreateSchema.safeParse({ title: 'ok', description: 'x'.repeat(4001) }).success,
|
|
).toBe(false)
|
|
})
|
|
|
|
it('accepts cuid-like product_id', () => {
|
|
const r = ideaCreateSchema.safeParse({
|
|
title: 'Idee',
|
|
product_id: 'cmohrysyj0000rd17clnjy4tc',
|
|
})
|
|
expect(r.success).toBe(true)
|
|
})
|
|
|
|
it('rejects non-cuid product_id', () => {
|
|
const r = ideaCreateSchema.safeParse({ title: 'Idee', product_id: 'not-a-cuid' })
|
|
expect(r.success).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('ideaUpdateSchema', () => {
|
|
it('allows empty object (no-op update)', () => {
|
|
expect(ideaUpdateSchema.safeParse({}).success).toBe(true)
|
|
})
|
|
|
|
it('allows partial title update', () => {
|
|
expect(ideaUpdateSchema.safeParse({ title: 'Updated' }).success).toBe(true)
|
|
})
|
|
})
|
|
|
|
describe('ideaPlanMdFrontmatterSchema', () => {
|
|
const validPlan = {
|
|
pbi: { title: 'Test PBI', priority: 2 },
|
|
stories: [
|
|
{
|
|
title: 'Eerste flow',
|
|
priority: 2,
|
|
tasks: [
|
|
{ title: 'Setup', priority: 2, implementation_plan: '1. Doe X' },
|
|
],
|
|
},
|
|
],
|
|
}
|
|
|
|
it('accepts a minimal valid plan', () => {
|
|
expect(ideaPlanMdFrontmatterSchema.safeParse(validPlan).success).toBe(true)
|
|
})
|
|
|
|
it('requires at least one story', () => {
|
|
const r = ideaPlanMdFrontmatterSchema.safeParse({ ...validPlan, stories: [] })
|
|
expect(r.success).toBe(false)
|
|
})
|
|
|
|
it('requires at least one task per story', () => {
|
|
const r = ideaPlanMdFrontmatterSchema.safeParse({
|
|
...validPlan,
|
|
stories: [{ ...validPlan.stories[0], tasks: [] }],
|
|
})
|
|
expect(r.success).toBe(false)
|
|
})
|
|
|
|
it('validates priority bounds 1-4', () => {
|
|
expect(
|
|
ideaPlanMdFrontmatterSchema.safeParse({
|
|
...validPlan,
|
|
pbi: { ...validPlan.pbi, priority: 5 },
|
|
}).success,
|
|
).toBe(false)
|
|
expect(
|
|
ideaPlanMdFrontmatterSchema.safeParse({
|
|
...validPlan,
|
|
pbi: { ...validPlan.pbi, priority: 0 },
|
|
}).success,
|
|
).toBe(false)
|
|
})
|
|
|
|
it('accepts optional verify_required + verify_only', () => {
|
|
const r = ideaPlanMdFrontmatterSchema.safeParse({
|
|
...validPlan,
|
|
stories: [
|
|
{
|
|
...validPlan.stories[0],
|
|
tasks: [
|
|
{
|
|
title: 'Verify-only task',
|
|
priority: 2,
|
|
verify_required: 'ALIGNED_OR_PARTIAL',
|
|
verify_only: true,
|
|
},
|
|
],
|
|
},
|
|
],
|
|
})
|
|
expect(r.success).toBe(true)
|
|
})
|
|
|
|
it('rejects invalid verify_required enum', () => {
|
|
const r = ideaPlanMdFrontmatterSchema.safeParse({
|
|
...validPlan,
|
|
stories: [
|
|
{
|
|
...validPlan.stories[0],
|
|
tasks: [
|
|
{ title: 't', priority: 2, verify_required: 'INVALID' },
|
|
],
|
|
},
|
|
],
|
|
})
|
|
expect(r.success).toBe(false)
|
|
})
|
|
|
|
it('accepts plan with task.priority omitted (inherits story-priority via materialize)', () => {
|
|
const r = ideaPlanMdFrontmatterSchema.safeParse({
|
|
...validPlan,
|
|
stories: [
|
|
{
|
|
title: 'Story zonder task-priorities',
|
|
priority: 2,
|
|
tasks: [
|
|
{ title: 'Taak 1' }, // geen priority — moet geaccepteerd
|
|
{ title: 'Taak 2', verify_required: 'ALIGNED' },
|
|
],
|
|
},
|
|
],
|
|
})
|
|
expect(r.success).toBe(true)
|
|
})
|
|
})
|