* feat(PBI-49): add debugProps helper + Vitest test
Adds lib/debug.ts with debugProps(id, component, file) that returns
data-debug-id and data-debug-label attrs in dev mode, empty object in
production. Adds __tests__/lib/debug.test.ts covering both modes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs(PBI-49): add debug-id pattern doc + CLAUDE.md reference
Adds docs/patterns/debug-id.md documenting the named-component boundary
rule (6 punten), helper-voorbeeld, skip-criteria en motivatie voor
handmatige pad-argumenten. Voegt verwijzing toe aan CLAUDE.md
patterns-tabel.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* refactor(PBI-49): migrate 17 shared/ components to debugProps helper
Replace hardcoded data-debug-id + data-debug-label attribute pairs with
{...debugProps(id, component, file)} spread in all 17 components/shared/
files. Existing debug-ids preserved unchanged.
* feat(PBI-49): add debugProps to backlog/, sprint/, solo/ components
* feat(PBI-49): add debugProps to jobs/ + ideas/ components
* feat(PBI-49): add debugProps to products/ + settings/ + notifications/ components
* feat(PBI-49): add debugProps to admin/ + dashboard/ + dialogs/ + mobile/ + split-pane/
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(PBI-49): use attr(data-debug-id) for debug tooltip in globals.css
* refactor(PBI-49): remove data-debug-label from debugProps helper + test
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* refactor(PBI-49): strip unused component/file args from debugProps in shared/
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(PBI-49): add BEM sub-element data-debug-id to StatusBar, NavBar, PanelNavBar
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(PBI-49): add BEM sub-element data-debug-id to components/sprint/*
- new-sprint-dialog: __submit on submit button
- sprint-backlog: __list on SprintBacklogLeft + SprintBacklogRight scroll areas
- sprint-board-client: root wrapper div (display:contents) + __drag-overlay
- sprint-header: __title on goal button, __dates on dates button, __actions on action cluster
- sprint-run-controls: root on controls div, __start/__cancel on action buttons; __blockers-dialog on dialog content
- start-sprint-button: root on trigger button, __dialog on dialog content, __submit on submit button
- sync-active-sprint-cookie: no debug-id (returns null, side-effect only), comment added
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(PBI-49): add BEM sub-element data-debug-id to components/backlog/*
* feat(PBI-49): add BEM sub-element data-debug-id to components/ideas/*
* feat(PBI-49): add BEM sub-element data-debug-id to components/dashboard/* + components/markdown.tsx
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(PBI-49): add BEM sub-element data-debug-id to new-product-button
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(PBI-49): add BEM sub-element data-debug-id to components/solo/*
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(PBI-49): add BEM sub-elements to nav-status-indicators
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(PBI-49): add BEM sub-element data-debug-id to components/jobs/*
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(PBI-49): add BEM sub-element data-debug-id to components/products/*
* feat(PBI-49): add BEM sub-element data-debug-id to components/notifications/*
- answer-modal: __content (scroll area), __submit (footer)
- notifications-bridge: skip comment (bridge, non-rendering wrapper)
- notifications-realtime-mount: skip comment (returns null)
- notifications-sheet: __header, __items (questions list)
- push-toggle: __switch (button), __label (button text) on subscribed/unsubscribed states
* feat(PBI-49): add BEM sub-element data-debug-id to components/settings/*
- leave-product-button: root only (single-button component)
- min-quota-editor: __input (number input), __save (save button)
- profile-editor: __username (bio/short-description input), __save (submit)
- role-manager: __roles (checkbox list), __add (save button)
- token-manager: __tokens (active tokens list), __generate (create button)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(PBI-49): add BEM sub-element data-debug-id to admin, auth, dialogs, entity-dialog, mobile, split-pane
* docs(PBI-49): add debug-labels BEM pattern doc + CLAUDE.md entry
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
158 lines
5.3 KiB
TypeScript
158 lines
5.3 KiB
TypeScript
'use client'
|
|
|
|
import { useActionState } from 'react'
|
|
import { useFormStatus } from 'react-dom'
|
|
import { Button } from '@/components/ui/button'
|
|
import { Input } from '@/components/ui/input'
|
|
import { Textarea } from '@/components/ui/textarea'
|
|
import { cn } from '@/lib/utils'
|
|
import { debugProps } from '@/lib/debug'
|
|
|
|
type FieldErrors = Record<string, string[]>
|
|
type ActionResult = { error?: string | FieldErrors; success?: boolean } | undefined
|
|
|
|
function SubmitButton({ label }: { label: string }) {
|
|
const { pending } = useFormStatus()
|
|
return (
|
|
<Button type="submit" disabled={pending}>
|
|
{pending ? 'Even wachten…' : label}
|
|
</Button>
|
|
)
|
|
}
|
|
|
|
function getFieldError(error: string | FieldErrors | undefined, field: string): string | undefined {
|
|
if (!error || typeof error === 'string') return undefined
|
|
return (error as FieldErrors)[field]?.[0]
|
|
}
|
|
|
|
function getGlobalError(error: string | FieldErrors | undefined): string | undefined {
|
|
if (typeof error === 'string') return error
|
|
return undefined
|
|
}
|
|
|
|
interface ProductFormProps {
|
|
action: (_prevState: unknown, formData: FormData) => Promise<ActionResult>
|
|
submitLabel: string
|
|
defaultValues?: {
|
|
id?: string
|
|
name?: string
|
|
code?: string | null
|
|
description?: string
|
|
repo_url?: string
|
|
definition_of_done?: string
|
|
}
|
|
}
|
|
|
|
export function ProductForm({ action, submitLabel, defaultValues }: ProductFormProps) {
|
|
const [state, formAction] = useActionState(action, undefined)
|
|
|
|
const fieldError = (field: string) => getFieldError(state?.error, field)
|
|
const globalError = getGlobalError(state?.error)
|
|
|
|
return (
|
|
<form action={formAction} className="space-y-5" {...debugProps('product-form', 'ProductForm', 'components/products/product-form.tsx')}>
|
|
{defaultValues?.id && (
|
|
<input type="hidden" name="id" value={defaultValues.id} />
|
|
)}
|
|
|
|
<div className="grid grid-cols-[8rem_1fr] gap-3">
|
|
<div className="space-y-1.5">
|
|
<label htmlFor="code" className="text-sm font-medium text-foreground">
|
|
Code
|
|
</label>
|
|
<Input
|
|
id="code"
|
|
name="code"
|
|
defaultValue={defaultValues?.code ?? ''}
|
|
placeholder="optioneel"
|
|
maxLength={30}
|
|
className={cn('font-mono text-sm', fieldError('code') ? 'border-error' : '')}
|
|
/>
|
|
{fieldError('code') && (
|
|
<p className="text-xs text-error">{fieldError('code')}</p>
|
|
)}
|
|
</div>
|
|
<div className="space-y-1.5">
|
|
<label htmlFor="name" className="text-sm font-medium text-foreground">
|
|
Naam <span className="text-error">*</span>
|
|
</label>
|
|
<Input
|
|
id="name"
|
|
name="name"
|
|
required
|
|
defaultValue={defaultValues?.name}
|
|
placeholder="bijv. DevPlanner"
|
|
className={fieldError('name') ? 'border-error' : ''}
|
|
data-debug-id="product-form__name"
|
|
/>
|
|
{fieldError('name') && (
|
|
<p className="text-xs text-error">{fieldError('name')}</p>
|
|
)}
|
|
</div>
|
|
</div>
|
|
|
|
<div className="space-y-1.5">
|
|
<label htmlFor="description" className="text-sm font-medium text-foreground">
|
|
Beschrijving
|
|
</label>
|
|
<Textarea
|
|
id="description"
|
|
name="description"
|
|
rows={3}
|
|
defaultValue={defaultValues?.description}
|
|
placeholder="Korte omschrijving van het product…"
|
|
className={fieldError('description') ? 'border-error' : ''}
|
|
/>
|
|
{fieldError('description') && (
|
|
<p className="text-xs text-error">{fieldError('description')}</p>
|
|
)}
|
|
</div>
|
|
|
|
<div className="space-y-1.5">
|
|
<label htmlFor="repo_url" className="text-sm font-medium text-foreground">
|
|
Git-repo URL
|
|
</label>
|
|
<Input
|
|
id="repo_url"
|
|
name="repo_url"
|
|
type="url"
|
|
defaultValue={defaultValues?.repo_url ?? ''}
|
|
placeholder="https://github.com/..."
|
|
className={fieldError('repo_url') ? 'border-error' : ''}
|
|
data-debug-id="product-form__repo"
|
|
/>
|
|
{fieldError('repo_url') && (
|
|
<p className="text-xs text-error">{fieldError('repo_url')}</p>
|
|
)}
|
|
</div>
|
|
|
|
<div className="space-y-1.5">
|
|
<label htmlFor="definition_of_done" className="text-sm font-medium text-foreground">
|
|
Definition of Done <span className="text-error">*</span>
|
|
</label>
|
|
<Textarea
|
|
id="definition_of_done"
|
|
name="definition_of_done"
|
|
required
|
|
rows={4}
|
|
defaultValue={defaultValues?.definition_of_done}
|
|
placeholder="Bijv. code gereviewd, tests groen, gedeployed naar staging…"
|
|
className={fieldError('definition_of_done') ? 'border-error' : ''}
|
|
/>
|
|
{fieldError('definition_of_done') && (
|
|
<p className="text-xs text-error">{fieldError('definition_of_done')}</p>
|
|
)}
|
|
</div>
|
|
|
|
{globalError && (
|
|
<div className="bg-error-container text-error-container-foreground rounded-lg px-3 py-2 text-sm border-l-4 border-error">
|
|
{globalError}
|
|
</div>
|
|
)}
|
|
|
|
<div className="flex gap-3 pt-1" data-debug-id="product-form__submit">
|
|
<SubmitButton label={submitLabel} />
|
|
</div>
|
|
</form>
|
|
)
|
|
}
|