* fix(ST-1272): allow PLAN_READY → GRILLING re-grill transition
actions/ideas.ts already lists PLAN_READY in GRILL_TRIGGERABLE_FROM,
but lib/idea-status.ts ALLOWED_TRANSITIONS was missing the
PLAN_READY → GRILLING edge. As a result, clicking Grill on a PLAN_READY
idea returned 422 "Status-transitie ongeldig" while the UI button was
enabled. Mirrors the existing PLANNED → GRILLING re-grill behaviour.
- lib/idea-status.ts: PLAN_READY allows GRILLING in addition to
PLANNING/PLANNED
- __tests__/lib/idea-status.test.ts: explicit assert for
PLAN_READY → GRILLING and PLAN_READY added to the regrill loop
covering every GRILL_TRIGGERABLE_FROM status
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(ST-1275): render SKIPPED job status in chart-colors and insights
Closing the gap left when ClaudeJobStatus.SKIPPED was added to the schema:
the badge map and case-mapper already covered it, but the chart palette,
the per-day insights aggregator and the stacked-bar chart did not. SKIPPED
jobs (e.g. cmovkur8 manually flipped during the no-op-exit hotfix) now
render with a muted style consistent with cancelled.
- lib/chart-colors.ts: JOB_STATUS_COLORS gains a 'skipped' entry
(var(--muted-foreground), same intensity as cancelled — neither rood/orange)
- lib/insights/agent-throughput.ts: DayCount + STATUSES + perDay zero-fill
now include 'skipped'; the SQL terminal_7d filter already counted SKIPPED
- app/(app)/insights/components/agent-throughput.tsx: STACKED_STATUSES and
the empty-state guard include 'skipped'
- __tests__: chart-colors keys list, job-status round-trip ('all 7 statuses')
and the insights non-zero filter all account for SKIPPED
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
82 lines
2.5 KiB
TypeScript
82 lines
2.5 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
const { mockQueryRaw } = vi.hoisted(() => ({ mockQueryRaw: vi.fn() }))
|
|
|
|
vi.mock('@/lib/prisma', () => ({
|
|
prisma: { $queryRaw: mockQueryRaw },
|
|
}))
|
|
|
|
import { getJobsPerDay } from '@/lib/insights/agent-throughput'
|
|
|
|
// Build a date string for N days ago (UTC)
|
|
function daysAgo(n: number): Date {
|
|
const d = new Date()
|
|
d.setUTCDate(d.getUTCDate() - n)
|
|
return d
|
|
}
|
|
|
|
function toUTCDate(d: Date): Date {
|
|
return new Date(Date.UTC(d.getUTCFullYear(), d.getUTCMonth(), d.getUTCDate()))
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
describe('getJobsPerDay', () => {
|
|
it('returns a 14-day array zero-filled for missing days', async () => {
|
|
// Only 3 days have data; the rest should be 0
|
|
const day0 = toUTCDate(daysAgo(0))
|
|
const day3 = toUTCDate(daysAgo(3))
|
|
const day7 = toUTCDate(daysAgo(7))
|
|
|
|
const dayRows = [
|
|
{ day: day0, status: 'done', count: BigInt(2) },
|
|
{ day: day3, status: 'failed', count: BigInt(1) },
|
|
{ day: day7, status: 'done', count: BigInt(5) },
|
|
]
|
|
|
|
const kpiRows = [
|
|
{ today_count: BigInt(2), done_7d: BigInt(7), terminal_7d: BigInt(10), avg_seconds: 120 },
|
|
]
|
|
|
|
mockQueryRaw.mockResolvedValueOnce(dayRows).mockResolvedValueOnce(kpiRows)
|
|
|
|
const result = await getJobsPerDay('user-1')
|
|
|
|
expect(result.perDay).toHaveLength(14)
|
|
|
|
// All days should have zero counts except the three we seeded
|
|
const nonZero = result.perDay.filter(
|
|
d => d.done + d.failed + d.queued + d.claimed + d.running + d.cancelled + d.skipped > 0,
|
|
)
|
|
expect(nonZero).toHaveLength(3)
|
|
|
|
// Today's done count should be 2
|
|
const today = result.perDay[result.perDay.length - 1]
|
|
expect(today.done).toBe(2)
|
|
})
|
|
|
|
it('calculates KPIs correctly', async () => {
|
|
mockQueryRaw.mockResolvedValueOnce([]).mockResolvedValueOnce([
|
|
{ today_count: BigInt(3), done_7d: BigInt(7), terminal_7d: BigInt(10), avg_seconds: 90 },
|
|
])
|
|
|
|
const result = await getJobsPerDay('user-1')
|
|
|
|
expect(result.kpi.todayCount).toBe(3)
|
|
expect(result.kpi.successRate7d).toBe(0.7)
|
|
expect(result.kpi.avgDurationSeconds7d).toBe(90)
|
|
})
|
|
|
|
it('returns zero successRate and null avgDuration when no terminal jobs', async () => {
|
|
mockQueryRaw.mockResolvedValueOnce([]).mockResolvedValueOnce([
|
|
{ today_count: BigInt(0), done_7d: BigInt(0), terminal_7d: BigInt(0), avg_seconds: null },
|
|
])
|
|
|
|
const result = await getJobsPerDay('user-1')
|
|
|
|
expect(result.kpi.successRate7d).toBe(0)
|
|
expect(result.kpi.avgDurationSeconds7d).toBeNull()
|
|
})
|
|
})
|