* feat(PBI-76): extend UserSettings schema with layout Adds layout.splitPanePositions and layout.activeSprints. These will hold values currently kept in client-side and server-side cookies (Phase 2). Two new tests cover the shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(PBI-76): migrate SplitPane positions to user-settings store Outside of a drag the store is the source of truth (cross-tab updates flow in for free). During a drag we keep splits in local state so mousemove does not round-trip through the store. On mouseup we persist the final splits via setPref. Removes document.cookie reads/writes — cookieKey is reused as the store-key for backwards compat. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(PBI-76): resolveActiveSprint reads from User.settings lib/active-sprint: - New helpers: getActiveSprintIdFromSettings, setActiveSprintInSettings, clearActiveSprintInSettings — all read/write user.settings.layout.activeSprints. - resolveActiveSprint(productId, userId) — userId now required, falls back to first OPEN, then most recent CLOSED sprint. - Cookie helpers (getActiveSprintIdFromCookie/setActiveSprintCookie/ clearActiveSprintCookie) removed. Callers updated to pass session.userId. The cookie-based fallback path is gone — `actions/active-sprint.ts` and `actions/sprints.ts` will be updated in the next commit (T-917). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(PBI-76): rewrite setActiveSprint callers to use settings setActiveSprintAction, syncActiveSprintCookieAction, and the two sprint-creation paths in actions/sprints.ts now write through setActiveSprintInSettings (which also emits pg_notify for cross-tab sync) instead of dropping a cookie. The action names keep the 'cookie' suffix in the user-visible API for now — clean rename can come later. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(PBI-76): migration helper v2 — handle legacy cookies Bumps marker version to 'v2'. buildMigrationPatch now also scans document.cookie for `sp:*` (split-pane positions) and `active_sprint_*` (active sprint per product) and lifts them into layout.splitPanePositions / layout.activeSprints. clearLegacyStorage replaces clearLegacyLocalStorage and clears both keys and cookies. clearLegacyLocalStorage stays as a deprecated alias so the bridge upgrade is a single rename. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(PBI-76): align tests with new SplitPane and active-sprint flow - split-pane.test.tsx: seed positions via Zustand store instead of document.cookie; mock @/actions/user-settings so the prisma client is not transitively initialised in jsdom. - backlog-split-pane.test.tsx: same action mock. - sprint-dates.test.ts: add user.findUnique/update + $executeRaw mocks because createSprintAction now writes to user-settings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
102 lines
4.2 KiB
TypeScript
102 lines
4.2 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
vi.mock('next/cache', () => ({ revalidatePath: vi.fn() }))
|
|
vi.mock('next/headers', () => ({ cookies: vi.fn().mockResolvedValue({ set: vi.fn(), get: vi.fn(), delete: vi.fn() }) }))
|
|
vi.mock('iron-session', () => ({
|
|
getIronSession: vi.fn().mockResolvedValue({ userId: 'user-1', isDemo: false }),
|
|
}))
|
|
vi.mock('@/lib/session', () => ({
|
|
sessionOptions: { cookieName: 'test', password: 'test' },
|
|
}))
|
|
vi.mock('@/lib/product-access', () => ({
|
|
productAccessFilter: vi.fn().mockReturnValue({}),
|
|
getAccessibleProduct: vi.fn().mockResolvedValue({ id: 'product-1', user_id: 'user-1' }),
|
|
}))
|
|
vi.mock('@/lib/prisma', () => ({
|
|
prisma: {
|
|
sprint: {
|
|
findFirst: vi.fn(),
|
|
findMany: vi.fn(),
|
|
create: vi.fn(),
|
|
update: vi.fn(),
|
|
},
|
|
user: {
|
|
findUnique: vi.fn().mockResolvedValue({ settings: {} }),
|
|
update: vi.fn().mockResolvedValue({}),
|
|
},
|
|
$executeRaw: vi.fn().mockResolvedValue(1),
|
|
},
|
|
}))
|
|
|
|
import { prisma } from '@/lib/prisma'
|
|
import { createSprintAction, updateSprintDatesAction } from '@/actions/sprints'
|
|
|
|
const mockSprint = prisma as unknown as { sprint: { findFirst: ReturnType<typeof vi.fn>; findMany: ReturnType<typeof vi.fn>; create: ReturnType<typeof vi.fn>; update: ReturnType<typeof vi.fn> } }
|
|
|
|
function makeFormData(data: Record<string, string | null>) {
|
|
const fd = new FormData()
|
|
for (const [k, v] of Object.entries(data)) {
|
|
if (v !== null) fd.append(k, v)
|
|
}
|
|
return fd
|
|
}
|
|
|
|
describe('createSprintAction — date validation', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mockSprint.sprint.findFirst.mockResolvedValue(null)
|
|
mockSprint.sprint.findMany.mockResolvedValue([])
|
|
mockSprint.sprint.create.mockResolvedValue({ id: 'sprint-1' })
|
|
})
|
|
|
|
it('accepts valid start_date + end_date', async () => {
|
|
const fd = makeFormData({ productId: 'product-1', sprint_goal: 'Doel', start_date: '2026-05-01', end_date: '2026-05-14' })
|
|
const result = await createSprintAction(undefined, fd)
|
|
expect(result.success).toBe(true)
|
|
expect(mockSprint.sprint.create).toHaveBeenCalledWith(
|
|
expect.objectContaining({ data: expect.objectContaining({ start_date: new Date('2026-05-01'), end_date: new Date('2026-05-14') }) })
|
|
)
|
|
})
|
|
|
|
it('rejects end_date before start_date', async () => {
|
|
const fd = makeFormData({ productId: 'product-1', sprint_goal: 'Doel', start_date: '2026-05-14', end_date: '2026-05-01' })
|
|
const result = await createSprintAction(undefined, fd) as { code?: number; fieldErrors?: Record<string, string[]> }
|
|
expect(result.code).toBe(422)
|
|
expect(result.fieldErrors?.end_date?.[0]).toContain('Einddatum')
|
|
})
|
|
|
|
it('accepts no dates (both optional)', async () => {
|
|
const fd = makeFormData({ productId: 'product-1', sprint_goal: 'Doel', start_date: '', end_date: '' })
|
|
const result = await createSprintAction(undefined, fd)
|
|
expect(result.success).toBe(true)
|
|
})
|
|
})
|
|
|
|
describe('updateSprintDatesAction — date validation', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mockSprint.sprint.findFirst.mockResolvedValue({ id: 'sprint-1', product_id: 'product-1' })
|
|
mockSprint.sprint.update.mockResolvedValue({})
|
|
})
|
|
|
|
it('saves valid dates', async () => {
|
|
const fd = makeFormData({ id: 'sprint-1', start_date: '2026-05-01', end_date: '2026-05-14' })
|
|
const result = await updateSprintDatesAction(undefined, fd)
|
|
expect(result.success).toBe(true)
|
|
})
|
|
|
|
it('rejects end_date before start_date', async () => {
|
|
const fd = makeFormData({ id: 'sprint-1', start_date: '2026-05-10', end_date: '2026-05-05' })
|
|
const result = await updateSprintDatesAction(undefined, fd) as { code?: number; fieldErrors?: Record<string, string[]> }
|
|
expect(result.code).toBe(422)
|
|
expect(result.fieldErrors?.end_date?.[0]).toContain('Einddatum')
|
|
})
|
|
|
|
it('blocks demo users', async () => {
|
|
const { getIronSession } = await import('iron-session')
|
|
vi.mocked(getIronSession).mockResolvedValueOnce({ userId: 'user-1', isDemo: true } as never)
|
|
const fd = makeFormData({ id: 'sprint-1', start_date: '', end_date: '' })
|
|
const result = await updateSprintDatesAction(undefined, fd)
|
|
expect(result.error).toBe('Niet beschikbaar in demo-modus')
|
|
})
|
|
})
|