Scrum4Me/__tests__/api/sprint-tasks.test.ts
Janpeter Visser 43a4294424
Todo description, entity codes, REST API extensions and Claude Code hardening (ST-509/511/512/513) (#2)
* docs(ST-511): add backlog entry for entity codes feature

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(ST-511): add createWithCodeRetry helper to handle P2002 race on auto codes

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(ST-511): retry on auto-code unique conflict in story and pbi create

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(ST-511): surface field errors for code and title in PBI dialog

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(ST-511): read create-state errors in Story dialog fieldError

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(ST-512): add backlog entry for REST API code/description/implementation_plan extensions; mark ST-511 done

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(ST-512): extend REST API with code, description and implementation_plan

- GET /api/products returns code, description and definition_of_done
- GET /api/products/:id/next-story returns story.code and per-task code + implementation_plan
- GET /api/sprints/:id/tasks returns description, implementation_plan, story_code and derived per-task code
- POST /api/todos accepts and returns optional description (max 2000)

All changes are additive — existing clients ignore unknown keys.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(ST-512): mark ST-512 as done

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(ST-513): add backlog entry for API hardening for Claude Code

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(ST-513): add task and story status mappers for API boundary

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(ST-513): expose lowercase status on API and accept lowercase in PATCH /api/tasks

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(ST-513): add metadata JSONB column to StoryLog

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(ST-513): accept optional metadata in story log and switch validation errors to 422

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(ST-513): add GET /api/health endpoint with optional db ping

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(ST-513): add GET /api/products/:id/claude-context bundled endpoint

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(ST-513): add docs/API.md and link from CLAUDE.md specs table

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(ST-513): mark ST-513 as done

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(ST-513): split 400 (malformed JSON) from 422 (validation), reject 'review'

Codex review on PR #2:

- P2.1: routes treated JSON parse failures as 422 instead of 400, breaking
  the contract in docs/API.md. Replace `request.json().catch(() => null)`
  with try/catch in 4 routes (tasks, reorder, todos, story-log) so a
  malformed body returns 400 and only well-formed-but-invalid bodies
  return 422.

- P2.2: PATCH /api/tasks/:id accepted `status: "review"`, but the sprint
  task list UI does not render REVIEW (no label/color, the cycle helper
  falls back to TO_DO). Reject `review` at the API until the sprint UI
  is extended; document the subset in docs/API.md.

Tests in __tests__/api updated for the new contract (29 assertions:
zod-failures now expect 422, status payloads use lowercase API values,
sprint-tasks mocks include the new story relation).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-26 23:40:54 +02:00

143 lines
3.8 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest'
vi.mock('@/lib/prisma', () => ({
prisma: {
sprint: {
findFirst: vi.fn(),
},
task: {
findMany: vi.fn(),
},
},
}))
vi.mock('@/lib/api-auth', () => ({
authenticateApiRequest: vi.fn(),
}))
import { prisma } from '@/lib/prisma'
import { authenticateApiRequest } from '@/lib/api-auth'
import { GET as getSprintTasks } from '@/app/api/sprints/[id]/tasks/route'
const mockPrisma = prisma as unknown as {
sprint: { findFirst: ReturnType<typeof vi.fn> }
task: { findMany: ReturnType<typeof vi.fn> }
}
const mockAuth = authenticateApiRequest as ReturnType<typeof vi.fn>
const SPRINT = { id: 'sprint-1', product_id: 'prod-1', status: 'ACTIVE' }
function makeTask(n: number) {
return {
id: `task-${n}`,
title: `Task ${n}`,
description: null,
implementation_plan: null,
story_id: 'story-1',
priority: 1,
sort_order: n,
status: 'TO_DO',
story: {
code: 'ST-1',
tasks: [{ id: `task-${n}` }],
},
}
}
function makeRequest(sprintId = 'sprint-1', limit?: number): [Request, { params: Promise<{ id: string }> }] {
const url = limit
? `http://localhost/api/sprints/${sprintId}/tasks?limit=${limit}`
: `http://localhost/api/sprints/${sprintId}/tasks`
return [
new Request(url, {
method: 'GET',
headers: { Authorization: 'Bearer test-token' },
}),
{ params: Promise.resolve({ id: sprintId }) },
]
}
describe('GET /api/sprints/:id/tasks', () => {
beforeEach(() => {
vi.clearAllMocks()
mockAuth.mockResolvedValue({ userId: 'user-1', isDemo: false })
mockPrisma.sprint.findFirst.mockResolvedValue(SPRINT)
})
// TC-ST-05
it('applies default limit of 10 when no limit param is given', async () => {
mockPrisma.task.findMany.mockResolvedValue(Array.from({ length: 10 }, (_, i) => makeTask(i + 1)))
const res = await getSprintTasks(...makeRequest())
const data = await res.json()
expect(res.status).toBe(200)
expect(mockPrisma.task.findMany).toHaveBeenCalledWith(
expect.objectContaining({ take: 10 })
)
expect(data).toHaveLength(10)
})
// TC-ST-06
it('respects custom limit param', async () => {
mockPrisma.task.findMany.mockResolvedValue(Array.from({ length: 3 }, (_, i) => makeTask(i + 1)))
const res = await getSprintTasks(...makeRequest('sprint-1', 3))
expect(res.status).toBe(200)
expect(mockPrisma.task.findMany).toHaveBeenCalledWith(
expect.objectContaining({ take: 3 })
)
})
// TC-ST-07
it('handles limit=1 boundary', async () => {
mockPrisma.task.findMany.mockResolvedValue([makeTask(1)])
const res = await getSprintTasks(...makeRequest('sprint-1', 1))
const data = await res.json()
expect(res.status).toBe(200)
expect(mockPrisma.task.findMany).toHaveBeenCalledWith(
expect.objectContaining({ take: 1 })
)
expect(data).toHaveLength(1)
})
it('clamps limit to max 50', async () => {
mockPrisma.task.findMany.mockResolvedValue([])
await getSprintTasks(...makeRequest('sprint-1', 999))
expect(mockPrisma.task.findMany).toHaveBeenCalledWith(
expect.objectContaining({ take: 50 })
)
})
// TC-ST-08
it('returns empty array when sprint has no tasks', async () => {
mockPrisma.task.findMany.mockResolvedValue([])
const res = await getSprintTasks(...makeRequest())
const data = await res.json()
expect(res.status).toBe(200)
expect(data).toEqual([])
})
it('returns tasks with expected fields', async () => {
mockPrisma.task.findMany.mockResolvedValue([makeTask(1)])
const res = await getSprintTasks(...makeRequest())
const data = await res.json()
expect(data[0]).toMatchObject({
id: 'task-1',
title: 'Task 1',
story_id: 'story-1',
priority: 1,
sort_order: 1,
status: 'todo',
})
})
})