Sprint: Chat is klaar #52

Merged

janpeter merged 15 commits from feat/sprint-x5bootxw into main 2026-05-28 22:59:25 +02:00

Conversation 0 Commits 15 Files changed 15 +521 -18

janpeter commented 2026-05-28 21:13:50 +02:00

Owner

Copy link

Sprint 'Chat is klaar' (PBI-113) volledig geïmplementeerd in 17 taken over 4 stories.

ST-1434 (DB-laag): IdeaNotification model + back-relaties in canonical shared schema; migration met CREATE TABLE, UNIQUE/composite indexes, CASCADE FKs; NOTIFY-trigger (entity='idea_ready' op scrum4me_changes); claude_jobs DONE-trigger die kaarten auto-insert bij IDEA_GRILL/IDEA_MAKE_PLAN.

ST-1435 (Realtime): 'ready'-variant toegevoegd aan NotificationQuestion union; fetchUnreadIdeaReadyCards server-helper; SSE-route forwardet idea_ready payloads user-scoped; bridge laadt kaarten in initial state; client-hook reconnect/remove-logica bij INSERT/UPDATE; solo-route filtert idea_ready.

ST-1436 (UI): dismissIdeaNotificationAction (auth+demo+atomic updateMany+revalidatePath); ReadyCard sub-component in notifications-sheet met job_kind-label, Q&A-preview, Gelezen-knop (optimistic dismiss via useTransition), DemoTooltip, Link naar /ideas/${idea_id}; answer-modal guard voor kind==='ready'; bell forYouCount telt ready-kaarten.

ST-1437 (Tests+verificatie): unit-tests notifications-store ready-variant (5 tests); unit-tests dismissIdeaNotificationAction (6 tests); typecheck + npm run verify + npm run build allemaal groen.

---

Draft PR voor sprint-batch cmpps80380019vp7rx5bootxw (single-session). Wordt ready-for-review zodra alle tasks DONE zijn.

Sprint 'Chat is klaar' (PBI-113) volledig geïmplementeerd in 17 taken over 4 stories. ST-1434 (DB-laag): IdeaNotification model + back-relaties in canonical shared schema; migration met CREATE TABLE, UNIQUE/composite indexes, CASCADE FKs; NOTIFY-trigger (entity='idea_ready' op scrum4me_changes); claude_jobs DONE-trigger die kaarten auto-insert bij IDEA_GRILL/IDEA_MAKE_PLAN. ST-1435 (Realtime): 'ready'-variant toegevoegd aan NotificationQuestion union; fetchUnreadIdeaReadyCards server-helper; SSE-route forwardet idea_ready payloads user-scoped; bridge laadt kaarten in initial state; client-hook reconnect/remove-logica bij INSERT/UPDATE; solo-route filtert idea_ready. ST-1436 (UI): dismissIdeaNotificationAction (auth+demo+atomic updateMany+revalidatePath); ReadyCard sub-component in notifications-sheet met job_kind-label, Q&A-preview, Gelezen-knop (optimistic dismiss via useTransition), DemoTooltip, Link naar /ideas/${idea_id}; answer-modal guard voor kind==='ready'; bell forYouCount telt ready-kaarten. ST-1437 (Tests+verificatie): unit-tests notifications-store ready-variant (5 tests); unit-tests dismissIdeaNotificationAction (6 tests); typecheck + npm run verify + npm run build allemaal groen. --- *Draft PR voor sprint-batch `cmpps80380019vp7rx5bootxw` (single-session). Wordt ready-for-review zodra alle tasks DONE zijn.*

janpeter added 15 commits 2026-05-28 21:13:50 +02:00

feat(schema): add IdeaNotification model with back-relations ... 17415e3944

Voeg IdeaNotification toe aan prisma/schema.prisma met velden id, idea_id,
user_id, product_id, job_id (unique), kind (ClaudeJobKind), read_at en
created_at. Relaties naar Idea, User en ClaudeJob met onDelete: Cascade.
Index op [user_id, read_at]. Back-relaties toegevoegd op Idea.notifications,
User.idea_notifications en ClaudeJob.idea_notification.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(db): add idea_notifications table, indexes, and FKs ... 35a9941e6e

CreateTable idea_notifications with all columns; UNIQUE INDEX on job_id;
composite INDEX on (user_id, read_at); CASCADE FKs for idea_id, user_id, job_id.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(db): add NOTIFY trigger for idea_notifications ... abbe7f84b9

CREATE OR REPLACE FUNCTION notify_idea_notification_change() emits
jsonb payload on scrum4me_changes channel with entity='idea_ready',
op, id, idea_id, user_id, product_id, kind, read fields.
Trigger fires AFTER INSERT OR UPDATE on idea_notifications.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(db): trigger insert_idea_ready_card on claude_jobs DONE transition ... c4789dc2e6

Appends insert_idea_ready_card() function and claude_jobs_idea_ready
trigger to the add_idea_notifications migration. On status transition to
DONE for IDEA_GRILL/IDEA_MAKE_PLAN jobs with an idea_id, a card is
auto-inserted into idea_notifications (ON CONFLICT DO NOTHING for
idempotency).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(notifications): add 'ready' variant to NotificationQuestion union ... c5ac4d1224

Adds the 'ready' kind to the store's NotificationQuestion union type for
completed idea-job notifications (IDEA_GRILL/IDEA_MAKE_PLAN). Updates
forYouCount selector to include 'ready' items, and fixes type narrowing
in bell/sheet/modal components so TypeScript compilation stays clean.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(ideas): add fetchUnreadIdeaReadyCards server helper ... c65659d361

Exports async fetchUnreadIdeaReadyCards(userId) that queries IdeaNotification
(unread, desc) and enriches each card with answered Q&A from ClaudeQuestion,
capping at 3 pairs while exposing qa_total for "+N meer" UI rendering.
Maps to the ReadyCard shape from notifications-store.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(realtime): forward idea_ready payloads + hydrate ready-cards in initial state ... f33b5dba3b

- Add IdeaReadyPayload interface + isIdeaReadyPayload type-guard
- Handle idea_ready notifications user-scoped (like idea-jobs: user_id check)
- Fetch fetchUnreadIdeaReadyCards(userId) in parallel with initial-state queries
- Spread ideaReadyCards into stateQuestions (sorted by created_at desc)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(notifications): include idea ready-cards in bridge initial state ... 9210adca89

Import fetchUnreadIdeaReadyCards and concat its results into the initial
array alongside story- and idea-questions, sorted on created_at desc.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(realtime): add idea_ready client handler + solo-route filter (T-1242) ... 9ad2d64d28

- use-notifications-realtime: IdeaReadyPayload interface + isIdeaReadyPayload
  type-guard; op=I/!read → reconnect, read=true → remove from bell
- solo/route: extend EntityPayload entity union + shouldEmit filter for idea_ready

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(ideas): add dismissIdeaNotificationAction ... 503ca9f950

Atomic updateMany scoped to user_id + read_at IS NULL; revalidatePath layout for SSR badge update. Returns 404 when not found or already read, 401/403 for auth/demo guards.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(notifications): add ready-card layout for Grill/Plan klaar notifications ... 739e0dcd1a

Renders 'ready' notifications (IDEA_GRILL / IDEA_MAKE_PLAN) as a dedicated
card with label badge, idea code+title, description, up to 3 Q&A pairs with
overflow count, a link to /ideas/:id, and an optimistic "Gelezen" dismiss
button (disabled + DemoTooltip in demo mode). Ready cards do not open
AnswerModal. Uses MD3 secondary-container tokens; data-debug-id attributes
added throughout.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(notifications-store): unit-tests voor ready-variant kaart ... e4e9f54cd1

Voegt __tests__/stores/notifications-store.test.ts toe met fixture voor
de 'ready'-NotificationQuestion en assertions op openCount, forYouCount
en remove.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(actions): unit-tests for dismissIdeaNotificationAction ... 465c537e29

Covers: 401 unauthenticated, 403 demo block, user_id scope in updateMany where,
404 on count !== 1 (not found / already read), and happy-path sets read_at + revalidatePath.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(schema): add IdeaNotification to shared canonical schema ... 87487a7f75

Added IdeaNotification model + back-relations (User, Idea, ClaudeJob)
to vendor/scrum4me-shared/prisma/schema.prisma so prebuild regenerates
prisma/schema.prisma correctly with the new model.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(ideas): simplify fetchUnreadIdeaReadyCards ... e5304b95d3

More concise form: inline select options, use satisfies for type safety.
Logic identical to original implementation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

janpeter changed title from WIP: Sprint: Chat is klaar to Sprint: Chat is klaar 2026-05-28 21:13:52 +02:00

janpeter merged commit beffb99831 into main 2026-05-28 22:59:25 +02:00

janpeter referenced this pull request from a commit 2026-05-28 22:59:25 +02:00

Merge pull request 'Sprint: Chat is klaar' (#52) from feat/sprint-x5bootxw into main

janpeter referenced this pull request 2026-08-17 08:03:12 +02:00

feat(issues): issue-tracker per product of systeem met Forgejo-mirror #174

janpeter referenced this pull request from a commit 2026-08-17 10:25:52 +02:00

fix(build): main bouwt weer — extensionAlias voor @shared + PageProps-constraint

janpeter referenced this pull request 2026-08-17 10:26:21 +02:00

fix(build): main bouwt weer — extensionAlias voor @shared + PageProps-constraint #175

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

janpeter/Scrum4Me!52

No description provided.