feat: closed-schema transition chain + guard link 0001 (IDEA-245, ISS-9) #346
No reviewers
Labels
No labels
severity/s3
severity/s4
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
janpeter/Scrum4Me!346
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/idea-245-closed-schema-chain"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
IDEA-245 / ISS-9 — PR 1 (Scrum4Me). Sprint S-2026-10-09-I245, PBI-194, ST-1651, T1–T5.
What
An append-only closed-schema transition chain: after the IDEA-213 adoption and IDEA-227, adopted functions (definition only) and table triggers can change through links (
scripts/db-access/transitions/closed-schema/NNNN-*.json+prisma/migrations/<ts>_closed_schema_<NNNN>_*/migration.sql). Manifest, receipt and the IDEA-227 files stay byte-equal.lib/db-access/closed-schema-transitions.ts: chain validator (sequence,previous, manifest pin, migration-id rules, derived before-schema, function/trigger change rules,NOOPoutsides4m_dispatch_test) and SQL lint (BEGIN/COMMIT shape, dollar-quote aware, targets == keys).expectedSchemaHashes(ledger prefix after IDEA-227,ORDER, checksum,HISTORY_MISSINGalso without chain) used byverifyAdoptionAfter(optional 6th paramchain),requireAdoptionand the activation preflight;lib/db-access/adoption-context.ts(loadAdoptionContext) as the one loader; CLI keeps its receipt order. Both modules are literal bundle entries.migrate.ts,closed-schema-replay.ts(per-link before/after verification, capture file), baseline filter,provision --stage adoption|chain,test:dispatch:chain, CI: both Postgres services pinned to the prod RepoDigest and a second provision/test step pair in thequeue-dispatchjob.20261009140000_closed_schema_0001_task_guard_unscoped_stops:queue_dispatch_guard_task()also releases a task binding after aclaim_bound_unscoped(artefact) orsigned_off_unstarted(signed-off incarnation) stop of an attempt without scope/start/started_scope.afterSchemacaptured by replay on the pinned image.db-access-policy.md(chain, operator snippet, capture/NOOP, rollout, mismatch, no old-bundle rollback) andqueue-dispatch.md(guard extension, follow-ups).Evidence
GRILLS/idea-245-t0-mcp-evidencerev 2, pin48555ea6(stop-evidence.ts:58'claim_bound_unscoped',:106'signed_off_unstarted',started_scopepayloadattempt_id).postgres@sha256:347bc4e64006d47bb255b0e28652d08590260a5e97f6b55f6ba1c0b31aef58b3, linux/amd64, 17.9 (Debian 17.9-1.pgdg13+1). CI runners are x86_64. CI pin:postgres:17.9@sha256:347bc4e6…58b3.provision→test:dispatch17 files/49 tests;provision --stage chain(server_version 17.9) →test:dispatch:chain5 files/26 tests. Sanity: the new guard tests against the old guard fail exactly on the two release cases.npm run verifygreen (403 files / 4242 tests);docs:check-linksgreen;npm run buildcompiles (page-data collection needs the real env → CI).git diff --exit-code 6e0d6acc -- lib/db-access/api-token-usage-transition.ts scripts/db-access/transitions/idea-227-token-usage.jsonandgit diff --exit-code --diff-filter=MDRT 6e0d6acc -- __tests__/queue-dispatch/clean.Rollout (T6 — JP, every step a separate authorisation)
server_versionequal to the green CI run for exactly the merged commit; ops-agent precheck/preflight callers go throughloadAdoptionContext(a chainless caller getsHISTORY_MISSINGafter step 3).POLICY_HASHchanges).prisma-operator.sh deploy→ green.Then PR 2 (scrum4me-mcp, T7): remove
closesAtStop.Spec:
SPECS/idea-245-closed-schema-transitionsrev 5 +SPECS/idea-245-spec-delta-capturerev 2; plan:PLANS/idea-245-planrev 3 + addendum r3.🤖 Generated with Claude Code
CI run 965 green on head
f89bd976(all 8 jobs). Queue Dispatch Guard Gate: stageadoptionprovision + tests, then stagechainprovision (DISPATCH_TEST_SERVER_VERSION 17.9 (Debian 17.9-1.pgdg13+1), closed-schema chain replayed) + chain tests green, onpostgres:17.9@sha256:347bc4e6…58b3(linux/amd64 runner), equal to prod (measured read-only on 154). Rollout step 0 holds for exactly this commit.🤖 Generated with Claude Code
APPROVED
Geen blokkerende bevindingen in de diff van
f89bd976f426f2667177079da81978e6f044813d.Findings
postgres -VdoorSHOW server_versionvia de verbinding metscrum4me-postgres. De binaryversie (mogelijk op de host) bewijst niet de versie van de draaiende server; de bindende spec en het plan vereisen die vergelijking met de CI-replay.Plan en productstandaarden
Plan gekoppeld via pbi (Scrum4Me): IDEA-245 uitvoeringsplan rev 3. Ook getoetst aan de gekoppelde spec rev 5, spec-delta capture rev 2 en het in de PR genoemde plan-addendum r3. Geen references- of omitted-velden aangeleverd.
De PR rondt T1–T5 af: ketenvalidatie, bundle-loader, ledgercontrole, beide provisioning-stages, guard-schakel 0001 en runbooks zijn aanwezig en sluiten aan op het plan. De beschermde IDEA-227-bestanden en bestaande dispatch-testbestanden zijn byte-ongewijzigd tegenover
6e0d6acc. T6 (productie-uitrol) en T7 (scrum4me-mcp-vervolg) zijn expliciete vervolgstappen, geen ontbrekend werk binnen deze PR. Geen blokkerende afwijkingen in architectuur, patronen, tests of documentatie gevonden.Verificatie
Verdict: COMMENT
Geen blokkerende codefindings gevonden. Goedkeuring blijft uit zolang de volledige verificatie onzeker is.
985931f45fc05a3ba07985c4ad2b48a7b1e60ee6nog op pending. T5 en plan-addendum r3 vereisen deze job groen; met name de build is nog niet bevestigd.Plan gekoppeld via pbi (product Scrum4Me). Beoordeeld tegen het aangeleverde IDEA-245-plan rev 3,
specs/idea-245-closed-schema-transitions, het capture-addendum rev 2 enplans/idea-245-plan-addendum-r3. De implementatie past bij de geclaimde scope T1–T5: validator/lint, ledger en loader, replay/capture, guard 0001, CI en runbooks. T6 (uitrol) en T7 (scrum4me-mcp) zijn expliciete vervolgwerkzaamheden en geen ontbrekende scope van deze PR.Verificatie:
De centrale contextloader en gedeelde ledgerlezer volgen de vastgelegde architectuur. Tests dekken onder meer HISTORY_MISSING zonder keten, checksum/prefix, NOOP, replay-mismatches, bundle-integriteit en de positieve en negatieve stopbewijsgevallen. Runbooks beschrijven de operatorcontext, uitrolvoorwaarden en het ontbreken van oude-bundle-rollback.
CI run 966 green on head
985931f4(all 8 jobs, including Lint, Typecheck, Test & Build, which was still pending at the time of the last review). The Queue Dispatch Guard Gate ran both stages,adoptionandchain. This run applies to exactly the commit that will be merged (rollout step 0). The prodSHOW server_version=17.9 (Debian 17.9-1.pgdg13+1)and matches the version the CI chain stage logged.🤖 Generated with Claude Code