fix(sprint-conflicts): stories uit CLOSED/ARCHIVED/FAILED sprints zijn weer eligible
Bug: bij sprint-aanmaken (en story-toevoegen aan een actieve sprint) gaf de
backend "Geen eligible stories voor deze sprint" zodra je stories aanvinkte
die ooit in een sprint hadden gezeten — ook als die sprint allang gesloten
of gearchiveerd was. partitionByEligibility checkte alleen story.sprint_id,
nooit sprint.status, terwijl getBlockingSprintMap in dezelfde file wél al
filterde op sprint: { status: 'OPEN' }. Inconsistent.
Fix: partitionByEligibility en isEligibleForSprint wegen nu sprint.status
mee. Een story blokkeert alleen als hij in een ANDERE sprint zit DIE NOG
OPEN is. Stories uit CLOSED/ARCHIVED/FAILED sprints worden weer vrij voor
planning — story.sprint_id blijft als historische referentie staan tot de
volgende updateMany hem overschrijft naar de nieuwe sprint.
Neveneffect: een DONE story in een gesloten sprint krijgt nu reason='DONE'
i.p.v. het misleidende reason='IN_OTHER_SPRINT'.
Tests: 3 nieuwe scenario's in __tests__/lib/sprint-conflicts.test.ts
(CLOSED/ARCHIVED/FAILED → eligible, DONE-in-CLOSED → reason=DONE).
De oude test 'does NOT mark crossSprint for stories in CLOSED other sprint'
is vervangen omdat hij het bug-gedrag vastlegde.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
2b4b5bf719
commit
db37b66d17
2 changed files with 117 additions and 24 deletions
|
|
@ -37,20 +37,63 @@ describe('isEligibleForSprint', () => {
|
|||
).toBe(false)
|
||||
})
|
||||
|
||||
it('returns false when story is in any sprint (open status)', () => {
|
||||
it('returns false when story is in an OPEN sprint', () => {
|
||||
expect(
|
||||
isEligibleForSprint({
|
||||
sprint_id: 'abc',
|
||||
status: 'OPEN' as StoryStatus,
|
||||
status: 'IN_SPRINT' as StoryStatus,
|
||||
sprint: { status: 'OPEN' },
|
||||
}),
|
||||
).toBe(false)
|
||||
})
|
||||
|
||||
it('returns false when story is in any sprint (done status)', () => {
|
||||
it('returns false when story is DONE (sprint_id irrelevant)', () => {
|
||||
expect(
|
||||
isEligibleForSprint({
|
||||
sprint_id: 'abc',
|
||||
status: 'DONE' as StoryStatus,
|
||||
sprint: { status: 'CLOSED' },
|
||||
}),
|
||||
).toBe(false)
|
||||
})
|
||||
|
||||
it('returns true when story is in a CLOSED sprint (released back to planning)', () => {
|
||||
expect(
|
||||
isEligibleForSprint({
|
||||
sprint_id: 'abc',
|
||||
status: 'IN_SPRINT' as StoryStatus,
|
||||
sprint: { status: 'CLOSED' },
|
||||
}),
|
||||
).toBe(true)
|
||||
})
|
||||
|
||||
it('returns true when story is in an ARCHIVED sprint', () => {
|
||||
expect(
|
||||
isEligibleForSprint({
|
||||
sprint_id: 'abc',
|
||||
status: 'IN_SPRINT' as StoryStatus,
|
||||
sprint: { status: 'ARCHIVED' },
|
||||
}),
|
||||
).toBe(true)
|
||||
})
|
||||
|
||||
it('returns true when story is in a FAILED sprint', () => {
|
||||
expect(
|
||||
isEligibleForSprint({
|
||||
sprint_id: 'abc',
|
||||
status: 'IN_SPRINT' as StoryStatus,
|
||||
sprint: { status: 'FAILED' },
|
||||
}),
|
||||
).toBe(true)
|
||||
})
|
||||
|
||||
it('returns false when sprint_id is set but sprint relation is missing (defensive)', () => {
|
||||
// Zonder sprint-data weten we niet of die OPEN is, dus blijven we
|
||||
// conservatief — niet eligible.
|
||||
expect(
|
||||
isEligibleForSprint({
|
||||
sprint_id: 'abc',
|
||||
status: 'IN_SPRINT' as StoryStatus,
|
||||
}),
|
||||
).toBe(false)
|
||||
})
|
||||
|
|
@ -115,7 +158,45 @@ describe('partitionByEligibility', () => {
|
|||
expect(result.eligible).toEqual(['s1'])
|
||||
})
|
||||
|
||||
it('does NOT mark crossSprint for stories in CLOSED other sprint', async () => {
|
||||
it('frees stories from a CLOSED sprint — they become eligible again', async () => {
|
||||
const prisma = mockPrisma([
|
||||
{
|
||||
id: 's1',
|
||||
sprint_id: 'sprint-closed',
|
||||
status: 'IN_SPRINT',
|
||||
sprint: { id: 'sprint-closed', code: 'SP-C', status: 'CLOSED' },
|
||||
},
|
||||
])
|
||||
const result = await partitionByEligibility(prisma, ['s1'])
|
||||
expect(result.eligible).toEqual(['s1'])
|
||||
expect(result.crossSprint).toEqual([])
|
||||
expect(result.notEligible).toEqual([])
|
||||
})
|
||||
|
||||
it('frees stories from ARCHIVED and FAILED sprints', async () => {
|
||||
const prisma = mockPrisma([
|
||||
{
|
||||
id: 's1',
|
||||
sprint_id: 'sprint-arch',
|
||||
status: 'IN_SPRINT',
|
||||
sprint: { id: 'sprint-arch', code: 'SP-A', status: 'ARCHIVED' },
|
||||
},
|
||||
{
|
||||
id: 's2',
|
||||
sprint_id: 'sprint-fail',
|
||||
status: 'IN_SPRINT',
|
||||
sprint: { id: 'sprint-fail', code: 'SP-F', status: 'FAILED' },
|
||||
},
|
||||
])
|
||||
const result = await partitionByEligibility(prisma, ['s1', 's2'])
|
||||
expect(result.eligible).toEqual(['s1', 's2'])
|
||||
expect(result.notEligible).toEqual([])
|
||||
})
|
||||
|
||||
it('a DONE story in a CLOSED sprint is notEligible because DONE (sprint inactive)', async () => {
|
||||
// Volgorde: niet-actieve sprint blokkeert niet meer, dus de DONE-check
|
||||
// bepaalt de reason. Vroeger werd dit 'IN_OTHER_SPRINT' — dat was misleidend
|
||||
// omdat de sprint helemaal niet meer actief was.
|
||||
const prisma = mockPrisma([
|
||||
{
|
||||
id: 's1',
|
||||
|
|
@ -126,9 +207,8 @@ describe('partitionByEligibility', () => {
|
|||
])
|
||||
const result = await partitionByEligibility(prisma, ['s1'])
|
||||
expect(result.crossSprint).toEqual([])
|
||||
expect(result.notEligible).toEqual([
|
||||
{ storyId: 's1', reason: 'IN_OTHER_SPRINT' },
|
||||
])
|
||||
expect(result.notEligible).toEqual([{ storyId: 's1', reason: 'DONE' }])
|
||||
expect(result.eligible).toEqual([])
|
||||
})
|
||||
|
||||
it('respects excludeSprintId — story in same sprint is eligible', async () => {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue