From cde40d28c36cedf247843b2ddb5eeac20240b02d Mon Sep 17 00:00:00 2001 From: Madhura68 Date: Wed, 29 Apr 2026 17:19:15 +0200 Subject: [PATCH] test(ST-1109.9): cover PBI status mappers and sprint-close cascade - __tests__/lib/task-status.test.ts: 11 cases incl. round-trip + invalid input for task/story/pbi mappers; verifies PBI_STATUS_API_VALUES shape - __tests__/actions/sprints-cascade.test.ts: 8 cases for completeSprintAction: promote on all-DONE, no promote on partial OPEN, respect out-of-sprint story status, skip already-DONE PBIs, multi-PBI cascade, 0-story guard, demo-user block - Full vitest run: 170/170 green across 21 files Co-Authored-By: Claude Opus 4.7 (1M context) --- __tests__/actions/sprints-cascade.test.ts | 238 ++++++++++++++++++++++ __tests__/lib/task-status.test.ts | 85 ++++++++ 2 files changed, 323 insertions(+) create mode 100644 __tests__/actions/sprints-cascade.test.ts create mode 100644 __tests__/lib/task-status.test.ts diff --git a/__tests__/actions/sprints-cascade.test.ts b/__tests__/actions/sprints-cascade.test.ts new file mode 100644 index 0000000..b302716 --- /dev/null +++ b/__tests__/actions/sprints-cascade.test.ts @@ -0,0 +1,238 @@ +import { describe, it, expect, vi, beforeEach } from 'vitest' + +vi.mock('next/cache', () => ({ revalidatePath: vi.fn() })) +vi.mock('next/headers', () => ({ cookies: vi.fn().mockResolvedValue({}) })) +vi.mock('iron-session', () => ({ + getIronSession: vi.fn().mockResolvedValue({ userId: 'user-1', isDemo: false }), +})) +vi.mock('@/lib/session', () => ({ + sessionOptions: { cookieName: 'test', password: 'test' }, +})) +vi.mock('@/lib/product-access', () => ({ + productAccessFilter: vi.fn().mockReturnValue({}), + getAccessibleProduct: vi.fn().mockResolvedValue({ id: 'product-1' }), +})) +vi.mock('@/lib/prisma', () => ({ + prisma: { + sprint: { + findFirst: vi.fn(), + update: vi.fn(), + }, + story: { + findMany: vi.fn(), + update: vi.fn(), + }, + pbi: { + findMany: vi.fn(), + update: vi.fn(), + }, + $transaction: vi.fn().mockResolvedValue([]), + }, +})) + +import { prisma } from '@/lib/prisma' +import { completeSprintAction } from '@/actions/sprints' + +const mockPrisma = prisma as unknown as { + sprint: { + findFirst: ReturnType + update: ReturnType + } + story: { + findMany: ReturnType + update: ReturnType + } + pbi: { + findMany: ReturnType + update: ReturnType + } + $transaction: ReturnType +} + +const SPRINT = { id: 'sprint-1', product_id: 'product-1', status: 'ACTIVE' } + +beforeEach(() => { + vi.clearAllMocks() + mockPrisma.sprint.findFirst.mockResolvedValue(SPRINT) + mockPrisma.$transaction.mockResolvedValue([]) +}) + +describe('completeSprintAction — PBI auto-DONE cascade', () => { + it('marks PBI DONE when all its stories are decided DONE', async () => { + mockPrisma.story.findMany.mockResolvedValue([ + { id: 'story-a', pbi_id: 'pbi-1' }, + { id: 'story-b', pbi_id: 'pbi-1' }, + ]) + mockPrisma.pbi.findMany.mockResolvedValue([ + { + id: 'pbi-1', + stories: [ + { id: 'story-a', status: 'IN_SPRINT' }, + { id: 'story-b', status: 'IN_SPRINT' }, + ], + }, + ]) + + const result = await completeSprintAction('sprint-1', { + 'story-a': 'DONE', + 'story-b': 'DONE', + }) + + expect(result).toEqual({ success: true }) + expect(mockPrisma.pbi.update).toHaveBeenCalledTimes(1) + expect(mockPrisma.pbi.update).toHaveBeenCalledWith({ + where: { id: 'pbi-1' }, + data: { status: 'DONE' }, + }) + }) + + it('does not mark PBI DONE when a story is decided OPEN', async () => { + mockPrisma.story.findMany.mockResolvedValue([ + { id: 'story-a', pbi_id: 'pbi-1' }, + { id: 'story-b', pbi_id: 'pbi-1' }, + ]) + mockPrisma.pbi.findMany.mockResolvedValue([ + { + id: 'pbi-1', + stories: [ + { id: 'story-a', status: 'IN_SPRINT' }, + { id: 'story-b', status: 'IN_SPRINT' }, + ], + }, + ]) + + const result = await completeSprintAction('sprint-1', { + 'story-a': 'DONE', + 'story-b': 'OPEN', + }) + + expect(result).toEqual({ success: true }) + expect(mockPrisma.pbi.update).not.toHaveBeenCalled() + }) + + it('does not mark PBI DONE when it has stories outside this sprint that are not DONE', async () => { + mockPrisma.story.findMany.mockResolvedValue([ + { id: 'story-a', pbi_id: 'pbi-1' }, + ]) + mockPrisma.pbi.findMany.mockResolvedValue([ + { + id: 'pbi-1', + stories: [ + { id: 'story-a', status: 'IN_SPRINT' }, + { id: 'story-b', status: 'OPEN' }, + ], + }, + ]) + + const result = await completeSprintAction('sprint-1', { + 'story-a': 'DONE', + }) + + expect(result).toEqual({ success: true }) + expect(mockPrisma.pbi.update).not.toHaveBeenCalled() + }) + + it('marks PBI DONE when its in-sprint stories are DONE and out-of-sprint stories are already DONE', async () => { + mockPrisma.story.findMany.mockResolvedValue([ + { id: 'story-a', pbi_id: 'pbi-1' }, + ]) + mockPrisma.pbi.findMany.mockResolvedValue([ + { + id: 'pbi-1', + stories: [ + { id: 'story-a', status: 'IN_SPRINT' }, + { id: 'story-b', status: 'DONE' }, + ], + }, + ]) + + const result = await completeSprintAction('sprint-1', { + 'story-a': 'DONE', + }) + + expect(result).toEqual({ success: true }) + expect(mockPrisma.pbi.update).toHaveBeenCalledWith({ + where: { id: 'pbi-1' }, + data: { status: 'DONE' }, + }) + }) + + it('skips PBIs that are already DONE (promote-only)', async () => { + mockPrisma.story.findMany.mockResolvedValue([ + { id: 'story-a', pbi_id: 'pbi-1' }, + ]) + // pbi.findMany filters via { status: { not: 'DONE' } } in the action, + // so an already-DONE PBI just doesn't appear in candidatePbis. + mockPrisma.pbi.findMany.mockResolvedValue([]) + + const result = await completeSprintAction('sprint-1', { + 'story-a': 'DONE', + }) + + expect(result).toEqual({ success: true }) + expect(mockPrisma.pbi.update).not.toHaveBeenCalled() + expect(mockPrisma.pbi.findMany).toHaveBeenCalledWith({ + where: { id: { in: ['pbi-1'] }, status: { not: 'DONE' } }, + select: { id: true, stories: { select: { id: true, status: true } } }, + }) + }) + + it('cascades across multiple PBIs in one sprint close', async () => { + mockPrisma.story.findMany.mockResolvedValue([ + { id: 'story-a', pbi_id: 'pbi-1' }, + { id: 'story-b', pbi_id: 'pbi-2' }, + ]) + mockPrisma.pbi.findMany.mockResolvedValue([ + { id: 'pbi-1', stories: [{ id: 'story-a', status: 'IN_SPRINT' }] }, + { id: 'pbi-2', stories: [{ id: 'story-b', status: 'IN_SPRINT' }] }, + ]) + + const result = await completeSprintAction('sprint-1', { + 'story-a': 'DONE', + 'story-b': 'DONE', + }) + + expect(result).toEqual({ success: true }) + expect(mockPrisma.pbi.update).toHaveBeenCalledTimes(2) + expect(mockPrisma.pbi.update).toHaveBeenCalledWith({ + where: { id: 'pbi-1' }, + data: { status: 'DONE' }, + }) + expect(mockPrisma.pbi.update).toHaveBeenCalledWith({ + where: { id: 'pbi-2' }, + data: { status: 'DONE' }, + }) + }) + + it('does not include 0-story PBIs in cascade', async () => { + mockPrisma.story.findMany.mockResolvedValue([ + { id: 'story-a', pbi_id: 'pbi-1' }, + ]) + mockPrisma.pbi.findMany.mockResolvedValue([ + { id: 'pbi-1', stories: [] }, + ]) + + const result = await completeSprintAction('sprint-1', { + 'story-a': 'DONE', + }) + + expect(result).toEqual({ success: true }) + expect(mockPrisma.pbi.update).not.toHaveBeenCalled() + }) + + it('blocks sprint close for demo users', async () => { + const { getIronSession } = await import('iron-session') + ;(getIronSession as ReturnType).mockResolvedValueOnce({ + userId: 'user-demo', + isDemo: true, + }) + + const result = await completeSprintAction('sprint-1', { + 'story-a': 'DONE', + }) + + expect(result).toEqual({ error: 'Niet beschikbaar in demo-modus' }) + expect(mockPrisma.$transaction).not.toHaveBeenCalled() + expect(mockPrisma.pbi.update).not.toHaveBeenCalled() + }) +}) diff --git a/__tests__/lib/task-status.test.ts b/__tests__/lib/task-status.test.ts new file mode 100644 index 0000000..870b632 --- /dev/null +++ b/__tests__/lib/task-status.test.ts @@ -0,0 +1,85 @@ +import { describe, it, expect } from 'vitest' + +import { + taskStatusToApi, + taskStatusFromApi, + storyStatusToApi, + storyStatusFromApi, + pbiStatusToApi, + pbiStatusFromApi, + TASK_STATUS_API_VALUES, + STORY_STATUS_API_VALUES, + PBI_STATUS_API_VALUES, +} from '@/lib/task-status' + +describe('task-status mappers', () => { + describe('taskStatus', () => { + it('round-trips every API value', () => { + for (const api of TASK_STATUS_API_VALUES) { + const db = taskStatusFromApi(api) + expect(db).not.toBeNull() + expect(taskStatusToApi(db!)).toBe(api) + } + }) + + it('returns null for invalid input', () => { + expect(taskStatusFromApi('NOT_A_STATUS')).toBeNull() + }) + + it('is case-insensitive on the API side', () => { + expect(taskStatusFromApi('IN_PROGRESS')).toBe('IN_PROGRESS') + expect(taskStatusFromApi('In_Progress')).toBe('IN_PROGRESS') + }) + }) + + describe('storyStatus', () => { + it('round-trips every API value', () => { + for (const api of STORY_STATUS_API_VALUES) { + const db = storyStatusFromApi(api) + expect(db).not.toBeNull() + expect(storyStatusToApi(db!)).toBe(api) + } + }) + + it('returns null for invalid input', () => { + expect(storyStatusFromApi('archived')).toBeNull() + }) + }) + + describe('pbiStatus', () => { + it('round-trips every API value', () => { + for (const api of PBI_STATUS_API_VALUES) { + const db = pbiStatusFromApi(api) + expect(db).not.toBeNull() + expect(pbiStatusToApi(db!)).toBe(api) + } + }) + + it('maps DB to lowercase API', () => { + expect(pbiStatusToApi('READY')).toBe('ready') + expect(pbiStatusToApi('BLOCKED')).toBe('blocked') + expect(pbiStatusToApi('DONE')).toBe('done') + }) + + it('maps API to UPPER_SNAKE DB', () => { + expect(pbiStatusFromApi('ready')).toBe('READY') + expect(pbiStatusFromApi('blocked')).toBe('BLOCKED') + expect(pbiStatusFromApi('done')).toBe('DONE') + }) + + it('is case-insensitive on the API side', () => { + expect(pbiStatusFromApi('READY')).toBe('READY') + expect(pbiStatusFromApi('Blocked')).toBe('BLOCKED') + }) + + it('returns null for invalid input', () => { + expect(pbiStatusFromApi('archived')).toBeNull() + expect(pbiStatusFromApi('')).toBeNull() + expect(pbiStatusFromApi('todo')).toBeNull() + }) + + it('exposes exactly three API values', () => { + expect(PBI_STATUS_API_VALUES).toEqual(['ready', 'blocked', 'done']) + }) + }) +})