feat: ST-201-ST-210 M2 stories, drag-and-drop en Zustand stores

- usePlannerStore met pbiOrder/storyOrder init/reorder/rollback (ST-201)
- useSelectionStore uitgebreid met selectedStoryId en clearSelection (ST-202)
- PBI drag-and-drop binnen prioriteitsgroep via dnd-kit (ST-203)
- PBI slepen over prioriteitsgrens wijzigt priority (ST-204)
- Stories als blokken met prioriteit- en statusbadge (ST-205/ST-206)
- Story drag-and-drop horizontaal binnen en tussen groepen (ST-207)
- Story detail slide-over met bewerkformulier (ST-208)
- Story verwijderen met bevestigingsstap (ST-209)
- Filter op status en prioriteit in rechterpaneel (ST-210)
- Fix: infinite loop in useEffect door stabiele string dependency

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Janpeter Visser 2026-04-24 11:46:18 +02:00
parent ffda65490f
commit 4dd62c199c
25 changed files with 1794 additions and 100 deletions

View file

@ -1,15 +1,35 @@
'use client'
import { useState, useTransition } from 'react'
import { useState, useTransition, useEffect } from 'react'
import { useActionState } from 'react'
import { useFormStatus } from 'react-dom'
import {
DndContext,
DragEndEvent,
DragOverlay,
DragStartEvent,
PointerSensor,
useSensor,
useSensors,
closestCenter,
} from '@dnd-kit/core'
import {
SortableContext,
useSortable,
verticalListSortingStrategy,
arrayMove,
} from '@dnd-kit/sortable'
import { CSS } from '@dnd-kit/utilities'
import { toast } from 'sonner'
import { Button } from '@/components/ui/button'
import { Input } from '@/components/ui/input'
import { Badge } from '@/components/ui/badge'
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select'
import { PanelNavBar } from '@/components/shared/panel-nav-bar'
import { useSelectionStore } from '@/stores/selection-store'
import { usePlannerStore } from '@/stores/planner-store'
import { createPbiAction, deletePbiAction } from '@/actions/pbis'
import { reorderPbisAction, updatePbiPriorityAction } from '@/actions/stories'
import { cn } from '@/lib/utils'
const PRIORITY_LABELS: Record<number, string> = {
@ -38,7 +58,74 @@ interface PbiListProps {
isDemo: boolean
}
function CreatePbiForm({ productId, priority, onDone }: { productId: string; priority: number; onDone: () => void }) {
// --- Sortable PBI row ---
function SortablePbiRow({
pbi,
isSelected,
isDemo,
onSelect,
onDelete,
}: {
pbi: Pbi
isSelected: boolean
isDemo: boolean
onSelect: () => void
onDelete: () => void
}) {
const { attributes, listeners, setNodeRef, transform, transition, isDragging } = useSortable({
id: pbi.id,
})
const style = {
transform: CSS.Transform.toString(transform),
transition,
opacity: isDragging ? 0.4 : 1,
}
return (
<div
ref={setNodeRef}
style={style}
onClick={onSelect}
className={cn(
'group flex items-center justify-between px-4 py-2 cursor-pointer transition-colors hover:bg-surface-container',
isSelected && 'bg-primary-container text-primary-container-foreground'
)}
>
{!isDemo && (
<span
{...attributes}
{...listeners}
className="mr-2 text-muted-foreground cursor-grab active:cursor-grabbing shrink-0 select-none"
onClick={(e) => e.stopPropagation()}
>
</span>
)}
<span className="text-sm truncate flex-1">{pbi.title}</span>
{!isDemo && (
<button
onClick={(e) => { e.stopPropagation(); onDelete() }}
className="opacity-0 group-hover:opacity-100 ml-2 text-muted-foreground hover:text-error text-xs shrink-0"
aria-label="Verwijder PBI"
>
×
</button>
)}
</div>
)
}
// --- Inline create form ---
function CreatePbiForm({
productId,
priority,
onDone,
}: {
productId: string
priority: number
onDone: () => void
}) {
const [state, formAction] = useActionState(
async (_prev: unknown, fd: FormData) => {
const result = await createPbiAction(_prev, fd)
@ -53,16 +140,10 @@ function CreatePbiForm({ productId, priority, onDone }: { productId: string; pri
<form action={formAction} className="flex gap-2 p-2">
<input type="hidden" name="productId" value={productId} />
<input type="hidden" name="priority" value={priority} />
<Input
name="title"
autoFocus
placeholder="PBI-titel…"
className="h-7 text-sm"
required
/>
<Input name="title" autoFocus placeholder="PBI-titel…" className="h-7 text-sm" required />
<CreateSubmitButton />
<Button type="button" variant="ghost" size="sm" className="h-7" onClick={onDone}>
Annuleren
×
</Button>
{typeof error === 'string' && (
<p className="text-xs text-error self-center">{error}</p>
@ -80,13 +161,33 @@ function CreateSubmitButton() {
)
}
// --- Main component ---
export function PbiList({ productId, pbis, isDemo }: PbiListProps) {
const { selectedPbiId, selectPbi } = useSelectionStore()
const { pbiOrder, pbiPriority, initPbis, reorderPbis, rollbackPbis, updatePbiPriority } = usePlannerStore()
const [filterPriority, setFilterPriority] = useState<number | null>(null)
const [creatingForPriority, setCreatingForPriority] = useState<number | null>(null)
const [activeDragId, setActiveDragId] = useState<string | null>(null)
const [, startTransition] = useTransition()
const filtered = filterPriority ? pbis.filter(p => p.priority === filterPriority) : pbis
// Sync server data into store — use stable string dep to avoid infinite loop
const pbiIdKey = pbis.map(p => p.id).join(',')
useEffect(() => {
initPbis(productId, pbiIdKey ? pbiIdKey.split(',') : [])
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [productId, pbiIdKey])
// Build ordered PBI list from store (or fall back to server order)
const order = pbiOrder[productId] ?? pbis.map(p => p.id)
const pbiMap = Object.fromEntries(pbis.map(p => [p.id, p]))
// Apply priority overrides from store
const orderedPbis = order
.map(id => pbiMap[id])
.filter(Boolean)
.map(p => ({ ...p, priority: pbiPriority[p.id] ?? p.priority }))
const filtered = filterPriority ? orderedPbis.filter(p => p.priority === filterPriority) : orderedPbis
const grouped = [1, 2, 3, 4].reduce<Record<number, Pbi[]>>((acc, p) => {
acc[p] = filtered.filter(pbi => pbi.priority === p)
@ -97,6 +198,49 @@ export function PbiList({ productId, pbis, isDemo }: PbiListProps) {
p => grouped[p].length > 0 || creatingForPriority === p
)
const sensors = useSensors(useSensor(PointerSensor, { activationConstraint: { distance: 5 } }))
function handleDragStart(event: DragStartEvent) {
setActiveDragId(event.active.id as string)
}
function handleDragEnd(event: DragEndEvent) {
setActiveDragId(null)
const { active, over } = event
if (!over || active.id === over.id) return
const activePbi = pbiMap[active.id as string]
const overPbi = pbiMap[over.id as string]
if (!activePbi || !overPbi) return
const prevOrder = [...order]
const oldIndex = order.indexOf(active.id as string)
const newIndex = order.indexOf(over.id as string)
const newOrder = arrayMove([...order], oldIndex, newIndex)
// Optimistic update
reorderPbis(productId, newOrder)
const priorityChanged = activePbi.priority !== overPbi.priority
startTransition(async () => {
if (priorityChanged) {
updatePbiPriority(active.id as string, overPbi.priority)
const result = await updatePbiPriorityAction(active.id as string, overPbi.priority, productId)
if (!result.success) {
rollbackPbis(productId, prevOrder)
toast.error('Prioriteit opslaan mislukt')
}
} else {
const result = await reorderPbisAction(productId, newOrder)
if (!result.success) {
rollbackPbis(productId, prevOrder)
toast.error('Volgorde opslaan mislukt')
}
}
})
}
function handleDelete(id: string) {
startTransition(async () => {
await deletePbiAction(id)
@ -104,6 +248,8 @@ export function PbiList({ productId, pbis, isDemo }: PbiListProps) {
})
}
const activePbi = activeDragId ? pbiMap[activeDragId] : null
return (
<div className="flex flex-col h-full">
<PanelNavBar
@ -160,76 +306,81 @@ export function PbiList({ productId, pbis, isDemo }: PbiListProps) {
)}
</div>
) : (
<div className="py-2">
{visiblePriorities.map(priority => (
<div key={priority}>
{/* Priority group header */}
<div className="flex items-center gap-2 px-4 py-1.5">
<span className={cn('text-xs font-semibold px-2 py-0.5 rounded-full border', PRIORITY_COLORS[priority])}>
{PRIORITY_LABELS[priority]}
</span>
<div className="flex-1 h-px bg-border" />
{!isDemo && (
<button
onClick={() => setCreatingForPriority(priority)}
className="text-xs text-muted-foreground hover:text-foreground"
>
+
</button>
)}
</div>
{/* PBI items */}
{grouped[priority].map(pbi => (
<div
key={pbi.id}
onClick={() => selectPbi(pbi.id)}
className={cn(
'group flex items-center justify-between px-4 py-2 cursor-pointer transition-colors hover:bg-surface-container',
selectedPbiId === pbi.id && 'bg-primary-container text-primary-container-foreground'
)}
>
<span className="text-sm truncate flex-1">{pbi.title}</span>
<DndContext
sensors={sensors}
collisionDetection={closestCenter}
onDragStart={handleDragStart}
onDragEnd={handleDragEnd}
>
<div className="py-2">
{visiblePriorities.map(priority => (
<div key={priority}>
<div className="flex items-center gap-2 px-4 py-1.5">
<span className={cn('text-xs font-semibold px-2 py-0.5 rounded-full border', PRIORITY_COLORS[priority])}>
{PRIORITY_LABELS[priority]}
</span>
<div className="flex-1 h-px bg-border" />
{!isDemo && (
<button
onClick={(e) => { e.stopPropagation(); handleDelete(pbi.id) }}
className="opacity-0 group-hover:opacity-100 ml-2 text-muted-foreground hover:text-error text-xs shrink-0"
aria-label="Verwijder PBI"
onClick={() => setCreatingForPriority(priority)}
className="text-xs text-muted-foreground hover:text-foreground"
>
×
+
</button>
)}
</div>
))}
{/* Inline create form for this priority */}
{creatingForPriority === priority && (
<SortableContext
items={grouped[priority].map(p => p.id)}
strategy={verticalListSortingStrategy}
>
{grouped[priority].map(pbi => (
<SortablePbiRow
key={pbi.id}
pbi={pbi}
isSelected={selectedPbiId === pbi.id}
isDemo={isDemo}
onSelect={() => selectPbi(pbi.id)}
onDelete={() => handleDelete(pbi.id)}
/>
))}
</SortableContext>
{creatingForPriority === priority && (
<CreatePbiForm
productId={productId}
priority={priority}
onDone={() => setCreatingForPriority(null)}
/>
)}
</div>
))}
{creatingForPriority !== null && !visiblePriorities.includes(creatingForPriority) && (
<div>
<div className="flex items-center gap-2 px-4 py-1.5">
<span className={cn('text-xs font-semibold px-2 py-0.5 rounded-full border', PRIORITY_COLORS[creatingForPriority])}>
{PRIORITY_LABELS[creatingForPriority]}
</span>
<div className="flex-1 h-px bg-border" />
</div>
<CreatePbiForm
productId={productId}
priority={priority}
priority={creatingForPriority}
onDone={() => setCreatingForPriority(null)}
/>
)}
</div>
))}
{/* If creating for a priority that has no items yet and isn't in visiblePriorities */}
{creatingForPriority !== null && !visiblePriorities.includes(creatingForPriority) && (
<div>
<div className="flex items-center gap-2 px-4 py-1.5">
<span className={cn('text-xs font-semibold px-2 py-0.5 rounded-full border', PRIORITY_COLORS[creatingForPriority])}>
{PRIORITY_LABELS[creatingForPriority]}
</span>
<div className="flex-1 h-px bg-border" />
</div>
<CreatePbiForm
productId={productId}
priority={creatingForPriority}
onDone={() => setCreatingForPriority(null)}
/>
</div>
)}
</div>
)}
</div>
<DragOverlay>
{activePbi && (
<div className="bg-surface-container-low border border-primary rounded px-4 py-2 text-sm shadow-lg opacity-90">
{activePbi.title}
</div>
)}
</DragOverlay>
</DndContext>
)}
</div>
</div>